From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/i915/guc: stop using kmap_atomic()
 during request submission
Date: Fri, 15 Apr 2016 11:08:05 +0100
Message-ID: <5710BD85.2040001@linux.intel.com>
References: <1460654342-6071-1-git-send-email-david.s.gordon@intel.com>
 <1460654342-6071-2-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id BE37C6EBF5
 for <intel-gfx@lists.freedesktop.org>; Fri, 15 Apr 2016 10:08:09 +0000 (UTC)
In-Reply-To: <1460654342-6071-2-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE0LzA0LzE2IDE4OjE5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBGcm9tOiBBbGV4IERhaSA8
eXUuZGFpQGludGVsLmNvbT4KPgo+IE5vdyB0aGF0IHdlIGtlZXAgR3VDIHNoYXJlZCBvYmplY3Rz
IG1hcHBlZCBpbnRvIGtlcm5lbCBzcGFjZSBmb3IgdGhlaXIKPiBlbnRpcmUgbGlmZXRpbWUsIHdl
IGNhbiBzaW1wbGlmeSB0aGUgY29kZSBmb3IgYWNjZXNzaW5nIHRoZSBkb29yYmVsbHMKPiBhbmQg
d29yayBxdWV1ZSwgd2hpY2ggd2VyZSBwcmV2aW91c2x5IGNhbGxpbmcga21hcF9hdG9taWMoKSBv
biAqZWFjaCoKPiByZXF1ZXN0IHN1Ym1pc3Npb24uCj4KPiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBC
VUcgc2hvd24gYmVsb3csIHdoZXJlIHRoZSB0aHJlYWQgY291bGQgc2xlZXAKPiB3aGlsZSBob2xk
aW5nIHRoZSBrbWFwX2F0b21pYyBtYXBwaW5nLgo+Cj4gWyAgIDM0LjA5ODc5OF0gQlVHOiBzY2hl
ZHVsaW5nIHdoaWxlIGF0b21pYzoKPiBnZW1fY2xvc2VfcmFjZS8xOTQxLzB4MDAwMDAwMDIKPiBb
ICAgMzQuMDk4ODIyXSBNb2R1bGVzIGxpbmtlZCBpbjogaGlkX2dlbmVyaWMgdXNiaGlkIGk5MTUg
YXNpeCB1c2JuZXQKPiBsaWJwaHkgbWlpIGkyY19hbGdvX2JpdCBkcm1fa21zX2hlbHBlciBjZmJm
aWxscmVjdCBzeXNjb3B5YXJlYSBjZmJpbWdibHQKPiBzeXNmaWxscmVjdCBzeXNpbWdibHQgZmJf
c3lzX2ZvcHMgY2ZiY29weWFyZWEgZHJtIGNvcmV0ZW1wIGkyY19oaWQgaGlkCj4gdmlkZW8gcGlu
Y3RybF9zdW5yaXNlcG9pbnQgcGluY3RybF9pbnRlbCBhY3BpX3BhZCBubHNfaXNvODg1OV8xIGUx
MDAwZQo+IHB0cCBwc21vdXNlIHBwc19jb3JlIGFoY2kgbGliYWhjaQo+IFsgICAzNC4wOTg4MjRd
IENQVTogMCBQSUQ6IDE5NDEgQ29tbTogZ2VtX2Nsb3NlX3JhY2UgVGFpbnRlZDogRyAgICAgVQo+
ICAgICAgICAgICAgNC40LjAtMTYwMTIxKyAjMTIzCj4gWyAgIDM0LjA5ODgyNF0gSGFyZHdhcmUg
bmFtZTogSW50ZWwgQ29ycG9yYXRpb24gU2t5bGFrZSBDbGllbnQKPiBwbGF0Zm9ybS9Ta3lsYWtl
IEFJTyBERFIzTCBSVlAxMCwgQklPUyBTS0xTRTJSMS5SMDAuWDEwMC5CMDEuMTUwOTIyMDU1MQo+
IDA5LzIyLzIwMTUKPiBbICAgMzQuMDk4ODI1XSAgMDAwMDAwMDAwMDAxM2U0MCBmZmZmODgwMTY2
YzI3YTc4IGZmZmZmZmZmODEyODBkMDIKPiBmZmZmODgwMTcyYzEzZTQwCj4gWyAgIDM0LjA5ODgy
Nl0gIGZmZmY4ODAxNjZjMjdhODggZmZmZmZmZmY4MTBjMjAzYSBmZmZmODgwMTY2YzI3YWM4Cj4g
ZmZmZmZmZmY4MTRlYzgwOAo+IFsgICAzNC4wOTg4MjddICBmZmZmODgwMTZiN2M2MDAwIGZmZmY4
ODAxNjZjMjgwMDAgMDAwMDAwMDAwMDBmNDI0MAo+IDAwMDAwMDAwMDAwMDAwMDEKPiBbICAgMzQu
MDk4ODI3XSBDYWxsIFRyYWNlOgo+IFsgICAzNC4wOTg4MzFdICBbPGZmZmZmZmZmODEyODBkMDI+
XSBkdW1wX3N0YWNrKzB4NGIvMHg3OQo+IFsgICAzNC4wOTg4MzNdICBbPGZmZmZmZmZmODEwYzIw
M2E+XSBfX3NjaGVkdWxlX2J1ZysweDQxLzB4NGYKPiBbICAgMzQuMDk4ODM0XSAgWzxmZmZmZmZm
ZjgxNGVjODA4Pl0gX19zY2hlZHVsZSsweDVhOC8weDY5MAo+IFsgICAzNC4wOTg4MzVdICBbPGZm
ZmZmZmZmODE0ZWM5Mjc+XSBzY2hlZHVsZSsweDM3LzB4ODAKPiBbICAgMzQuMDk4ODM2XSAgWzxm
ZmZmZmZmZjgxNGVmM2ZkPl0KPiBzY2hlZHVsZV9ocnRpbWVvdXRfcmFuZ2VfY2xvY2srMHhhZC8w
eDEzMAo+IFsgICAzNC4wOTg4MzddICBbPGZmZmZmZmZmODEwOTBiZTA+XSA/IGhydGltZXJfaW5p
dCsweDEwLzB4MTAKPiBbICAgMzQuMDk4ODM4XSAgWzxmZmZmZmZmZjgxNGVmM2YxPl0gPwo+IHNj
aGVkdWxlX2hydGltZW91dF9yYW5nZV9jbG9jaysweGExLzB4MTMwCj4gWyAgIDM0LjA5ODgzOV0g
IFs8ZmZmZmZmZmY4MTRlZjQ4ZT5dIHNjaGVkdWxlX2hydGltZW91dF9yYW5nZSsweGUvMHgxMAo+
IFsgICAzNC4wOTg4NDBdICBbPGZmZmZmZmZmODE0ZWVmOWI+XSB1c2xlZXBfcmFuZ2UrMHgzYi8w
eDQwCj4gWyAgIDM0LjA5ODg1M10gIFs8ZmZmZmZmZmZhMDFlYzEwOT5dIGk5MTVfZ3VjX3dxX2No
ZWNrX3NwYWNlKzB4MTE5LzB4MjEwCj4gW2k5MTVdCj4gWyAgIDM0LjA5ODg2MV0gIFs8ZmZmZmZm
ZmZhMDFkYTQ3Yz5dCj4gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzKzB4
NWMvMHg3MCBbaTkxNV0KPiBbICAgMzQuMDk4ODY5XSAgWzxmZmZmZmZmZmEwMWNkYmYxPl0gaTkx
NV9nZW1fcmVxdWVzdF9hbGxvYysweDkxLzB4MTcwCj4gW2k5MTVdCj4gWyAgIDM0LjA5ODg3NV0g
IFs8ZmZmZmZmZmZhMDFjMWMwNz5dCj4gaTkxNV9nZW1fZG9fZXhlY2J1ZmZlci5pc3JhLjI1KzB4
YmM3LzB4MTJhMCBbaTkxNV0KPiBbICAgMzQuMDk4ODgyXSAgWzxmZmZmZmZmZmEwMWNiNzg1Pl0g
Pwo+IGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZXNfZ3R0KzB4MjI1LzB4M2MwIFtpOTE1XQo+IFsg
ICAzNC4wOTg4ODldICBbPGZmZmZmZmZmYTAxZDFmYjY+XSA/IGk5MTVfZ2VtX3B3cml0ZV9pb2N0
bCsweGQ2LzB4OWYwCj4gW2k5MTVdCj4gWyAgIDM0LjA5ODg5NV0gIFs8ZmZmZmZmZmZhMDFjMmU2
OD5dIGk5MTVfZ2VtX2V4ZWNidWZmZXIyKzB4YTgvMHgyNTAKPiBbaTkxNV0KPiBbICAgMzQuMDk4
OTAwXSAgWzxmZmZmZmZmZmEwMGY2NWQ4Pl0gZHJtX2lvY3RsKzB4MjU4LzB4NGYwIFtkcm1dCj4g
WyAgIDM0LjA5ODkwNl0gIFs8ZmZmZmZmZmZhMDFjMmRjMD5dID8gaTkxNV9nZW1fZXhlY2J1ZmZl
cisweDM0MC8weDM0MAo+IFtpOTE1XQo+IFsgICAzNC4wOTg5MDhdICBbPGZmZmZmZmZmODExMTU5
MGQ+XSBkb192ZnNfaW9jdGwrMHgyY2QvMHg0YTAKPiBbICAgMzQuMDk4OTA5XSAgWzxmZmZmZmZm
ZjgxMTFlYWMyPl0gPyBfX2ZnZXQrMHg3Mi8weGIwCj4gWyAgIDM0LjA5ODkxMF0gIFs8ZmZmZmZm
ZmY4MTExNWIxYz5dIFN5U19pb2N0bCsweDNjLzB4NzAKPiBbICAgMzQuMDk4OTExXSAgWzxmZmZm
ZmZmZjgxNGVmZmQ3Pl0gZW50cnlfU1lTQ0FMTF82NF9mYXN0cGF0aCsweDEyLzB4NmEKPiBbICAg
MzQuMTAwMjA4XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KPgo+IEJ1Z3pp
bGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzg0Nwo+
IENjOiA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogPHR2cnRrby51cnN1bGluQGludGVs
LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiBTaWdu
ZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IC0tLQo+
ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgMjEgKysrKy0t
LS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxNyBk
ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1
Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9u
LmMKPiBpbmRleCBmODBmNTc3Li5mYmQ1N2NhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC0xOTEsMTEgKzE5MSw5IEBAIHN0YXRpYyBpbnQg
Z3VjX3JpbmdfZG9vcmJlbGwoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MpCj4gICAJc3RydWN0
IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4gICAJdW5pb24gZ3VjX2Rvb3JiZWxsX3F3IGRiX2Nt
cCwgZGJfZXhjLCBkYl9yZXQ7Cj4gICAJdW5pb24gZ3VjX2Rvb3JiZWxsX3F3ICpkYjsKPiAtCXZv
aWQgKmJhc2U7Cj4gICAJaW50IGF0dGVtcHQgPSAyLCByZXQgPSAtRUFHQUlOOwo+Cj4gLQliYXNl
ID0ga21hcF9hdG9taWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGdjLT5jbGllbnRfb2JqLCAw
KSk7Cj4gLQlkZXNjID0gYmFzZSArIGdjLT5wcm9jX2Rlc2Nfb2Zmc2V0Owo+ICsJZGVzYyA9IGdj
LT5jbGllbnRfYmFzZSArIGdjLT5wcm9jX2Rlc2Nfb2Zmc2V0Owo+Cj4gICAJLyogVXBkYXRlIHRo
ZSB0YWlsIHNvIGl0IGlzIHZpc2libGUgdG8gR3VDICovCj4gICAJZGVzYy0+dGFpbCA9IGdjLT53
cV90YWlsOwo+IEBAIC0yMTEsNyArMjA5LDcgQEAgc3RhdGljIGludCBndWNfcmluZ19kb29yYmVs
bChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYykKPiAgIAkJZGJfZXhjLmNvb2tpZSA9IDE7Cj4K
PiAgIAkvKiBwb2ludGVyIG9mIGN1cnJlbnQgZG9vcmJlbGwgY2FjaGVsaW5lICovCj4gLQlkYiA9
IGJhc2UgKyBnYy0+ZG9vcmJlbGxfb2Zmc2V0Owo+ICsJZGIgPSBnYy0+Y2xpZW50X2Jhc2UgKyBn
Yy0+ZG9vcmJlbGxfb2Zmc2V0Owo+Cj4gICAJd2hpbGUgKGF0dGVtcHQtLSkgewo+ICAgCQkvKiBs
ZXRzIHJpbmcgdGhlIGRvb3JiZWxsICovCj4gQEAgLTI0Myw3ICsyNDEsNiBAQCBzdGF0aWMgaW50
IGd1Y19yaW5nX2Rvb3JiZWxsKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ICAgCS8qIEZp
bmFsbHksIHVwZGF0ZSB0aGUgY2FjaGVkIGNvcHkgb2YgdGhlIEd1QydzIFdRIGhlYWQgKi8KPiAg
IAlnYy0+d3FfaGVhZCA9IGRlc2MtPmhlYWQ7Cj4KPiAtCWt1bm1hcF9hdG9taWMoYmFzZSk7Cj4g
ICAJcmV0dXJuIHJldDsKPiAgIH0KPgo+IEBAIC00NjIsNyArNDU5LDYgQEAgc3RhdGljIHZvaWQg
Z3VjX2ZpbmlfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+ICAgaW50IGk5MTVfZ3Vj
X3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ICAgewo+ICAgCXN0
cnVjdCBndWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+IC0Jdm9pZCAqYmFzZTsKPiAgIAl1MzIgc2l6
ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+ICAgCWludCByZXQgPSAtRVRJTUVET1VU
LCB0aW1lb3V0X2NvdW50ZXIgPSAyMDA7Cj4KPiBAQCAtNDc0LDggKzQ3MCw3IEBAIGludCBpOTE1
X2d1Y193cV9jaGVja19zcGFjZShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYykKPiAgIAlpZiAo
Q0lSQ19TUEFDRShnYy0+d3FfdGFpbCwgZ2MtPndxX2hlYWQsIGdjLT53cV9zaXplKSA+PSBzaXpl
KQo+ICAgCQlyZXR1cm4gMDsKPgo+IC0JYmFzZSA9IGttYXBfYXRvbWljKGk5MTVfZ2VtX29iamVj
dF9nZXRfcGFnZShnYy0+Y2xpZW50X29iaiwgMCkpOwo+IC0JZGVzYyA9IGJhc2UgKyBnYy0+cHJv
Y19kZXNjX29mZnNldDsKPiArCWRlc2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNj
X29mZnNldDsKPgo+ICAgCXdoaWxlICh0aW1lb3V0X2NvdW50ZXItLSA+IDApIHsKPiAgIAkJZ2Mt
PndxX2hlYWQgPSBkZXNjLT5oZWFkOwo+IEBAIC00ODksOCArNDg0LDYgQEAgaW50IGk5MTVfZ3Vj
X3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ICAgCQkJdXNsZWVw
X3JhbmdlKDEwMDAsIDIwMDApOwo+ICAgCX07Cj4KPiAtCWt1bm1hcF9hdG9taWMoYmFzZSk7Cj4g
LQo+ICAgCXJldHVybiByZXQ7Cj4gICB9CgpZZXMsIGFzIEkgY29tbWVudGVkIGluIHRoZSBwcmV2
aW91cyBwYXRjaCBpbiB0aGUgc2VyaWVzLCBpZiB0aGUgCmxpZmV0aW1lcyBhbGxvdyBpdCwgaXQg
d291bGQgYmUgc2hvcnRlciB0byBoYXZlIGdjLT5kb29yYmVsbCBhbmQgCmdjLT5kZXNjIGFuZCB0
aGVuIGZ1bmN0aW9ucyBsaWtlIHRoZXNlIHdvdWxkIG5vdCBoYXZlIHRvIGRvIGFueXRoaW5nIGJ1
dCAKdXNlIHRoZW0uCgpSZWdhcmRzLAoKVHZydGtvCgoKPgo+IEBAIC00OTgsNyArNDkxLDYgQEAg
c3RhdGljIGludCBndWNfYWRkX3dvcmtxdWV1ZV9pdGVtKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQg
KmdjLAo+ICAgCQkJCSAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSkKPiAgIHsKPiAg
IAlzdHJ1Y3QgZ3VjX3dxX2l0ZW0gKndxaTsKPiAtCXZvaWQgKmJhc2U7Cj4gICAJdTMyIHRhaWws
IHdxX2xlbiwgd3Ffb2ZmLCBzcGFjZTsKPgo+ICAgCXNwYWNlID0gQ0lSQ19TUEFDRShnYy0+d3Ff
dGFpbCwgZ2MtPndxX2hlYWQsIGdjLT53cV9zaXplKTsKPiBAQCAtNTIxLDEwICs1MTMsNyBAQCBz
dGF0aWMgaW50IGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAq
Z2MsCj4gICAJV0FSTl9PTih3cV9vZmYgJiAzKTsKPgo+ICAgCS8qIHdxIHN0YXJ0cyBmcm9tIHRo
ZSBwYWdlIGFmdGVyIGRvb3JiZWxsIC8gcHJvY2Vzc19kZXNjICovCj4gLQliYXNlID0ga21hcF9h
dG9taWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGdjLT5jbGllbnRfb2JqLAo+IC0JCQkod3Ff
b2ZmICsgR1VDX0RCX1NJWkUpID4+IFBBR0VfU0hJRlQpKTsKPiAtCXdxX29mZiAmPSBQQUdFX1NJ
WkUgLSAxOwo+IC0Jd3FpID0gKHN0cnVjdCBndWNfd3FfaXRlbSAqKSgoY2hhciAqKWJhc2UgKyB3
cV9vZmYpOwo+ICsJd3FpID0gZ2MtPmNsaWVudF9iYXNlICsgR1VDX0RCX1NJWkUgKyB3cV9vZmY7
Cj4KPiAgIAkvKiBsZW4gZG9lcyBub3QgaW5jbHVkZSB0aGUgaGVhZGVyICovCj4gICAJd3FfbGVu
ID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSkgLyBzaXplb2YodTMyKSAtIDE7Cj4gQEAgLTU0
Miw4ICs1MzEsNiBAQCBzdGF0aWMgaW50IGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5
MTVfZ3VjX2NsaWVudCAqZ2MsCj4gICAJd3FpLT5yaW5nX3RhaWwgPSB0YWlsIDw8IFdRX1JJTkdf
VEFJTF9TSElGVDsKPiAgIAl3cWktPmZlbmNlX2lkID0gMDsgLypYWFg6IHdoYXQgZmVuY2UgdG8g
YmUgaGVyZSAqLwo+Cj4gLQlrdW5tYXBfYXRvbWljKGJhc2UpOwo+IC0KPiAgIAlyZXR1cm4gMDsK
PiAgIH0KPgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=