From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar0rk-0000DB-Qm for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar0rg-00058d-Ql for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:20:44 -0400 References: <1460646893-32622-1-git-send-email-thuth@redhat.com> From: Mark Cave-Ayland Message-ID: <5710C053.4060805@ilande.co.uk> Date: Fri, 15 Apr 2016 11:20:03 +0100 MIME-Version: 1.0 In-Reply-To: <1460646893-32622-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] ppc: Fixes for LSWX and LSWI instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Alexander Graf , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, lvivier@redhat.com, david@gibson.dropbear.id.au On 14/04/16 16:14, Thomas Huth wrote: > These two patches fix the bad range checks in the LSWI and LSWX > instructions. > > To see the change in behavior for the lswx instruction, you can use the > "emulator" test from the kvm-unit-tests suite - code can be found here: > > https://git.kernel.org/cgit/virt/kvm/kvm-unit-tests.git/tree/powerpc/emulator.c#n95 > > For testing the lswi instruction, an additional kvm-unit-test can be > used, see the patch that I've posted here: > > https://patchwork.ozlabs.org/patch/610483/ > > > Thomas Huth (2): > ppc: Fix the range check in the LSWI instruction > ppc: Fix the bad exception NIP value and the range check in LSWX > > target-ppc/cpu.h | 10 ++++++++++ > target-ppc/mem_helper.c | 5 +++-- > target-ppc/translate.c | 6 ++---- > 3 files changed, 15 insertions(+), 6 deletions(-) I see David has already queued these, however I did give them a spin on my OpenBIOS PPC test images and didn't see any obvious regressions. ATB, Mark.