All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Intel GFX discussion <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest
Date: Fri, 15 Apr 2016 11:23:06 +0100	[thread overview]
Message-ID: <5710C10A.9010708@linux.intel.com> (raw)
In-Reply-To: <1460713821-17420-1-git-send-email-tomeu.vizoso@collabora.com>


On 15/04/16 10:50, Tomeu Vizoso wrote:
> When moving the call to gem_set_tiling into the subtests, the one needed
> by addfb25-framebuffer-vs-set-tiling was left out.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>   tests/kms_addfb_basic.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 30f312291fe7..64047303dea7 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -385,6 +385,7 @@ static void addfb25_tests(int fd)
>   	}
>
>   	igt_subtest("addfb25-framebuffer-vs-set-tiling") {
> +		gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
>   		igt_require_fb_modifiers(fd);
>
>   		f.modifier[0] = LOCAL_I915_FORMAT_MOD_X_TILED;
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks for fixing it! I'll push it shortly.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-04-15 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15  9:50 [PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest Tomeu Vizoso
2016-04-15 10:23 ` Tvrtko Ursulin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5710C10A.9010708@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.