All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mips: fix DTC unit warnings
Date: Fri, 15 Apr 2016 17:23:54 +0200	[thread overview]
Message-ID: <5711078A.5010803@suse.de> (raw)
In-Reply-To: <1460717976-24683-1-git-send-email-hs@denx.de>

Am 15.04.2016 um 12:59 schrieb Heiko Schocher:
> Fix following warnings for all mips based boards:
>      mips:  +   pic32mzdask
> +Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> +Warning (unit_address_vs_reg): Node /cpus/cpu at 0 has a unit name, but no reg property
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> This warnings pop up with the DTC compiler:
> $ /tmp/dtc/dtc -v
> Version: DTC 1.4.1-gbeef80b8
> 
> This fixes the compile warnings for:
> https://travis-ci.org/hsdenx/u-boot/jobs/123254184
> 
> see:
> https://travis-ci.org/hsdenx/u-boot/jobs/123281033
> 
> 
>  arch/mips/dts/pic32mzda.dtsi | 2 +-
>  arch/mips/dts/skeleton.dtsi  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mips/dts/pic32mzda.dtsi
> index 8a554f9..791c364 100644
> --- a/arch/mips/dts/pic32mzda.dtsi
> +++ b/arch/mips/dts/pic32mzda.dtsi
> @@ -27,7 +27,7 @@
>  	};
>  
>  	cpus {
> -		cpu at 0 {
> +		cpu {
>  			compatible = "mips,mips14kc";
>  		};
>  	};
> diff --git a/arch/mips/dts/skeleton.dtsi b/arch/mips/dts/skeleton.dtsi
> index 24ee6c3..643996c 100644
> --- a/arch/mips/dts/skeleton.dtsi
> +++ b/arch/mips/dts/skeleton.dtsi
> @@ -16,7 +16,7 @@
>  	aliases {
>  	};
>  
> -	memory {
> +	memory at 0 {

I have just been told on linux-rockchip mailing list that such a change
should not be done as /memory is being special-cased in dtc warnings for
the benefit of U-Boot. Supposedly U-Boot cannot handle updating memory
size on /memory at 0.

If that is untrue, please someone object on the Linux mailing lists.

Regards,
Andreas

>  		device_type = "memory";
>  		reg = <0 0>;
>  	};
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  parent reply	other threads:[~2016-04-15 15:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 10:59 [U-Boot] [PATCH] mips: fix DTC unit warnings Heiko Schocher
2016-04-15 11:08 ` Purna Chandra Mandal
2016-04-15 11:13 ` Daniel Schwierzeck
2016-04-15 15:23 ` Andreas Färber [this message]
2016-04-15 16:30   ` Tom Rini
2016-04-15 16:56     ` Stephen Warren
2016-04-15 17:11       ` Tom Rini
2016-04-15 17:37         ` Stephen Warren
2016-04-15 17:45           ` Tom Rini
2016-04-18  5:38       ` Heiko Schocher
2016-04-18 15:30         ` Tom Rini
2016-04-15 18:08     ` Heiko Stübner
2016-04-18 12:48   ` Purna Chandra Mandal
2016-04-18 15:31 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5711078A.5010803@suse.de \
    --to=afaerber@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.