Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace

[Jonathan Cameron <jic23@kernel.org>]

On 15/04/16 15:56, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
>> On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
>>> This fixes the error reported by checkpatch.pl:
>>>
>>> ERROR: that open brace { should be on the previous line
>>>
>>> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
I find it rather hard to care about this, but perhaps it is just a 'tiny' bit
more readable and there are definite advantages in suppressing some of the
output of checkpatch so the 'real' issues are easily spotted!

Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
>>> ---
>>>  drivers/iio/light/apds9960.c | 8 ++++++--
>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
>>> index a6af56a..ade18aa 100644
>>> --- a/drivers/iio/light/apds9960.c
>>> +++ b/drivers/iio/light/apds9960.c
>>> @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
>>>  };
>>>
>>>  /* integration time in us */
>>> -static const int apds9960_int_time[][2] >>> -       { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
>>> +static const int apds9960_int_time[][2] = {
>>> +       { 28000, 246},
>>> +       {100000, 219},
>>> +       {200000, 182},
>>> +       {700000,   0}
>> Extra space between the comma and zero. Or was this intended for alignment?
> 
> Just for alignment. Are you OK with that?
>