All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>, knaack.h@gmx.de, pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
Date: Sat, 16 Apr 2016 12:33:32 +0000	[thread overview]
Message-ID: <5712311C.7080709@kernel.org> (raw)
In-Reply-To: <1460662602-2951-6-git-send-email-sst@poczta.fm>

On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
> 
> ERROR: space prohibited before that ',' (ctx:WxW)
> ERROR: code indent should use tabs where possible
Ouch - not sure how that one snuck in!

Applied and thanks,

Jonathan
> 
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
>  drivers/iio/adc/at91_adc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index f284cd6..52430ba 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
>  	 * Startup Time = <lookup_table_value> / ADC Clock
>  	 */
>  	const int startup_lookup[] = {
> -		0  , 8  , 16 , 24 ,
> -		64 , 80 , 96 , 112,
> +		0,   8,   16,  24,
> +		64,  80,  96,  112,
>  		512, 576, 640, 704,
>  		768, 832, 896, 960
>  		};
> @@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
>  			ret = -EINVAL;
>  			goto error_ret;
>  		}
> -	        trig->name = name;
> +		trig->name = name;
>  
>  		if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
>  			dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
>  			ret = -EINVAL;
>  			goto error_ret;
>  		}
> -	        trig->value = prop;
> +		trig->value = prop;
>  		trig->is_external = of_property_read_bool(trig_node, "trigger-external");
>  		i++;
>  	}
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>, knaack.h@gmx.de, pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
Date: Sat, 16 Apr 2016 13:33:32 +0100	[thread overview]
Message-ID: <5712311C.7080709@kernel.org> (raw)
In-Reply-To: <1460662602-2951-6-git-send-email-sst@poczta.fm>

On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
> 
> ERROR: space prohibited before that ',' (ctx:WxW)
> ERROR: code indent should use tabs where possible
Ouch - not sure how that one snuck in!

Applied and thanks,

Jonathan
> 
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
>  drivers/iio/adc/at91_adc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index f284cd6..52430ba 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
>  	 * Startup Time = <lookup_table_value> / ADC Clock
>  	 */
>  	const int startup_lookup[] = {
> -		0  , 8  , 16 , 24 ,
> -		64 , 80 , 96 , 112,
> +		0,   8,   16,  24,
> +		64,  80,  96,  112,
>  		512, 576, 640, 704,
>  		768, 832, 896, 960
>  		};
> @@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
>  			ret = -EINVAL;
>  			goto error_ret;
>  		}
> -	        trig->name = name;
> +		trig->name = name;
>  
>  		if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
>  			dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
>  			ret = -EINVAL;
>  			goto error_ret;
>  		}
> -	        trig->value = prop;
> +		trig->value = prop;
>  		trig->is_external = of_property_read_bool(trig_node, "trigger-external");
>  		i++;
>  	}
> 


  reply	other threads:[~2016-04-16 12:33 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 19:36 [PATCH 00/10] iio: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-14 19:36 ` [PATCH 01/10] iio: light apds9960: fix wrong use of brace Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-14 23:29   ` Matt Ranostay
2016-04-14 23:29     ` Matt Ranostay
2016-04-15 14:56     ` Slawomir Stepien
2016-04-15 14:56       ` Slawomir Stepien
2016-04-16  9:48       ` Dan Carpenter
2016-04-16  9:48         ` Dan Carpenter
2016-04-16 12:30       ` Jonathan Cameron
2016-04-16 12:30         ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 02/10] iio: inkern: add a missing space before if Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:31   ` Jonathan Cameron
2016-04-16 12:31     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 03/10] iio: adc: vf610_adc: fix case label indent Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:31   ` Jonathan Cameron
2016-04-16 12:31     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:32   ` Jonathan Cameron
2016-04-16 12:32     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:33   ` Jonathan Cameron [this message]
2016-04-16 12:33     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 06/10] iio: adc: ad799x: remove space before comma Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:34   ` Jonathan Cameron
2016-04-16 12:34     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 07/10] iio: common: ms_sensors: use tab for indention Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:34   ` Jonathan Cameron
2016-04-16 12:34     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 08/10] iio: common: hid-sensors: " Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:35   ` Jonathan Cameron
2016-04-16 12:35     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:35   ` Jonathan Cameron
2016-04-16 12:35     ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 10/10] iio: pressure: ms5611: use tab for indention Slawomir Stepien
2016-04-14 19:36   ` Slawomir Stepien
2016-04-16 12:40   ` Jonathan Cameron
2016-04-16 12:40     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5712311C.7080709@kernel.org \
    --to=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=sst@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.