From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mike Manning <mmanning@brocade.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses
Date: Sat, 16 Apr 2016 17:31:50 +0300 [thread overview]
Message-ID: <57124CD6.4040503@cogentembedded.com> (raw)
In-Reply-To: <5711ADD1.2030904@brocade.com>
Hello.
On 4/16/2016 6:13 AM, Mike Manning wrote:
> f1705ec197e7 added the option to retain user configured addresses on an
> admin down. A comment to one of the later revisions suggested using the
> IFA_F_PERMANENT flag rather than adding a user_managed boolean to the
> ifaddr struct. A side effect of this change is that link local and
> loopback addresses are also retained which is not part of the objective
> of f1705ec197e7. Add check so that these addresses are not fixed up,
> given that a related fix 70af921db6f8 ensures that they are not kept in
scripts/checkpatch.pl now enforces commit citing certain style: <12-digit
SHA1> ("<comit summary>").
> the first place, otherwise this incorrect fixup triggers a crash in fib6.
>
> Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional")
> Signed-off-by: Mike Manning <mmanning@brocade.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-04-16 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5711AA52.6010400@brocade.com>
2016-04-16 3:13 ` [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses Mike Manning
2016-04-16 14:31 ` Sergei Shtylyov [this message]
2016-04-16 18:26 ` David Ahern
2016-04-17 18:13 ` Mike Manning
2016-04-18 14:23 ` Mike Manning
2016-04-18 14:39 ` David Ahern
2016-04-18 15:14 ` Mike Manning
2016-04-18 15:19 ` Sergei Shtylyov
2016-04-18 15:28 ` Mike Manning
[not found] <571A4D11.8070307@brocade.com>
2016-04-22 16:14 ` Mike Manning
2016-04-22 22:14 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57124CD6.4040503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=mmanning@brocade.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.