Re: [PATCH 3/4] iio: st_sensors: verify interrupt event to status

[Jonathan Cameron <jic23@kernel.org>]

On 12/04/16 13:34, Linus Walleij wrote:
> On Mon, Mar 28, 2016 at 10:09 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 24/03/16 13:18, Linus Walleij wrote:
>>> This makes all ST sensor drivers check that they actually have
>>> new data available for the requested channel(s) before claiming
>>> an IRQ, by reading the status register (which is conveniently
>>> the same for all ST sensors) and check that the channel has new
>>> data before proceeding to read it and fill the buffer.
>>>
>>> This way sensors can share an interrupt line: it can be flaged
>>> as shared and then the sensor that did not fire will return
>>> NO_IRQ, and the sensor that fired will handle the IRQ and
>>> return IRQ_HANDLED.
>>>
>> Looks good and even matches on the archaic lis3l02dq I keep meaning
>> to add to the driver :) (had that datasheet lying around)
>>
>> One day we'll figure out how to report 'overruns' sensibly at
>> which point we can use the other bits in that register as well.
>>
>> Anyhow, will let this sit just a little longer as would like Denis
>> and/or Giuseppe to have a look at it as well.
> 
> If no further comments I guess this could be applied?
> 
> Yours,
> Linus Walleij
Agreed and applied to the togreg branch of iio.git - initially pushed
out as testing for the autobuilders to play with it.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>