From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c To: Alexandre Belloni , Mark Brown References: <1460711790-22646-1-git-send-email-w.egorov@phytec.de> <1460711790-22646-4-git-send-email-w.egorov@phytec.de> <20160415102602.GE3217@sirena.org.uk> <20160415162406.GD25196@piout.net> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, dianders@chromium.org, zyw@rock-chips.com, arnd@arndb.de, k.kozlowski@samsung.com, javier@osg.samsung.com, kgene@kernel.org, olof@lixom.net, geert+renesas@glider.be, sjoerd.simons@collabora.co.uk, treding@nvidia.com, public_timo.s@silentcreek.de From: Wadim Egorov Message-ID: <57148C05.4090900@phytec.de> Date: Mon, 18 Apr 2016 09:25:57 +0200 MIME-Version: 1.0 In-Reply-To: <20160415162406.GD25196@piout.net> Content-Type: text/plain; charset=windows-1252 List-ID: On 15.04.2016 18:24, Alexandre Belloni wrote: > On 15/04/2016 at 11:26:02 +0100, Mark Brown wrote : >> On Fri, Apr 15, 2016 at 11:16:27AM +0200, Wadim Egorov wrote: >> >>> This patch just renames the rk808 driver so we can reuse this driver >>> to add more regulator devices from the RK8XX PMIC family later. >> We normally manage to cope fine without renaming things - it's quite >> common to have drivers that were initially named after one part >> supporting multiple parts, avoiding the rename makes things like >> backports easier and avoids needing git log --follow and so on. > I agree with that and I will also add that probably at some point in > time a new part may appear with a name matching rk8xx but may not be > compatible with the rk8xx driver and that is when the real mess starts. > > Finally, renaming the config options and the modules is not nice for the > user. > OK, renaming the driver and it's config options is not the best idea. But how about renaming the variables and function names within the drivers? It would be more clearer which driver parts are generic and are used by multiple PMIC devices. It seems this topic has been already discussed here [1]. So the right solution is just to rename the rk808 struct in rk808.h, don't touch the driver names and config options and naming the additional RK818 PMIC in the Kconfig? [1] https://lkml.org/lkml/2015/12/31/13 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from root.phytec.de (mail.phycard.de. [217.6.246.34]) by gmr-mx.google.com with ESMTP id i196si1394563wmf.0.2016.04.18.00.25.58 for ; Mon, 18 Apr 2016 00:25:58 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c To: Alexandre Belloni , Mark Brown References: <1460711790-22646-1-git-send-email-w.egorov@phytec.de> <1460711790-22646-4-git-send-email-w.egorov@phytec.de> <20160415102602.GE3217@sirena.org.uk> <20160415162406.GD25196@piout.net> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, dianders@chromium.org, zyw@rock-chips.com, arnd@arndb.de, k.kozlowski@samsung.com, javier@osg.samsung.com, kgene@kernel.org, olof@lixom.net, geert+renesas@glider.be, sjoerd.simons@collabora.co.uk, treding@nvidia.com, public_timo.s@silentcreek.de From: Wadim Egorov Message-ID: <57148C05.4090900@phytec.de> Date: Mon, 18 Apr 2016 09:25:57 +0200 MIME-Version: 1.0 In-Reply-To: <20160415162406.GD25196@piout.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 15.04.2016 18:24, Alexandre Belloni wrote: > On 15/04/2016 at 11:26:02 +0100, Mark Brown wrote : >> On Fri, Apr 15, 2016 at 11:16:27AM +0200, Wadim Egorov wrote: >> >>> This patch just renames the rk808 driver so we can reuse this driver >>> to add more regulator devices from the RK8XX PMIC family later. >> We normally manage to cope fine without renaming things - it's quite >> common to have drivers that were initially named after one part >> supporting multiple parts, avoiding the rename makes things like >> backports easier and avoids needing git log --follow and so on. > I agree with that and I will also add that probably at some point in > time a new part may appear with a name matching rk8xx but may not be > compatible with the rk8xx driver and that is when the real mess starts. > > Finally, renaming the config options and the modules is not nice for the > user. > OK, renaming the driver and it's config options is not the best idea. But how about renaming the variables and function names within the drivers? It would be more clearer which driver parts are generic and are used by multiple PMIC devices. It seems this topic has been already discussed here [1]. So the right solution is just to rename the rk808 struct in rk808.h, don't touch the driver names and config options and naming the additional RK818 PMIC in the Kconfig? [1] https://lkml.org/lkml/2015/12/31/13 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: w.egorov@phytec.de (Wadim Egorov) Date: Mon, 18 Apr 2016 09:25:57 +0200 Subject: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c In-Reply-To: <20160415162406.GD25196@piout.net> References: <1460711790-22646-1-git-send-email-w.egorov@phytec.de> <1460711790-22646-4-git-send-email-w.egorov@phytec.de> <20160415102602.GE3217@sirena.org.uk> <20160415162406.GD25196@piout.net> Message-ID: <57148C05.4090900@phytec.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15.04.2016 18:24, Alexandre Belloni wrote: > On 15/04/2016 at 11:26:02 +0100, Mark Brown wrote : >> On Fri, Apr 15, 2016 at 11:16:27AM +0200, Wadim Egorov wrote: >> >>> This patch just renames the rk808 driver so we can reuse this driver >>> to add more regulator devices from the RK8XX PMIC family later. >> We normally manage to cope fine without renaming things - it's quite >> common to have drivers that were initially named after one part >> supporting multiple parts, avoiding the rename makes things like >> backports easier and avoids needing git log --follow and so on. > I agree with that and I will also add that probably at some point in > time a new part may appear with a name matching rk8xx but may not be > compatible with the rk8xx driver and that is when the real mess starts. > > Finally, renaming the config options and the modules is not nice for the > user. > OK, renaming the driver and it's config options is not the best idea. But how about renaming the variables and function names within the drivers? It would be more clearer which driver parts are generic and are used by multiple PMIC devices. It seems this topic has been already discussed here [1]. So the right solution is just to rename the rk808 struct in rk808.h, don't touch the driver names and config options and naming the additional RK818 PMIC in the Kconfig? [1] https://lkml.org/lkml/2015/12/31/13