All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: imunsie@au1.ibm.com, clombard@linux.vnet.ibm.com
Subject: Re: [PATCH] cxl: static-ify variables to fix sparse warnings
Date: Mon, 18 Apr 2016 10:32:10 +0200	[thread overview]
Message-ID: <57149B8A.3080806@linux.vnet.ibm.com> (raw)
In-Reply-To: <1460955830-27267-1-git-send-email-andrew.donnellan@au1.ibm.com>


Thanks Andrew!

Reviewed-by: fbarrat@linux.vnet.ibm.com

  Fred


Le 18/04/2016 07:03, Andrew Donnellan a écrit :
> Make a couple more variables static. Found by sparse.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
>   drivers/misc/cxl/flash.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
> index 68dd0b7..c63d61e 100644
> --- a/drivers/misc/cxl/flash.c
> +++ b/drivers/misc/cxl/flash.c
> @@ -24,8 +24,8 @@ struct ai_header {
>   };
>
>   static struct semaphore sem;
> -unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> -struct sg_list *le;
> +static unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> +static struct sg_list *le;
>   static u64 continue_token;
>   static unsigned int transfer;
>
>

  reply	other threads:[~2016-04-18  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18  5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
2016-04-18  8:32 ` Frederic Barrat [this message]
2016-04-18 15:37 ` Matthew R. Ochs
2016-04-19  6:16 ` Ian Munsie
2016-06-21  0:40 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57149B8A.3080806@linux.vnet.ibm.com \
    --to=fbarrat@linux.vnet.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=clombard@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.