Re: [PATCH 2/7] drm/exynos: dsi: use generic of_device_get_match_data helper

[Inki Dae <inki.dae@samsung.com>]

Hi Marek,

2016년 04월 01일 22:17에 Marek Szyprowski 이(가) 쓴 글:
> Simplify code by replacing custom code by generic helper.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 63c84a106c0b..b6518df2411d 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -532,15 +532,6 @@ static const struct of_device_id exynos_dsi_of_match[] = {
>  	{ }
>  };
>  
> -static inline struct exynos_dsi_driver_data *exynos_dsi_get_driver_data(
> -						struct platform_device *pdev)
> -{
> -	const struct of_device_id *of_id =
> -			of_match_device(exynos_dsi_of_match, &pdev->dev);
> -
> -	return (struct exynos_dsi_driver_data *)of_id->data;
> -}
> -
>  static void exynos_dsi_wait_for_reset(struct exynos_dsi *dsi)
>  {
>  	if (wait_for_completion_timeout(&dsi->completed, msecs_to_jiffies(300)))
> @@ -1833,7 +1824,7 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>  	dsi->dsi_host.dev = dev;
>  
>  	dsi->dev = dev;
> -	dsi->driver_data = exynos_dsi_get_driver_data(pdev);
> +	dsi->driver_data = of_device_get_match_data(dev);

drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_probe':
drivers/gpu/drm/exynos/exynos_drm_dsi.c:1827:19: warning: assignment discards 'const' qualifier from pointer target type

Looks you missed const prefix and for patch 3 also but I can fix them.

Thanks,
Inki Dae

>  
>  	ret = exynos_dsi_parse_dt(dsi);
>  	if (ret)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel