Re: [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server

[Jacek Anaszewski <j.anaszewski@samsung.com>]

Hi Martin,

Thanks for the patch. I have one remark below.

On 04/17/2016 01:14 PM, Martin Dummer wrote:
> The Intel NAS SS4200 was also sold by Fujitsu Siemens (FSC) under
> the name "SCALEO Home Server". The hardware is equivalent.
>
> This patch adds the DMI data of this rebranded device.
>
> Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
> ---
>   drivers/leds/leds-ss4200.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index 046cb70..a3aa02e 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -101,6 +101,16 @@ static struct dmi_system_id nas_led_whitelist[] __initdata = {
>   			DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
>   		}
>   	},
> +	{
> +		//  FUJITSU SIEMENS SCALEO Home Server/SS4200-E, BIOS V090L   12/19/2007

checkpatch.pl complains here:

WARNING: line over 80 characters
ERROR: do not use C99 // comments

> +		.callback = ss4200_led_dmi_callback,
> +		.ident = "Fujitsu Siemens SCALEO Home Server",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SCALEO Home Server"),
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
> +		}
> +	},
>   	{}
>   };
>
>


-- 
Best regards,
Jacek Anaszewski