From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xing Zheng Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Date: Mon, 18 Apr 2016 18:03:00 +0800 Message-ID: <5714B0D4.7080506@rock-chips.com> References: <1460967452-24574-1-git-send-email-zhengxing@rock-chips.com> <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> <20160418092218.GL3217@sirena.org.uk> <5714AC57.2070901@rock-chips.com> <20160418095302.GN3217@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.134]) by alsa0.perex.cz (Postfix) with ESMTP id C80A32650B0 for ; Mon, 18 Apr 2016 12:03:07 +0200 (CEST) In-Reply-To: <20160418095302.GN3217@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, heiko@sntech.de, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org, Adam.Thomson@diasemi.com, jay.xu@rock-chips.com List-Id: alsa-devel@alsa-project.org SEkgTWFyaywKCk9uIDIwMTblubQwNOaciDE45pelIDE3OjUzLCBNYXJrIEJyb3duIHdyb3RlOgo+ IE9uIE1vbiwgQXByIDE4LCAyMDE2IGF0IDA1OjQzOjUxUE0gKzA4MDAsIFhpbmcgWmhlbmcgd3Jv dGU6Cj4KPj4gVGhlIHBhdGNoXzEvMyBhZGQgYW4gZXhwb3J0IG9mIGEgZnVuY3Rpb24gdGhhdCBj YWxscyB0aGUgX2RldGVjdF9qYWNrXwo+PiBmdW5jdGlvbgo+PiB3aGVuIGEgY29kZWMgc3VwcG9y dHMgamFjayBkZXRlY3Rpb24gYW5kIGZpbGwgdGhlIF9kZXRlY3RfamFja18gZnVuY3Rpb24gaW4K Pj4gdGhlCj4+IHN0cnVjdCBzbmRfc29jX2NvZGVjX2RyaXZlci4KPiBCdXQgd2h5IHdvdWxkIGFu eXRoaW5nIGV2ZXIgY2FsbCB0aGlzIGZ1bmN0aW9uPyAgSG93IGlzIHRoaXMgc3VwcG9zZWQgdG8K PiBiZSB1c2VkPwpJbiBteSBvcGluaW9uLCB0aGlzIGZ1bmN0aW9uIGlzIG1haW5seSB0byBwcm92 aWRlIHNpbXBsZS1jYXJkIChwYXRjaF8yLzMpLgoKVGhpcyBmdW5jdGlvbiB3aWxsIGNhbGwgYW5k IGluaXRpYWxpemUgamFjayBkZXRlY3Rpb24gaWYgYSBjb2RlYyAKc3VwcG9ydHMgaXQgYW5kIGZp bGwgdGhlIGRldGVjdF9qYWNrIGZ1bmN0aW9uIChwYXRjaF8zLzMgdXNlIGl0KSwKYW5kLCB3ZSBk b24ndCBuZWVkIHRvIGNyZWF0ZSBhIGN1c3RvbWl6ZWQgbWFjaGluZSBkcml2ZXIgdG8gY2FsbCB0 aGUgCmNvZGVjIGphY2sgZGV0ZWN0aW9uLCB0aGUgc2ltcGxlLWNhcmQgaXMgYWJsZSB0bwpwYXJz ZSB0aGVtLgoKVGhhbmtzLgoKLS0gCi0gWGluZyBaaGVuZwoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2Et ZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21h aWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbcDRKDP (ORCPT ); Mon, 18 Apr 2016 06:03:15 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:49717 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849AbcDRKDO (ORCPT ); Mon, 18 Apr 2016 06:03:14 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5714B0D4.7080506@rock-chips.com> Date: Mon, 18 Apr 2016 18:03:00 +0800 From: Xing Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: linux-rockchip@lists.infradead.org, heiko@sntech.de, Adam.Thomson@diasemi.com, sugar.zhang@rock-chips.com, jay.xu@rock-chips.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec References: <1460967452-24574-1-git-send-email-zhengxing@rock-chips.com> <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> <20160418092218.GL3217@sirena.org.uk> <5714AC57.2070901@rock-chips.com> <20160418095302.GN3217@sirena.org.uk> In-Reply-To: <20160418095302.GN3217@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Mark, On 2016年04月18日 17:53, Mark Brown wrote: > On Mon, Apr 18, 2016 at 05:43:51PM +0800, Xing Zheng wrote: > >> The patch_1/3 add an export of a function that calls the _detect_jack_ >> function >> when a codec supports jack detection and fill the _detect_jack_ function in >> the >> struct snd_soc_codec_driver. > But why would anything ever call this function? How is this supposed to > be used? In my opinion, this function is mainly to provide simple-card (patch_2/3). This function will call and initialize jack detection if a codec supports it and fill the detect_jack function (patch_3/3 use it), and, we don't need to create a customized machine driver to call the codec jack detection, the simple-card is able to parse them. Thanks. -- - Xing Zheng