Re: [PATCH v2 2/6] ASoC: Davinci: McBSP: add device tree support for McBSP

[Petr Kulhavy <petr@barix.com>]

On 18.04.2016 12:18, Peter Ujfalusi wrote:
> On 04/18/16 12:27, Petr Kulhavy wrote:
>
>> Or what do you think the pdata should carry?
> Good question. Since the driver itself does not care about pdata I would
> remove it. On the other hand if you implement the FIFO handling you will need
> pdata for legacy mode to select the FIFO threshold.
> Currently there is one pdata structure for legacy mode used by the McASP,
> McBSP and the Voice Codec. It contains mixed options applicable for all and
> some which applicable only for one of the drivers...
> I think if we want to make things clean and neat we would aim to have separate
> pdata for each of the drivers.
>
> I would probably drop the current pdata for McBSP and when I see what data I
> need for the driver later I would create one for the McBSP only.
>

Thanks, Peter. I agree with you.
I don't have the time to implement the FIFO now, so it makes sense to 
drop the pdata for now and add a dedicated one if needed later.
Shall I remove the pdata also from the EVK legacy board drivers?

I'm going to prepare another patch set.

Cheers
Petr