From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 1/3] drm/i915/guc: keep GuC objects mapped in kernel Date: Mon, 18 Apr 2016 12:28:43 +0100 Message-ID: <5714C4EB.4090509@intel.com> References: <5710D3AF.3000004@linux.intel.com> <1460974509-22616-1-git-send-email-david.s.gordon@intel.com> <20160418102509.GA18964@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B9B556E5A3 for ; Mon, 18 Apr 2016 11:28:45 +0000 (UTC) In-Reply-To: <20160418102509.GA18964@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMDQvMTYgMTE6MjUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIEFwciAxOCwg MjAxNiBhdCAxMToxNTowN0FNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gV2l0aCB0aGUg bmV3IGk5MTVfZ2VtX29ial9waW5fbWFwKCkgaW50ZXJmYWNlLCBpdCBtYWtlcyBzZW5zZSB0byBr ZWVwCj4+IEd1QyBvYmplY3RzICh3aGljaCBhcmUgYWx3YXlzIHBpbm5lZCBpbiBtZW1vcnkgYW5k IGluIHRoZSBHR1RUIGFueXdheSkKPj4gbWFwcGVkIGludG8ga2VybmVsIGFkZHJlc3Mgc3BhY2Us IHJhdGhlciB0aGFuIG1hcHBpbmcgYW5kIHVubWFwcGluZyB0aGVtCj4+IG9uIGVhY2ggYWNjZXNz Lgo+Pgo+PiBUaGlzIHByZWxpbWluYXJ5IHBhdGNoIHNldHMgdXAgdGhlIHBpbi1hbmQtbWFwIGZv ciBhbGwgR3VDLXNwZWNpZmljCj4+IG9iamVjdHMsIGFuZCB1cGRhdGVzIHRoZSB2YXJpb3VzIHNl dHVwL3NodXRkb3duIGZ1bmN0aW9ucyB0byB1c2UgdGhlc2UKPj4gbG9uZy10ZXJtIG1hcHBpbmdz IHJhdGhlciB0aGFuIGRvaW5nIHRoZWlyIG93biBrbWFwX2F0b21pYygpIGNhbGxzLgo+Pgo+PiB2 MjoKPj4gICAgICBJbnZlbnQgJiB1c2UgYWNjZXNzb3IgZnVuY3Rpb24gaTkxNV9vYmplY3RfbWFw cGVkX2FkZHJlc3MoKSByYXRoZXIKPj4gICAgICB0aGFuIGFjY2Vzc2luZyBvYmotPm1hcHBpbmcg ZGlyZWN0bHkgKFR2cnRrbyBVcnN1bGluKQo+PiAgICAgIFVzZSBJU19FUlIoKSByYXRoZXIgdGhh biBjaGVja2luZyBmb3IgTlVMTCAoVHZydGtvIFVyc3VsaW4pCj4+ICAgICAgQWRkZWQgYmlnIGNv bW1lbnQgYWJvdXQgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAmIHVzYWdlIG9mIHRoZSBHRU0KPj4g ICAgICBvYmplY3QgdGhhdCBpdCBkZXNjcmliZXMKPj4KPj4gQ2M6IDx0dnJ0a28udXJzdWxpbkBp bnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgo+ PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+ PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgICAgfCAx MiArKysrKysrKysrCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jIHwgMzggKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZ3VjLmggICAgICAgICAgIHwgMjQgKysrKysrKysrKysrKysrKysrKwo+ PiAgIDMgZmlsZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4+ Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRleCA4NTEwMmFkLi40MzlmMTQ5IDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gQEAgLTMwMjUsNiArMzAyNSwxOCBAQCBzdGF0 aWMgaW5saW5lIHZvaWQgaTkxNV9nZW1fb2JqZWN0X3VucGluX3BhZ2VzKHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmopCj4+ICAgdm9pZCAqX19tdXN0X2NoZWNrIGk5MTVfZ2VtX29iamVj dF9waW5fbWFwKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopOwo+Pgo+PiAgIC8qKgo+ PiArICogaTkxNV9vYmplY3RfbWFwcGVkX2FkZHJlc3MgLSBhZGRyZXNzIGF0IHdoaWNoIGEgR0VN IG9iamVjdCBpcyBtYXBwZWQKPj4gKyAqIEBvYmogLSB0aGUgb2JqZWN0IChwcmVzdW1hYmx5IGFs cmVhZHkgbWFwcGVkIGludG8ga2VybmVsIGFkZHJlc3Mgc3BhY2UpCj4+ICsgKgo+PiArICogUmV0 dXJucyB0aGUgYWRkcmVzcyBhdCB3aGljaCBhbiBvYmplY3QgaGFzIGJlZW4gbWFwcGVkIGJ5IGEg Y2FsbCB0bwo+PiArICogaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoKSBhYm92ZSwgb3IgTlVMTCBp ZiBub3QgY3VycmVudGx5IG1hcHBlZCBhbmQgcGlubmVkCj4+ICsgKi8KPj4gK3N0YXRpYyBpbmxp bmUgdm9pZCAqaTkxNV9vYmplY3RfbWFwcGVkX2FkZHJlc3Moc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaikKPj4gK3sKPj4gKyAgICAgICByZXR1cm4gb2JqLT5wYWdlc19waW5fY291bnQg PT0gMCA/IE5VTEwgOiBvYmotPm1hcHBpbmc7Cj4+ICt9Cj4KPiBOby4KClRoZSBrZXJuZWwgYWRk cmVzcyBhdCB3aGljaCBhbiBvYmplY3QgaXMgcGlubmVkIGlzIGp1c3QgYXMgbXVjaCBhIApwcm9w ZXJ0eSBvZiB0aGUgb2JqZWN0IGFzIGl0cyBHR1RUIGFkZHJlc3MsIHNvIHNob3VsZCBoYXZlIGEg c2ltaWxhciAKZnVuY3Rpb24gZm9yIHJldHJpZXZpbmcgaXQuCgpUaGUgcGFnZXNfcGluX2NvdW50 IGNoZWNrIGlzIHRoZXJlIGJlY2F1c2Ugb25jZSB0aGF0IGdvZXMgdG8gemVybywgdGhlIApvYmpl Y3QgZG9lc24ndCBsb2dpY2FsbHkgL2hhdmUvIGEgbWVtb3J5IGFkZHJlc3MsIGV2ZW4gaWYgJ21h cHBpbmcnIGlzIApzdGlsbCBzZXQuCgpPciB3YXMgaXQganVzdCB0aGUgbmFtZSB5b3Ugb2JqZWN0 ZWQgdG8/Cgo+PiBAQCAtNjQ5LDYgKzYzOSw5IEBAIHN0YXRpYyB2b2lkIGdlbV9yZWxlYXNlX2d1 Y19vYmooc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPj4gICAJaWYgKGk5MTVfZ2Vt X29ial9pc19waW5uZWQob2JqKSkKPj4gICAJCWk5MTVfZ2VtX29iamVjdF9nZ3R0X3VucGluKG9i aik7Cj4+Cj4+ICsJaWYgKGk5MTVfb2JqZWN0X21hcHBlZF9hZGRyZXNzKG9iaikpCj4+ICsJCWk5 MTVfZ2VtX29iamVjdF91bnBpbl9tYXAob2JqKTsKPgo+IEVoPyBJZiB5b3UgYXJlbid0IHRyYWNr aW5nIHlvdXIgcGluLCB5b3UgY2FuJ3QganVzdCByYW5kb21seSBmcmVlCj4gc29tZW9uZSBlbHNl cy4KClRoZSBHdUMgY29kZSBleGNsdXNpdmVseSBvd25zIHRoaXMgb2JqZWN0LCBzbyBpdCBjYW4n dCBiZSAic29tZW9uZSAKZWxzZSdzIi4gVGhlIHBhZ2VzX3BpbiBjb3VudCBoZXJlIHdpbGwgYWx3 YXlzIGJlIDEgKGF0IHByZXNlbnQpLiBUaGlzIAp3YXMgdG8gYWxsb3cgZm9yIHRoZSBwb3NzaWJp bGl0eSB0aGF0IHdlIGFscmVhZHkgY2hvc2UgdG8gcmVsZWFzZSB0aGUgCnBpbi1hbmQtbWFwIHdo aWxlIGxlYXZpbmcgdGhlIG9iamVjdCBpbiB0aGUgR0dUVCwgaW4gd2hpY2ggY2FzZSB0aGUgCnBh Z2VzX3Bpbl9jb3VudCB3aWxsIGJlIDAuIChXZSBkb24ndCBkbyB0aGlzLCBhdCBwcmVzZW50LCBi dXQgc2VlIGJlbG93KS4KCj4+ICAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJh c2UpOwo+PiAgIH0KPj4KPj4gQEAgLTcyOSw2ICs3MjIsOCBAQCBzdGF0aWMgc3RydWN0IGk5MTVf Z3VjX2NsaWVudCAqZ3VjX2NsaWVudF9hbGxvYyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAg IAkJZ290byBlcnI7Cj4+Cj4+ICAgCWNsaWVudC0+Y2xpZW50X29iaiA9IG9iajsKPj4gKwljbGll bnQtPmNsaWVudF9iYXNlID0gaTkxNV9vYmplY3RfbWFwcGVkX2FkZHJlc3Mob2JqKTsKPj4gKwlX QVJOX09OKCFjbGllbnQtPmNsaWVudF9iYXNlKTsKPj4gICAJY2xpZW50LT53cV9vZmZzZXQgPSBH VUNfREJfU0laRTsKPj4gICAJY2xpZW50LT53cV9zaXplID0gR1VDX1dRX1NJWkU7Cj4+Cj4+IEBA IC04NDEsNyArODM2LDYgQEAgc3RhdGljIHZvaWQgZ3VjX2NyZWF0ZV9hZHMoc3RydWN0IGludGVs X2d1YyAqZ3VjKQo+PiAgIAlzdHJ1Y3QgZ3VjX3BvbGljaWVzICpwb2xpY2llczsKPj4gICAJc3Ry dWN0IGd1Y19tbWlvX3JlZ19zdGF0ZSAqcmVnX3N0YXRlOwo+PiAgIAlzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmU7Cj4+IC0Jc3RydWN0IHBhZ2UgKnBhZ2U7Cj4+ICAgCXUzMiBzaXplOwo+ Pgo+PiAgIAkvKiBUaGUgYWRzIG9iaiBpbmNsdWRlcyB0aGUgc3RydWN0IGl0c2VsZiBhbmQgYnVm ZmVycyBwYXNzZWQgdG8gR3VDICovCj4+IEBAIC04NTcsOSArODUxLDcgQEAgc3RhdGljIHZvaWQg Z3VjX2NyZWF0ZV9hZHMoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+Pgo+PiAgIAkJZ3VjLT5hZHNf b2JqID0gb2JqOwo+PiAgIAl9Cj4+IC0KPj4gLQlwYWdlID0gaTkxNV9nZW1fb2JqZWN0X2dldF9w YWdlKG9iaiwgMCk7Cj4+IC0JYWRzID0ga21hcChwYWdlKTsKPj4gKwlhZHMgPSBpOTE1X29iamVj dF9tYXBwZWRfYWRkcmVzcyhvYmopOwo+Cj4gWW91IG5lZWQgdG8gZXhwbGljaXRseSBha25vd2xl Z2UgdGhhdCB5b3UgYXJlIHVzaW5nIHRoZSBtZW1vcnkgdHJhY2tlZAo+IGJ5IHRoZSBvYmplY3Qg b3RoZXJ3aXNlIGl0ICp3aWxsKiBiZSByZW1vdmVkIGJ5IHRoZSBzaHJpbmtlci4KPiBTbyB3aGF0 IGlzIHdyb25nIHdpdGggdXNpbmcgaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoKT8KPiAtQ2hyaXMK ClRoZSBvYmplY3QgaXMgcGlubmVkLWFuZC1tYXBwZWQganVzdCBvbmNlLCB3aGVuIGl0J3MgY3Jl YXRlZCwgYW5kIGtlcHQgCnRoYXQgd2F5IHVudGlsIGl0J3MgZGVzdHJveWVkLiBDYWxsaW5nIHBp bi1hbmQtbWFwIGhlcmUgd291bGQgZ2l2ZSBpdCBhIApwaW4gY291bnQgb2YgdHdvLCB3aGljaCB3 b3VsZCBiZSByZWR1bmRhbnQsIGFuZCByZXF1aXJlIHVzIHRvIAp1bnBpbi1hbmQtbWFwIGl0IGFn YWluIGF0IHRoZSBlbmQgb2YgdGhlIGZ1bmN0aW9uIC0gd2hpY2gganVzdCBzZWVtcyBhIAp3YXN0 ZSBvZiB0aW1lLgoKSSBhbHNvIGNvbnNpZGVyZWQgZHJvcHBpbmcgdGhlIG9yaWdpbmFsIHBpbi1h bmQtbWFwIG9uIHRoZSBBRFMgb2JqZWN0IApvbmNlIHRoaXMgZnVuY3Rpb24gaGFzIGZpbmlzaGVk IHdpdGggaXQsIGJ1dCBkZWNpZGVkIGl0IHdhc24ndCB3b3J0aCB0aGUgCmV4dHJhIHdvcmsuIEl0 IGhhcyB0byBzdGF5IGluIG1lbW9yeSAoYW5kIGluIHRoZSBHR1RUKSBhbnl3YXksIHNvIGl0IAp3 b3VsZCBvbmx5IHNhdmUgYSBmZXcgcGFnZXMgb2Ygdm1hcCBzcGFjZS4gSWYgd2UgZGlkIHRoYXQs IHRoZSBjaGVjayBvbiAKd2hldGhlciB0aGUgb2JqZWN0IHdhcyBzdGlsbCBtYXBwZWQgKGluIGdl bV9yZWxlYXNlX2d1Y19vYmooKSBhYm92ZSkgCndvdWxkIGFic29sdXRlbHkgYmUgbmVjZXNzYXJ5 LgoKLkRhdmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK