From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbcDROOW (ORCPT ); Mon, 18 Apr 2016 10:14:22 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:56984 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbcDROOV (ORCPT ); Mon, 18 Apr 2016 10:14:21 -0400 Subject: Re: [PATCH] regulator: core: remove lockdep assert from suspend_prepare To: Mark Brown References: <1460980193-10085-1-git-send-email-t-kristo@ti.com> <20160418115905.GY3217@sirena.org.uk> CC: , From: Tero Kristo Message-ID: <5714EBB5.5050800@ti.com> Date: Mon, 18 Apr 2016 17:14:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160418115905.GY3217@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/04/16 14:59, Mark Brown wrote: > On Mon, Apr 18, 2016 at 02:49:53PM +0300, Tero Kristo wrote: > >> suspend_prepare can be called during regulator init time also, where > > It can be? That seems unexpected... > regulator_register() -> set_machine_constraints() -> suspend_prepare() Called if you have setup initial_state for the regulator. -Tero