From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbcDROS0 (ORCPT ); Mon, 18 Apr 2016 10:18:26 -0400 Received: from mail-bn1bon0099.outbound.protection.outlook.com ([157.56.111.99]:53773 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750727AbcDROSY (ORCPT ); Mon, 18 Apr 2016 10:18:24 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; alien8.de; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;alien8.de; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Reply-To: Subject: Re: [PATCH 2/2] EDAC, altera: avoid unused function warnings References: <1460837650-1237650-1-git-send-email-arnd@arndb.de> <1460837650-1237650-2-git-send-email-arnd@arndb.de> To: Arnd Bergmann , Doug Thompson , Borislav Petkov , Mauro Carvalho Chehab CC: Alan Tull , Dinh Nguyen , , From: Thor Thayer Message-ID: <5714EDD4.1050306@opensource.altera.com> Date: Mon, 18 Apr 2016 09:23:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460837650-1237650-2-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR0401CA0009.namprd04.prod.outlook.com (10.162.114.147) To BN3PR03MB1479.namprd03.prod.outlook.com (10.163.35.142) X-MS-Office365-Filtering-Correlation-Id: 92333b8b-2cc9-44a2-90ac-08d367944ad0 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1479;2:koo/uKOeiDcnvxdAyJgC35KsUp7jZfPB8rbrJ0nihBR5/j/jXmsLv0iAsSFF0fKbqUqRX/dvxY6kACA581tF5Lq7B1sFskPUGIbLFaDLYo9/TglbuMIpb1GCBuGDsNEexQuCQRaiVqIjwkNDVTi/gBqBlUst+Ew7DHLGzVzUUMFC2B0Pksjqf+nb2r7XPO/9;3:SBfKhySjm8lw72DsZOmCpJlYmJutBKx4vHkzbPBndTU0TiaT++0m1jq1/uHvjPng+DINQrAbcaXMKxNkEOYkd3TjekoVkY7TSFiBnSELLGxocyqm/V7aIRI+iRlszWeB X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1479; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1479;25:lzbimeMge9d/s+OPvNFaBDGUxEZtl8JI091oP5DuwaIF2IR+oYZ6wxqXEmTsMJeyDi7kDYpZhR+In9We2TnQwIkY9z27k1gQ/fDwNPPBYjew/YPvkl+ctXe44KwkWm4/q0e9LYNEiL/uAPDUFPO5ZE/qNHRh1riSLK06rcaUnp+WksoCvq7roF5nZ+BGeK5o1JLOtD2zxjVA7XcHl6h9QHX/2Q/wRhjfZfaWD60wfRnum5Hyr0GcSxOfdQ6RzEW3CkHHBPaIG1xCudR74ynKMGoZr/VGGaSfYCp2LpqnoxlCugX4H2tyQAHq9t1V+OodqlHpnSVBUE4neBzpLxpraTh5pQ/b52YFdPgZK3Bk2RF6QROxuv9AkwHc7yFTFMI6z4JVbFs1KcHO1iHJoxWd4XF5krkrCJ8XSs0IYj2X0n05DmE7jmM3+p6U0iM6SnF8TVzDsQfxiZ4vhkqMfRhNX/K/SY31RxpdqWGkMLkcmIib7KabdvatmdZiqir+WHQ3J85MFDAHaQxBxEfPsj34H0gGHK8r0YvT7sd+NCm/ExSoDHqJl9/YL85T0V+vumDdAh951SEOqRJf3otQqtZfhMu5p4YkyuxgJ6O0KCYpQ/BXp6QG9mNrDhRWDxQerXEe4TT7tm1+rRJu/cVSzUDT4BKg72Ibk4gMaT6KhSNKW24=;20:zzg+ByxWAWPfj8ei0/1ffoRzL1sfeVNtKdxwvihf5YNOj6hkalmx/EvquNtPXXLfVlMM7bKfkfzKBfOFbnMvgKFIp7hrWUJC1Wl7EjbW+LZoc37z4WdYuviyfkD32vJLLwZTtgGN62wMh1X2YEaUBmM+O2qY85wlU7GaVc7+8tk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN3PR03MB1479;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1479;BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(8121501046)(13015025)(13017025)(13018025)(13024025)(13023025)(5005006)(3002001)(10201501046);SRVR:BN3PR0301MB1284;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1284; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1479;4:SiZlSxXbVTOE/O6J88GYBlOANpkObVDq9Xcc6dJe/qiKVLFPrVCcEIFv8/MwxRcLnPP2NkKUSZpy/IammdKbBW+1z0SMaLfs72bnrIotrsBHUF3vetBogUQi5ylkRubsJ3QtXtAINpdm56dDT+Af8I6rRR9SS73iN8JQiBNaXqhK/3q5IoX7kb9JAeI3oQSfuIiR+K2x8rnWo3BSWKuhzaAp09xYwjksv6JUjglJn6UXPWpFa4P9uPX3u/0gRIbR8MSd2AAE5iD9ho+qYsm56fZpqxJiN1AdiO21el282Xe/UR0oo0+cytbFe0R4Y18Eh/uboeTB3GwnqTPtTS/LJ1uwQQlEXLnO6+tQ80n4ek6FE3VGWzqCBAM25tueX7nEzW5ARAFkqd4NmsZzzSNCuQ== X-Forefront-PRVS: 0916FC3A18 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(377454003)(42186005)(77096005)(86362001)(4001350100001)(54356999)(3450700001)(59896002)(76176999)(2950100001)(5001770100001)(87266999)(65816999)(53806999)(189998001)(50986999)(33656002)(586003)(6116002)(47776003)(5008740100001)(1096002)(3846002)(65806001)(2906002)(65956001)(19580405001)(23746002)(81166005)(80316001)(64126003)(66066001)(19580395003)(83506001)(50466002)(43066003)(230700001)(4326007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1479;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BN3PR03MB1479;23:6DMz9kvbQnYdLme4w+pdFK4AEXHQxV7dJrmKh?= =?Windows-1252?Q?CPxRUWbZlmyS1G13yzGV/dpG6yIvxuksA0D8ybm7kqtVrQUCm/szz4qj?= =?Windows-1252?Q?HWm6EU74TqvXvwGgMhjDdODm8Eq45O4ka8PjHxcTmLd6RfwIbVqYiZYZ?= =?Windows-1252?Q?dqkt5XaXleyh3F6m+ozIa6NR9AbyArlm5lL4S0NN1jxKaESfNrM9AYxX?= =?Windows-1252?Q?sr9/OhhE5aMeqoe8P2E86idbSWnpnPPL4w+xxQTFI6hvpFJEvfTQfIxL?= =?Windows-1252?Q?eWr4thttbjki1DDHQnZU+1bsYxlTEbQN/jApWGux07kECjWvpMD1Hsoi?= =?Windows-1252?Q?idGz580HsPEnbru6gqMGGTUzUM9X+D0VeluzjeGVxkqswJ5eXdwZYf6s?= =?Windows-1252?Q?1nflMct2IHNXOxldlGHcZ0MYrXvFJKx0+HmjbfkO1YCg+yftlN/cbMyy?= =?Windows-1252?Q?K8Uts01O4XdL0uaB3VVvgrMFdHuEWhg+khqoitvS/2TMIi228+8Tw3Zy?= =?Windows-1252?Q?65iD1z4qXWICR6C8sU37YgPlyNoLm6msRrs5P7FmDu2VZv4btDv3cwR5?= =?Windows-1252?Q?f4ZX3qovfwEPZAyXDczaUVPyJvE03n1lz9jp3730nWwGakpUfjZr3VGZ?= =?Windows-1252?Q?RZS8Jz1y1RJcCJzOR0yUrZ/h2bY4ABWsEc3YlPYaP+Ojb335/GMo6lqv?= =?Windows-1252?Q?Qi68BgzqV6G0xXFYgwijAfxrygbP11zwywCmZgNdgnrgsxGq7NCZbwIa?= =?Windows-1252?Q?N9ErfJVpMhMzyEDMQwmNw57cbB89Gfj8s67mIwY0oTrWR/qLsjdS6JeL?= =?Windows-1252?Q?BjFDq3q3WkDHK5/wXmHLoj0f+9boqVWPV4k/Ztjx/AUrMvdQO7FatmiG?= =?Windows-1252?Q?seyl59OfCNjsFTiZjTAoqvBUZY0fjrtMo1cZgzo3Z7Ns78ms5+m2wpF+?= =?Windows-1252?Q?cXL57iBdqg33uQk9kCX0/scQSNc681CrzsCf2H4UNUuoLo0aeHDxLKM4?= =?Windows-1252?Q?zkYeIfiSmAQRzR/4HEgUKDegUQg2YgMlNOAPsWNyJNrY/pjnWE+otjbm?= =?Windows-1252?Q?NVoekPw0BXyq8ia8/L8yrOyBOFquj8EUZo/snIq5tbrM9jJXgC0Vl+63?= =?Windows-1252?Q?BFDWS5pAFDcO23jISbpaPbSpigeEz0K2/ZI30vpEcQo1cq7ptS9mb6nf?= =?Windows-1252?Q?PGVfDflpZqucd9X2HAdVY5HJj9JHfo=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1479;5:hqQDfHeEDxa2ZWc8sE4of9Tn0AEA3ngJpX6NeUNcgYUL9XIOjn913qDYNb3Kjtj1egOKfVjyc+wg7/OYWB1FTyGnFtJipRRiF00mifHYHRnudcbdW3foNpOO2lYG8UaXfBHMparW2fUC9MP0zgFX2MMvrXQrrTORodwvH8D7ISnWxz+1ovULQ3MPQ8oDZond;24:6g2zqlWA58MViM5t1e1boVrYBZc9DHwNaVnrEnip1bqM5IHjwf6d3qPTXVTpY/tUzbunQqyOrQtbp+znF5EsnHfhDRKqruMt/4cmG8jGw/4=;7:w3FNYG1u+R1jtU4ZlDhyCae3I6VxjOW0tX5vvEfiu5iIunAydGZGxdxoQleOAJOd1agdtvFvROMsJrqQYMwyHFbTpZRSmRYhMl+BjGMMGjIwcJDW8NYGthDRTwMraGIFSl//0WYUeKx4RftNWMfjLBYAdYkHAxC7Gt002wEWVtyJxhkk98zqhtFPyTcgMhVE046vKofvAKnsWo9VKObtVZmsFpWtxA7Lwms/O6O6tcQ=;20:NC/Iwk/xBsATB1YCmeJQboWK5zP2JSp05sEnekIBbmsgrmPgyG17MIyChxzyIKzJFuEzfgSuOka2oIwZtQc9OAzpTOfi31wwBL3F5fmtGw4s4ipHnhLuqJg0mU8wVdP6Kpob+5cJcQOCklh+CRe7Y6Iy1DEszvp9tGle2SXALQg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1479 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD054.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(377454003)(24454002)(189998001)(47776003)(65806001)(11100500001)(65956001)(43066003)(4326007)(50466002)(81166005)(956001)(4001350100001)(5001770100001)(3450700001)(3720700001)(1096002)(586003)(33656002)(66066001)(3846002)(1220700001)(6116002)(53806999)(87936001)(65816999)(2950100001)(77096005)(86362001)(83506001)(5008740100001)(106466001)(2906002)(85426001)(59896002)(105606002)(16796002)(230700001)(80316001)(87266999)(54356999)(76176999)(50986999)(19580405001)(19580395003)(23746002)(6806005)(21840400001)(64126003)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0301MB1284;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD054;1:Ummdny+sqqrHuttkKW+vojoQDfhew+3x76XywO0ocLQd9QzP1y0fhh4x7LBA8HwFbBm/SenDKJz8kWUDJpcwA1sTdpaZLJ/lq6GScnhzn60JC89FUOCrtg6HH9qyd0yLVLLUkC3q/52DzLW6gUy0YTSEZ++xbiWe7QeIyE1g+bfuuJvdb7cQNWN2hpDFUUSFBZJICj6AQZWZehkwsm0tlN9WlBCi/2YRisoV2MwNQXlFu5bEFsmwFizla+7ZVhYqopI6FaQDU6xO3ib4MugwN5Y5BBKqsRiywO7lden5/dRr/TnAdnoG21KIkFinRtmaMK7FhgWDwEugQQYb4r9v4A+9ujOSmBw4DQ+9fectHUh9RDVrm5oCkpazwSKoeG668guwkSe2SFrUssV4YBjfdk8B04o3M/LSv7wngfhxjR9LkeHdBNpbR3UWYGWL290daEARCVro5iECo4v3zmiYx9p8O2at5aooDbRut6SH1KDKkIdx4Guf7c6kXfZGan45GEjmdmCNqnMHQtKLaw3R1WO+s/l2n+I7cCkqQ/NPMSg= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1284;2:QP9WAflJAcD5NvHW2xSvGo0Yw8EKnObg4zK/5iY/77pVgEMwaDge3BcDgd70gsnAQwlSy0Ty+/dtpgUYOU8/YI7NVk2MSWzKvfW0C2sHmMfFhnvq8dwUDn8bkA86DZXnTZn3yuMJuOAq+rFiziC8cY7p/x1Uj/AsRLptMPUde4i65Wu/hA/g8xRi0Bqe+uc6;3:T+OL9TGVKynbj/H6WVdgSVoAAfLR2DDtNb+FJVdKzfdz0KY+IzNDiiVsq62QbWsOaEbqkSd9Lye4u5R5ICPmi4rs+TkecFlhEEPnNW4RgkpARoixVjiVlvNNf6EWJTmQ3nNF3NV5QQbYhao/87798iYJ7UYIUV13GEe8bvEoMuNIDb4g7UUtR/nDUn5w5iV1VCo93eoWhV3DXe7hyLCCfaPuFr3smL1+IGRhgdcd12GiIGc7P8Ugn2UcdhZicKNP;25:zvCx8l1NLY9J6/PwOOmUivfMW9gZ32E0sDBnD4lfbvIc+XDPqnx4cCt8tRO4R6FSN3KADVmz2UEkdTnk+Adyri75tIO25NIVE5tnTRz9ZxM78gpnrJ3wEVKLA/AwFHc3Sn3MZK3vTqSqQasH2bSCOVODEyXojnYSKqINHJVENQEJ7nKYP6rzNsPj2lEz7U3F5lUXjqqdzOlNDPMCZiOtYqbOOSCkGV5OYlVhMBUbz3txd3Wye3Ao1G87Ww3FzdII/V3BD87yvdNjmm0GJHbB7XPpbtcnLG1hi5JrnmwTCWy5q1AhwK1TaGcJquwkkXKgy0D7ks8OmHkdRMusZ0Q45w== X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BN3PR0301MB1284; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1284;20:Wk8t48V0XyrVfefObjvTnnh/WH9Ss+tKVSSwMUDHB3RXREWs8/1ZSf4NPttMF6QOihPAlQfdtdkJDiUokfJLEHwFDtMr7LzX2omK6yV4XiYbcMyAIRzkzAlEtWrdSCKYKy+2graY31jRKWS/jkikv2+gi4FwzbGmpSTizwoyr/g=;4:EDeEIi+ZRuVWLp1XqcIkRzdWvC4GFxO1cDefusPN2yZ10bl9p4xgkCTpkxOQn/vXxCyKLftn7PwBEt1C6nLqhPKCiNHqSTqCcYeY5ho2zWb1AA3Z//52YPqaC9xPlJZijEQ9XCc2r162wlNQ4MH3ZznJ5X1e8hhwyx1v4YCyHGdolDXzQ3J1y/uFJ25BIqHHoBJVrgx+CrqAYPm6vzuXjJ9mDOeNqchMYnmsga4ynG9Bl245kiB5T83GcT7ejN9HrZRMK6hG35MVrWQPQT7M3xAXADM3e9hGZzv2bBBN/v5HgzhdqY7jcR+gjRGt4XtW58TroypZ9BCx/JGdLAqJybzBD0aBn+gF+9DrYLirrENi+R1vgHZoH7i1Y3WLNFmv5c+/b+WawH3mWFOD0XNvhmB0nAINnidwv7KF/tpdVdemkgveaBkBvEcqUiH3NO49hiRQaap+La5cUUqORhdn0o7TLBuxnyaxgFccll9/Iyg= X-Forefront-PRVS: 0916FC3A18 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR0301MB1284;23:UZ4lUHjdl+pWe4Zeu7Klkzi9q7Hw7ZOS7+W?= =?Windows-1252?Q?+wtkvRfingEbYWbz+30JkhN/DUrSWsjGKtBfkO6gGaR/F1eI+Xr7ODbJ?= =?Windows-1252?Q?XOfTpm10p8jvWsDX+ILQricNc9Rbsg6xvnDez3uVpojI/NZIPDp0WlWA?= =?Windows-1252?Q?sCUL66fUqVSdxanra13jhwdAxzLFM/t+tuHM6xuMBDcMZGQX/Rybrz8E?= =?Windows-1252?Q?+exwxfwukHkL3P4SyNXZfl+QBlxwQLGLk0BmLP4IJpgOG5ki9GyIK+b2?= =?Windows-1252?Q?+qsWWxgaDxTCS6gmPVcUv8Ocu74ozrJd4MAlF8WrgWallNt8s/SV9k+1?= =?Windows-1252?Q?qgafi38uBzpvXLuDLQof6u8DHULiXvplkWdgmu4G7ZlNMwJao++CGExd?= =?Windows-1252?Q?AZroiuxtjzX/vefXdIv3xFjn8Y9Xmh2QAB0YG4BhwDyisxh1Z8pJpyjn?= =?Windows-1252?Q?kysh2CAcUljQgazKn3GnNoJMsq+D8/Lq6PWWQf7qcOTEMC2KKT3LZ+G9?= =?Windows-1252?Q?ndm1o3Ca9n013l7zet3mu2AGW0y53gb/Q6VFG7mrRlS5JRT9tzLjdXn6?= =?Windows-1252?Q?E5vxMSOMuI02QXmRymDMM+IjFbAs+5kO3hxnc7IiO4Nk6PTtNvoaKxYU?= =?Windows-1252?Q?riZG67SNHU0htva8lwZkwflBxxfA9RLAEZwgGbmyU7+4mk/Irgp0g3jj?= =?Windows-1252?Q?GvQitIE+sk+vOjBHXJFlMl4uZUO/qEWdoAqVDrU7+NrTbswyIKOHHPvo?= =?Windows-1252?Q?1xVjYtCTzxbLdNcI5horoWGZ4zVIicwPJeinPcO7ba9hZP5s2c9SXnGe?= =?Windows-1252?Q?lB3FoTMiHfUrjSp41onLi5ntDwFPf695zYWMchwurd14pLhlx7BBLIrK?= =?Windows-1252?Q?vF+wQp9dkmA8KI3u+EP2UYJN6rLR+p3y2hT0YO+88jmgZQPFMVOYuBep?= =?Windows-1252?Q?nJkiZMg4nJ8sMXe5/0CWx3ZiELZvhHCScaZdhII1THSWZ+GISGZHU0sH?= =?Windows-1252?Q?0wdM0FQ/fATZ7eD6LkQ379c2Lr2tfd+rmuQYpYGqNKTt+5QU+VwVN3i9?= =?Windows-1252?Q?GDoUUOE+/+6AIQ6MuLakSKz4elaxWcXN4KWCKr8GG9+LycJq+M8xCHBL?= =?Windows-1252?Q?TEFn/gYP+erHXJNZQGaLVUGneHJxPcjntPwWthyuodYuqnUfQrDlqlSA?= =?Windows-1252?Q?QaO2aYQeS7PHmOhC3j/syII4RHrAKkiMSfoIcPMKu/tW3Cx3n39pIlfJ?= =?Windows-1252?Q?z9ZErjaltrEnOfXk7TDNf3IjliP+WDCRjJGrxbaklqMGyD1KKjEbriOY?= =?Windows-1252?Q?nK0g+NJlDLQXxm32XYwEyp1nf9ci7bcHTCyvWTi2bTiNGvCmOHIO9OUf?= =?Windows-1252?Q?PLD9TXKGmHxRv2btFXLnWnjmZ5bG/uXhzbkJRydQzW9mzkE3Ez822Wgd?= =?Windows-1252?Q?iCyFEgu1TsaVWMqITK/d/69fo7ABw2fRcBtoBIdeL0rsjmY/or7QpjG4?= =?Windows-1252?Q?0rfyrB3zmtbUMg1goPM9x+Fobn2tva/hODrTrXg+2hQLfYG9Drg=3D?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1284;5:pxhhTBZIk5y2SwTUy/mXPpIeMGJUCZ1OMw+qvW5B6xtrwGJJuEJEPvqAaXBfiF21EbUPja6mubLDyL1dl7N3GUaMSzpIPiJHdxjZ9UvdAx4QOxFf9pMDLbw8NmFFQZsXq9M9dpG6hfOCVxcaSSDinJN8mhmd9GEDOuhucuuv81LtOPXILeBNOS8eNRva2gEw;24:sEjS+Yjw14X2ub4+QWkILPV5Z5n08vX24+FVwDtO/4/01SIKNfqZqRBLIraytyjmUecYcAL/5HFT8ODsjRsuFlXkDqZ/MAV4r13dX9rhkss=;7:kJC3MOOARmXFDQ+C+zcTBmEIAGiQccEe1N0JFF3aUM6c3lJM8aInxjYe3jKfnA1IDPWN/6WxMrsF6QC6gkjwy48ZjeDHvNC8r3ur8Ffur8ySXlQhdtg4dqQOJ6WIi/OVk1NWeqdRWXhUomi/TKIoQk3PWARRIZU3+ZafHoUj0WdGeD3wnm98ObEkC/9ilL/OtdeoaD4RpJbQ+SDD5oArbg==;20:NhBBZt/tN8VBBAfrAzeCcFIJIt3z2X1PGqw4/Z8PSXnT3cXQ9USmAwXeVMMAS4A2VtC1iaUdcem5Ut18Ms7VXBBP1e1H9LsJHCXIVV/VECvPlLb350vWcsxmzzPj2+uSOVkexDCUmyQMlMhJ2Mo7HFmh/HpyVTLrhqMY+W7EYGM= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2016 14:18:19.5347 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1284 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2016 03:13 PM, Arnd Bergmann wrote: > The recently added Arria10 OCRAM ECC support caused some new > harmless warnings about unused functions when it is disabled: > > drivers/edac/altera_edac.c:1067:20: error: 'altr_edac_a10_ecc_irq' defined but not used [-Werror=unused-function] > drivers/edac/altera_edac.c:658:12: error: 'altr_check_ecc_deps' defined but not used [-Werror=unused-function] > > This rearranges the code slightly to have those two functions inside > of the same #ifdef that hides their callers. It also manages to > avoid a forward declaration of the IRQ handler in the process. > > Signed-off-by: Arnd Bergmann > Fixes: c7b4be8db8bc ("EDAC, altera: Add Arria10 OCRAM ECC support") > --- > drivers/edac/altera_edac.c | 78 ++++++++++++++++++++++------------------------ > 1 file changed, 37 insertions(+), 41 deletions(-) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index cc987b4ce908..5b4d223d6d68 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -649,26 +649,6 @@ static ssize_t altr_edac_device_trig(struct file *file, > return count; > } > > -/* > - * Test for memory's ECC dependencies upon entry because platform specific > - * startup should have initialized the memory and enabled the ECC. > - * Can't turn on ECC here because accessing un-initialized memory will > - * cause CE/UE errors possibly causing an ABORT. > - */ > -static int altr_check_ecc_deps(struct altr_edac_device_dev *device) > -{ > - void __iomem *base = device->base; > - const struct edac_device_prv_data *prv = device->data; > - > - if (readl(base + prv->ecc_en_ofst) & prv->ecc_enable_mask) > - return 0; > - > - edac_printk(KERN_ERR, EDAC_DEVICE, > - "%s: No ECC present or ECC disabled.\n", > - device->edac_dev_name); > - return -ENODEV; > -} > - > static const struct file_operations altr_edac_device_inject_fops = { > .open = simple_open, > .write = altr_edac_device_trig, > @@ -848,6 +828,25 @@ module_platform_driver(altr_edac_device_driver); > /*********************** OCRAM EDAC Device Functions *********************/ > > #ifdef CONFIG_EDAC_ALTERA_OCRAM > +/* > + * Test for memory's ECC dependencies upon entry because platform specific > + * startup should have initialized the memory and enabled the ECC. > + * Can't turn on ECC here because accessing un-initialized memory will > + * cause CE/UE errors possibly causing an ABORT. > + */ > +static int altr_check_ecc_deps(struct altr_edac_device_dev *device) > +{ > + void __iomem *base = device->base; > + const struct edac_device_prv_data *prv = device->data; > + > + if (readl(base + prv->ecc_en_ofst) & prv->ecc_enable_mask) > + return 0; > + > + edac_printk(KERN_ERR, EDAC_DEVICE, > + "%s: No ECC present or ECC disabled.\n", > + device->edac_dev_name); > + return -ENODEV; > +} > > static void *ocram_alloc_mem(size_t size, void **other) > { > @@ -883,6 +882,24 @@ static void ocram_free_mem(void *p, size_t size, void *other) > gen_pool_free((struct gen_pool *)other, (u32)p, size); > } > > +static irqreturn_t altr_edac_a10_ecc_irq(struct altr_edac_device_dev *dci, > + bool sberr) > +{ > + void __iomem *base = dci->base; > + > + if (sberr) { > + writel(ALTR_A10_ECC_SERRPENA, > + base + ALTR_A10_ECC_INTSTAT_OFST); > + edac_device_handle_ce(dci->edac_dev, 0, 0, dci->edac_dev_name); > + } else { > + writel(ALTR_A10_ECC_DERRPENA, > + base + ALTR_A10_ECC_INTSTAT_OFST); > + edac_device_handle_ue(dci->edac_dev, 0, 0, dci->edac_dev_name); > + panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n"); > + } > + return IRQ_HANDLED; > +} > + > const struct edac_device_prv_data ocramecc_data = { > .setup = altr_check_ecc_deps, > .ce_clear_mask = (ALTR_OCR_ECC_EN | ALTR_OCR_ECC_SERR), > @@ -899,9 +916,6 @@ const struct edac_device_prv_data ocramecc_data = { > .inject_fops = &altr_edac_device_inject_fops, > }; > > -static irqreturn_t altr_edac_a10_ecc_irq(struct altr_edac_device_dev *dci, > - bool sberr); > - > const struct edac_device_prv_data a10_ocramecc_data = { > .setup = altr_check_ecc_deps, > .ce_clear_mask = ALTR_A10_ECC_SERRPENA, > @@ -1061,24 +1075,6 @@ static ssize_t altr_edac_a10_device_trig(struct file *file, > return count; > } > > -static irqreturn_t altr_edac_a10_ecc_irq(struct altr_edac_device_dev *dci, > - bool sberr) > -{ > - void __iomem *base = dci->base; > - > - if (sberr) { > - writel(ALTR_A10_ECC_SERRPENA, > - base + ALTR_A10_ECC_INTSTAT_OFST); > - edac_device_handle_ce(dci->edac_dev, 0, 0, dci->edac_dev_name); > - } else { > - writel(ALTR_A10_ECC_DERRPENA, > - base + ALTR_A10_ECC_INTSTAT_OFST); > - edac_device_handle_ue(dci->edac_dev, 0, 0, dci->edac_dev_name); > - panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n"); > - } > - return IRQ_HANDLED; > -} > - > static irqreturn_t altr_edac_a10_irq_handler(int irq, void *dev_id) > { > irqreturn_t rc = IRQ_NONE; > Acked-by: Thor Thayer