diff for duplicates of <5714F569.807@opensource.altera.com> diff --git a/a/1.txt b/N1/1.txt index 700dca8..93212f9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,123 +1,158 @@ + Hi Lee, On 04/18/2016 02:43 AM, Lee Jones wrote: -> On Fri, 15 Apr 2016, Thor Thayer wrote: ->> On 03/30/2016 06:35 AM, Lee Jones wrote: ->>> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote: ->>> ->>>> From: Thor Thayer <tthayer@opensource.altera.com> ->>>> ->>>> The Altera Arria10 Devkit System Resource chip is a Multi-Function ->>>> Device, it has two subdevices: ->>>> - GPIO ->>>> - HWMON ->>>> ->>>> This patch adds documentation for the Altera A10-SR DT bindings. ->>>> ->>>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> ->>>> --- ->>>> .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++ ->>>> 1 file changed, 35 insertions(+) ->>>> create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>> ->>>> diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>> new file mode 100644 ->>>> index 0000000..564c761 ->>>> --- /dev/null ->>>> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>> @@ -0,0 +1,35 @@ ->>>> +* Altera Arria10 Development Kit System Resource Chip ->>>> + ->>>> +Required parent device properties: ->>>> +- compatible : "altr,altr_a10sr" ->>>> +- spi-max-frequency : Maximum SPI frequency. ->>>> +- reg : the SPI Chip Select address for the Arria10 System Resource chip ->>> ->>> DT bindings are much easier to read in the following format: ->>> ->>> - compatible : "altr,altr_a10sr" ->>> - spi-max-frequency : Maximum SPI frequency. ->>> - reg : the SPI Chip Select address for the Arria10 System Resource chip ->>> ->>> ... also, sentences start with an uppercase char. ->>> ->>>> +The A10SR consists of this varied group of sub-devices: ->>>> + ->>>> +Device Description ->>>> +------ ---------- ->>>> +altr_a10sr_gpio GPIO Controller ->>>> +altr_a10sr_hwmon Hardware Monitor ->>>> + ->>>> +The LEDs are implemented entirely in the device tree using ->>>> +the gpio-led framework. ->>> ->>> This is a Linuxisum and should not live in DT bindings. ->>> ->>>> +Example: ->>>> + ->>>> + a10-sr: a10-sr@0 { ->>> ->>> Nodes should be named after their device 'type'. ->>> ->>> Does this device really start a address 0? ->>> ->> ->> I see in the documentation on device trees there are a number of ->> categories I can use. GPIO is easy because it is one of the ->> categories but I'm not sure about the new device I'm adding since ->> the a10sr is a new device. -> -> It's always difficult with MFDs as they are by their very nature, more -> than one device. But how about 'resource-manager'? -> + +On Fri, 15 Apr 2016, Thor Thayer wrote: + +On 03/30/2016 06:35 AM, Lee Jones wrote: + +On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: + + +From: Thor Thayer <ttha...@opensource.altera.com> +To: linux-hwmon@vger.kernel.org + +The Altera Arria10 Devkit System Resource chip is a Multi-Function +Device, it has two subdevices: + - GPIO + - HWMON + +This patch adds documentation for the Altera A10-SR DT bindings. + +Signed-off-by: Thor Thayer <ttha...@opensource.altera.com> +--- + .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++ + 1 file changed, 35 insertions(+) + create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt + +diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +new file mode 100644 +index 0000000..564c761 +--- /dev/null ++++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +@@ -0,0 +1,35 @@ ++* Altera Arria10 Development Kit System Resource Chip ++ ++Required parent device properties: ++- compatible : "altr,altr_a10sr" ++- spi-max-frequency : Maximum SPI frequency. ++- reg : the SPI Chip Select address for the Arria10 System Resource chip + + +DT bindings are much easier to read in the following format: + +- compatible : "altr,altr_a10sr" +- spi-max-frequency : Maximum SPI frequency. +- reg : the SPI Chip Select address for the Arria10 System +Resource chip + +... also, sentences start with an uppercase char. + + ++The A10SR consists of this varied group of sub-devices: ++ ++Device Description ++------ ---------- ++altr_a10sr_gpio GPIO Controller ++altr_a10sr_hwmon Hardware Monitor ++ ++The LEDs are implemented entirely in the device tree using ++the gpio-led framework. + + +This is a Linuxisum and should not live in DT bindings. + + ++Example: ++ ++ a10-sr: a10-sr@0 { + + +Nodes should be named after their device 'type'. + +Does this device really start a address 0? + + + +I see in the documentation on device trees there are a number of +categories I can use. GPIO is easy because it is one of the +categories but I'm not sure about the new device I'm adding since +the a10sr is a new device. + + +It's always difficult with MFDs as they are by their very nature, more +than one device. But how about 'resource-manager'? + + OK. Yes, that would be a good name. Thanks. ->> I believe I should only call out the name and address on the SPI bus like: ->> ->> a10sr@0 { -> -> Correct. -> ->>>> + compatible = "altr,altr-a10sr"; ->>>> + reg = <0>; ->>>> + spi-max-frequency = <100000>; ->>>> + ->>>> + a10sr_gpio: a10sr_gpio { ->>> ->>> Device type only please. ->>> ->> ->> and this would be a10sr_gpio: gpio-controller { ->> ->> Does that seem correct? -> -> Also correct. No address though? -> + +I believe I should only call out the name and address on the SPI bus like: + +a10sr@0 { + + +Correct. + + ++ compatible = "altr,altr-a10sr"; ++ reg = <0>; ++ spi-max-frequency = <100000>; ++ ++ a10sr_gpio: a10sr_gpio { + + +Device type only please. + + + +and this would be a10sr_gpio: gpio-controller { + +Does that seem correct? + + +Also correct. No address though? + + Thank you. It is at a fixed address inside the SPI device. When making this binding I followed the format of other gpio controllers like the tps65086 and lp3943 which didn't have an address. + Thanks for the clarification. ->>>> + compatible = "altr,a10sr-gpio"; ->>>> + gpio-controller; ->>>> + #gpio-cells = <2>; ->>>> + ngpios = <16>; ->>>> + }; ->>>> + ->>>> + a10sr_hwmon: a10sr_hwmon { ->>> ->>> Device type only please. ->>> ->> I need to revisit where this will live (hwmon does not seem to be ->> the correct place) so it will change but I can follow the format ->> above if it is correct. ->> ->> Thanks for reviewing. ->> ->>>> + compatible = "altr,a10sr-hwmon"; ->>>> + }; ->>>> + }; ->>> -> + ++ compatible = "altr,a10sr-gpio"; ++ gpio-controller; ++ #gpio-cells = <2>; ++ ngpios = <16>; ++ }; ++ ++ a10sr_hwmon: a10sr_hwmon { + + +Device type only please. + + +I need to revisit where this will live (hwmon does not seem to be +the correct place) so it will change but I can follow the format +above if it is correct. + +Thanks for reviewing. + + ++ compatible = "altr,a10sr-hwmon"; ++ }; ++ }; + + + + + +-- +To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in +the body of a message to majord...@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0a7e788..3be3cb2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,148 +1,167 @@ "ref\01459278791-3646-1-git-send-email-tthayer@opensource.altera.com\0" - "ref\01459278791-3646-2-git-send-email-tthayer@opensource.altera.com\0" - "ref\020160330113532.GI3323@x1\0" - "ref\057111E8B.1040503@opensource.altera.com\0" - "ref\020160418074335.GA3346@x1\0" "From\0Thor Thayer <tthayer@opensource.altera.com>\0" "Subject\0Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings\0" - "Date\0Mon, 18 Apr 2016 09:55:37 -0500\0" - "To\0Lee Jones <lee.jones@linaro.org>\0" - "Cc\0linus.walleij@linaro.org" - gnurou@gmail.com - jdelvare@suse.com - linux@roeck-us.net - robh+dt@kernel.org - pawell.moll@arm.com - mark.rutland@arm.com - ijc+devicetree@hellion.org.uk - dinguyen@opensource.altera.com - linux-gpio@vger.kernel.org - linux-hwmon@vger.kernel.org - " devicetree@vger.kernel.org\0" + "Date\0Mon, 18 Apr 2016 07:51:08 -0700\0" + "To\0linux-hwmon@vger.kernel.org\0" "\00:1\0" "b\0" + "\n" "Hi Lee,\n" "\n" "On 04/18/2016 02:43 AM, Lee Jones wrote:\n" - "> On Fri, 15 Apr 2016, Thor Thayer wrote:\n" - ">> On 03/30/2016 06:35 AM, Lee Jones wrote:\n" - ">>> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote:\n" - ">>>\n" - ">>>> From: Thor Thayer <tthayer@opensource.altera.com>\n" - ">>>>\n" - ">>>> The Altera Arria10 Devkit System Resource chip is a Multi-Function\n" - ">>>> Device, it has two subdevices:\n" - ">>>> - GPIO\n" - ">>>> - HWMON\n" - ">>>>\n" - ">>>> This patch adds documentation for the Altera A10-SR DT bindings.\n" - ">>>>\n" - ">>>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>\n" - ">>>> ---\n" - ">>>> .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++\n" - ">>>> 1 file changed, 35 insertions(+)\n" - ">>>> create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>>\n" - ">>>> diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>> new file mode 100644\n" - ">>>> index 0000000..564c761\n" - ">>>> --- /dev/null\n" - ">>>> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>> @@ -0,0 +1,35 @@\n" - ">>>> +* Altera Arria10 Development Kit System Resource Chip\n" - ">>>> +\n" - ">>>> +Required parent device properties:\n" - ">>>> +- compatible : \"altr,altr_a10sr\"\n" - ">>>> +- spi-max-frequency : Maximum SPI frequency.\n" - ">>>> +- reg : the SPI Chip Select address for the Arria10 System Resource chip\n" - ">>>\n" - ">>> DT bindings are much easier to read in the following format:\n" - ">>>\n" - ">>> - compatible\t\t: \"altr,altr_a10sr\"\n" - ">>> - spi-max-frequency\t: Maximum SPI frequency.\n" - ">>> - reg\t\t\t: the SPI Chip Select address for the Arria10 System Resource chip\n" - ">>>\n" - ">>> ... also, sentences start with an uppercase char.\n" - ">>>\n" - ">>>> +The A10SR consists of this varied group of sub-devices:\n" - ">>>> +\n" - ">>>> +Device Description\n" - ">>>> +------ ----------\n" - ">>>> +altr_a10sr_gpio GPIO Controller\n" - ">>>> +altr_a10sr_hwmon Hardware Monitor\n" - ">>>> +\n" - ">>>> +The LEDs are implemented entirely in the device tree using\n" - ">>>> +the gpio-led framework.\n" - ">>>\n" - ">>> This is a Linuxisum and should not live in DT bindings.\n" - ">>>\n" - ">>>> +Example:\n" - ">>>> +\n" - ">>>> + a10-sr: a10-sr@0 {\n" - ">>>\n" - ">>> Nodes should be named after their device 'type'.\n" - ">>>\n" - ">>> Does this device really start a address 0?\n" - ">>>\n" - ">>\n" - ">> I see in the documentation on device trees there are a number of\n" - ">> categories I can use. GPIO is easy because it is one of the\n" - ">> categories but I'm not sure about the new device I'm adding since\n" - ">> the a10sr is a new device.\n" - ">\n" - "> It's always difficult with MFDs as they are by their very nature, more\n" - "> than one device. But how about 'resource-manager'?\n" - ">\n" + "\n" + "On Fri, 15 Apr 2016, Thor Thayer wrote:\n" + "\n" + "On 03/30/2016 06:35 AM, Lee Jones wrote:\n" + "\n" + "On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote:\n" + "\n" + "\n" + "From: Thor Thayer <ttha...@opensource.altera.com>\n" + "To: linux-hwmon@vger.kernel.org\n" + "\n" + "The Altera Arria10 Devkit System Resource chip is a Multi-Function\n" + "Device, it has two subdevices:\n" + " - GPIO\n" + " - HWMON\n" + "\n" + "This patch adds documentation for the Altera A10-SR DT bindings.\n" + "\n" + "Signed-off-by: Thor Thayer <ttha...@opensource.altera.com>\n" + "---\n" + " .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++\n" + " 1 file changed, 35 insertions(+)\n" + " create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "\n" + "diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt \n" + "b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "new file mode 100644\n" + "index 0000000..564c761\n" + "--- /dev/null\n" + "+++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "@@ -0,0 +1,35 @@\n" + "+* Altera Arria10 Development Kit System Resource Chip\n" + "+\n" + "+Required parent device properties:\n" + "+- compatible : \"altr,altr_a10sr\"\n" + "+- spi-max-frequency : Maximum SPI frequency.\n" + "+- reg : the SPI Chip Select address for the Arria10 System Resource chip\n" + "\n" + "\n" + "DT bindings are much easier to read in the following format:\n" + "\n" + "- compatible : \"altr,altr_a10sr\"\n" + "- spi-max-frequency : Maximum SPI frequency.\n" + "- reg : the SPI Chip Select address for the Arria10 System \n" + "Resource chip\n" + "\n" + "... also, sentences start with an uppercase char.\n" + "\n" + "\n" + "+The A10SR consists of this varied group of sub-devices:\n" + "+\n" + "+Device Description\n" + "+------ ----------\n" + "+altr_a10sr_gpio GPIO Controller\n" + "+altr_a10sr_hwmon Hardware Monitor\n" + "+\n" + "+The LEDs are implemented entirely in the device tree using\n" + "+the gpio-led framework.\n" + "\n" + "\n" + "This is a Linuxisum and should not live in DT bindings.\n" + "\n" + "\n" + "+Example:\n" + "+\n" + "+ a10-sr: a10-sr@0 {\n" + "\n" + "\n" + "Nodes should be named after their device 'type'.\n" + "\n" + "Does this device really start a address 0?\n" + "\n" + "\n" + "\n" + "I see in the documentation on device trees there are a number of\n" + "categories I can use. GPIO is easy because it is one of the\n" + "categories but I'm not sure about the new device I'm adding since\n" + "the a10sr is a new device.\n" + "\n" + "\n" + "It's always difficult with MFDs as they are by their very nature, more\n" + "than one device. But how about 'resource-manager'?\n" + "\n" + "\n" "OK. Yes, that would be a good name. Thanks.\n" "\n" - ">> I believe I should only call out the name and address on the SPI bus like:\n" - ">>\n" - ">> a10sr@0 {\n" - ">\n" - "> Correct.\n" - ">\n" - ">>>> +\t\tcompatible = \"altr,altr-a10sr\";\n" - ">>>> +\t\treg = <0>;\n" - ">>>> +\t\tspi-max-frequency = <100000>;\n" - ">>>> +\n" - ">>>> +\t\ta10sr_gpio: a10sr_gpio {\n" - ">>>\n" - ">>> Device type only please.\n" - ">>>\n" - ">>\n" - ">> and this would be a10sr_gpio: gpio-controller {\n" - ">>\n" - ">> Does that seem correct?\n" - ">\n" - "> Also correct. No address though?\n" - ">\n" + "\n" + "I believe I should only call out the name and address on the SPI bus like:\n" + "\n" + "a10sr@0 {\n" + "\n" + "\n" + "Correct.\n" + "\n" + "\n" + "+ compatible = \"altr,altr-a10sr\";\n" + "+ reg = <0>;\n" + "+ spi-max-frequency = <100000>;\n" + "+\n" + "+ a10sr_gpio: a10sr_gpio {\n" + "\n" + "\n" + "Device type only please.\n" + "\n" + "\n" + "\n" + "and this would be a10sr_gpio: gpio-controller {\n" + "\n" + "Does that seem correct?\n" + "\n" + "\n" + "Also correct. No address though?\n" + "\n" + "\n" "\n" "Thank you. It is at a fixed address inside the SPI device. When making \n" "this binding I followed the format of other gpio controllers like the \n" "tps65086 and lp3943 which didn't have an address.\n" "\n" + "\n" "Thanks for the clarification.\n" "\n" - ">>>> +\t\t\tcompatible = \"altr,a10sr-gpio\";\n" - ">>>> +\t\t\tgpio-controller;\n" - ">>>> +\t\t\t#gpio-cells = <2>;\n" - ">>>> +\t\t\tngpios = <16>;\n" - ">>>> +\t\t};\n" - ">>>> +\n" - ">>>> +\t\ta10sr_hwmon: a10sr_hwmon {\n" - ">>>\n" - ">>> Device type only please.\n" - ">>>\n" - ">> I need to revisit where this will live (hwmon does not seem to be\n" - ">> the correct place) so it will change but I can follow the format\n" - ">> above if it is correct.\n" - ">>\n" - ">> Thanks for reviewing.\n" - ">>\n" - ">>>> +\t\t\tcompatible = \"altr,a10sr-hwmon\";\n" - ">>>> +\t\t};\n" - ">>>> +\t};\n" - ">>>\n" - > + "\n" + "+ compatible = \"altr,a10sr-gpio\";\n" + "+ gpio-controller;\n" + "+ #gpio-cells = <2>;\n" + "+ ngpios = <16>;\n" + "+ };\n" + "+\n" + "+ a10sr_hwmon: a10sr_hwmon {\n" + "\n" + "\n" + "Device type only please.\n" + "\n" + "\n" + "I need to revisit where this will live (hwmon does not seem to be\n" + "the correct place) so it will change but I can follow the format\n" + "above if it is correct.\n" + "\n" + "Thanks for reviewing.\n" + "\n" + "\n" + "+ compatible = \"altr,a10sr-hwmon\";\n" + "+ };\n" + "+ };\n" + "\n" + "\n" + "\n" + "\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-hwmon\" in\n" + "the body of a message to majord...@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -0b79aa32776c152c4fc38cec50badab0193b8dec0b33b945fa43eb2bb94e93ab +7b389a2865c30c167e2918e5272cb24a57da1e2d2f422af42bf62403fc822825
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.