From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 02/13] drm/omapdrm: Use unlocked gem unreferencing Date: Mon, 18 Apr 2016 19:15:04 +0300 Message-ID: <57150808.5080508@ti.com> References: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> <1459330852-27668-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1058751885==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34D536E400 for ; Mon, 18 Apr 2016 16:15:12 +0000 (UTC) In-Reply-To: <1459330852-27668-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============1058751885== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E7NaJVhltImVWGOllrQKnjlf2hfrWMm7T" --E7NaJVhltImVWGOllrQKnjlf2hfrWMm7T Content-Type: multipart/mixed; boundary="fdtJ6JpQjNa4OUhEBnTed9MlHSeL90Sj9" From: Tomi Valkeinen To: Daniel Vetter , DRI Development Cc: Laurent Pinchart , Daniel Vetter Message-ID: <57150808.5080508@ti.com> Subject: Re: [PATCH 02/13] drm/omapdrm: Use unlocked gem unreferencing References: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> <1459330852-27668-3-git-send-email-daniel.vetter@ffwll.ch> In-Reply-To: <1459330852-27668-3-git-send-email-daniel.vetter@ffwll.ch> --fdtJ6JpQjNa4OUhEBnTed9MlHSeL90Sj9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 30/03/16 12:40, Daniel Vetter wrote: > For drm_gem_object_unreference callers are required to hold > dev->struct_mutex, which these paths don't. Enforcing this requirement > has become a bit more strict with >=20 > commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 > Author: Daniel Vetter > Date: Thu Oct 15 09:36:25 2015 +0200 >=20 > drm/gem: Check locking in drm_gem_object_unreference >=20 > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/oma= pdrm/omap_fbdev.c > index 3cb16f0cf381..89da41ac64d2 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -153,7 +153,7 @@ static int omap_fbdev_create(struct drm_fb_helper *= helper, > /* note: if fb creation failed, we can't rely on fb destroy > * to unref the bo: > */ > - drm_gem_object_unreference(fbdev->bo); > + drm_gem_object_unreference_unlocked(fbdev->bo); > ret =3D PTR_ERR(fb); > goto fail; > } >=20 If this is already queued somewhere: Acked-by: Tomi Valkeinen If not, I can pick this up. Tomi --fdtJ6JpQjNa4OUhEBnTed9MlHSeL90Sj9-- --E7NaJVhltImVWGOllrQKnjlf2hfrWMm7T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXFQgIAAoJEPo9qoy8lh71YfcP/jeCwc7tSlhmSX7vM6hDLbNk H/PbMv4rNVJ/yKICxGcKODD50JuicRbbL3D1O82v33ajsjFzlGNreQkgdCNEf+TF Di2wCtBYyA2spyqU0ll+j1lC/jUpVVDi3mk21kHYRM4so8t6bGXTgATDUh9rNoFQ lZ+QBpv8KoNuYDo0AY3OZUNiQ8PZlxfWoOw3Nm+Y5Soq3B1Iiot7sJp6lT8TynZq TZz3kHqmupruCOc41WRhm+wwCtZWLc4CYupwxZZ0ljj7vM5QjwY/M/xZ18JkqomJ LRFb6IoS04HHnHrB6uPzJu9r2oxj7/gFkM9MA4VdKwxJ6+b1YSNZ+RPD6vxd5eZs 8nWAC3G6L7Ls1rkDQCZEmDTi7htS1DP1W7Y14jxhUZhcrWLMLQiCmbbXAcXaLb9b 8S+pjyLaAKLp/xLt5Jf6IOHZOpLiQZnTbbQlk7Y2LorLxGqfrEsfgxUczq0IZ/lf fJTgdNFz+P/NcN1HEmt/uMPp+2/FUXRUH2Mp0TuQkHimTBrO2LGGg4MySB/ZGKJp ph0s3oUVCsaN4Lx7ZjuuzbZDDlQ+8VX21yp+CWBI4UC6l6P+7Kfu84WqXoW1dzTn XrEPh9X2oJ+nrbf7UhBTf6IiNSNXwUW3Xk2Wulk0PcjS9i5p8MntDN6gOm5iP/29 IFswn9FtKRllHGUiL8lr =nF5A -----END PGP SIGNATURE----- --E7NaJVhltImVWGOllrQKnjlf2hfrWMm7T-- --===============1058751885== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1058751885==--