From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver Date: Mon, 18 Apr 2016 10:29:53 -0600 Message-ID: <57150B81.6040104@wwwdotorg.org> References: <1460969178-20914-1-git-send-email-ldewangan@nvidia.com> <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:54270 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbcDRQ34 (ORCPT ); Mon, 18 Apr 2016 12:29:56 -0400 In-Reply-To: <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Laxman Dewangan , linus.walleij@linaro.org Cc: gnurou@gmail.com, thierry.reding@gmail.com, linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org On 04/18/2016 02:46 AM, Laxman Dewangan wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy. This seems fine as far as it goes, but if it's worth doing this, please move all the globals into the GPIO chip rather than just one of the 7 globals.