From: Thor Thayer <tthayer@opensource.altera.com>
To: Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
<arnd@arndb.de>, <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: Driver directory selection for Power Supply Status chip
Date: Mon, 18 Apr 2016 14:43:17 -0500 [thread overview]
Message-ID: <571538D5.5020209@opensource.altera.com> (raw)
In-Reply-To: <57150E47.4020503@metafoo.de>
On 04/18/2016 11:41 AM, Lars-Peter Clausen wrote:
> On 04/18/2016 06:14 PM, Thor Thayer wrote:
>> Hi,
>>
>> The Arria10 System Resource chip (A10SR) is a SPI based MFD implementing a
>> GPIO expander, reset controller, and power supply monitoring. I'm not sure
>> where the driver for the A10SR power monitoring driver should reside and I'm
>> hoping someone can offer some advice.
>>
>> I'd originally submitted the RFC to the HWMON list but the maintainer
>> pointed out that it wasn't a good fit because the A10SR only indicates
>> boolean power supply status - not the voltage level as required by HWMON.
>>
>> I read that IIO acts as a bridge between IO and HWMON but I'm also not sure
>> this fits those drivers (although I did find some power supply supervistors
>> there). It isn't quite a power supply supervisor - the A10SR is a comparator
>> instead of an Analog-to-Digital Converter.
>>
>> One additional thing, the A10SR also had a number of enable bits for
>> enabling devices external to Altera's SoC (but still on the development
>> board). These don't quite fit into the reset controller framework but would
>> seem to fit a MISC directory driver better.
>>
>> If neither IIO or MISC is a good fit, can someone suggest a more appropriate
>> place?
>
> How does the device work, does it generate an interrupt when the voltage
> level goes below the threshold? I'd like to pass the ball back and say that
> this sounds like something that should go into hwmon.
>
Good question but no, there is no interrupt.
The chip is actually a power supply sequencer for bringing up the power
supplies in the correct order. Since the sequence, timings, and
thresholds are hard coded in the chip and can't be changed
programatically, I assume it was decided that a power fail interrupt was
not needed. However, the status of the power (OK/Fail) can be read from
the chip.
I was directed to look at Documentation/hwmon/sysfs-interface which
states the units are in millivolts and I didn't see any references to a
boolean output so I'm leaning away from hwmon.
Thank you for your reply!
next prev parent reply other threads:[~2016-04-18 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 16:14 Driver directory selection for Power Supply Status chip Thor Thayer
2016-04-18 16:41 ` Lars-Peter Clausen
2016-04-18 19:43 ` Thor Thayer [this message]
2016-04-18 20:06 ` Jonathan Cameron
2016-04-18 20:06 ` Jonathan Cameron
2016-04-18 23:50 ` Guenter Roeck
2016-04-19 16:18 ` Thor Thayer
2016-04-19 16:18 ` Thor Thayer
2016-04-19 16:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571538D5.5020209@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.