From: Jonathan Cameron <jic23@kernel.org>
To: "Tirdea, Irina" <irina.tirdea@intel.com>,
"Baluta, Daniel" <daniel.baluta@intel.com>
Cc: "knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"Dogaru, Vlad" <vlad.dogaru@intel.com>,
"Purdila, Octavian" <octavian.purdila@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: magn: Split bmc150 driver in common/i2c parts
Date: Mon, 18 Apr 2016 20:44:59 +0100 [thread overview]
Message-ID: <5715393B.4080401@kernel.org> (raw)
In-Reply-To: <1F3AC3675D538145B1661F571FE1805F2F260CC5@irsmsx105.ger.corp.intel.com>
On 18/04/16 12:24, Tirdea, Irina wrote:
>
>
>> -----Original Message-----
>> From: Jonathan Cameron [mailto:jic23@kernel.org]
>> Sent: 17 April, 2016 13:02
>> To: Baluta, Daniel; Tirdea, Irina
>> Cc: knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; geert@linux-m68k.org; Dogaru, Vlad; Purdila, Octavian; linux-
>> kernel@vger.kernel.org; linux-iio@vger.kernel.org
>> Subject: Re: [PATCH 1/2] iio: magn: Split bmc150 driver in common/i2c parts
>>
>> On 15/04/16 15:13, Daniel Baluta wrote:
>>> This is useful for easily adding SPI support in later patches.
>>>
>>> Now bmc150_magn exports core functions to be used by I2C/SPI drivers
>>> instances. For the moment only I2C driver is supported.
>>>
>>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>>
>> This looks good to me - all mechanistic stuff so I doubt anything nasty
>> has snuck in. Ideally I'd like an Ack from Irina on this but it'll probably
>> be in my testing tree for a few days so I can add one if it comes in.
>>
>
> Looks good to me.
>
> Acked-by: Irina Tirdea <irina.tirdea@intel.com>
Thanks,
Added the Ack.
Jonathan
>
>> Applied to the togreg branch of iio.git - pushed out as testing for the
>> autobuilders to mess with it.
>>
>> Thanks,
>>
>> Jonathan
>
next prev parent reply other threads:[~2016-04-18 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 14:13 [PATCH 0/2] Introduce SPI support for BMC150 chip Daniel Baluta
2016-04-15 14:13 ` [PATCH 1/2] iio: magn: Split bmc150 driver in common/i2c parts Daniel Baluta
2016-04-17 10:02 ` Jonathan Cameron
2016-04-18 11:24 ` Tirdea, Irina
2016-04-18 11:24 ` Tirdea, Irina
2016-04-18 19:44 ` Jonathan Cameron [this message]
2016-04-15 14:13 ` [PATCH 2/2] iio: magn: bmc150: Introduce SPI support Daniel Baluta
2016-04-17 10:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715393B.4080401@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=geert@linux-m68k.org \
--cc=irina.tirdea@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.