From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Salisbury Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid Date: Mon, 18 Apr 2016 15:46:59 -0400 Message-ID: <571539B3.6060307@canonical.com> References: <56CE22DB.6050108@canonical.com> <87lh63uago.fsf@intel.com> <56D76208.7020702@canonical.com> <56F97A65.3010608@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56F97A65.3010608@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , sonika.jindal@intel.com Cc: David Airlie , Daniel Vetter , intel-gfx , LKML , dri-devel , LaMont Jones , rodrigo.vivi@intel.com List-Id: dri-devel@lists.freedesktop.org T24gMDMvMjgvMjAxNiAwMjozOSBQTSwgSm9zZXBoIFNhbGlzYnVyeSB3cm90ZToKPiBPbiAwMy8w Mi8yMDE2IDA0OjU4IFBNLCBKb3NlcGggU2FsaXNidXJ5IHdyb3RlOgo+PiBPbiAwMi8yOS8yMDE2 IDA0OjMzIEFNLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4+IE9uIFdlZCwgMjQgRmViIDIwMTYsIEpv c2VwaCBTYWxpc2J1cnkgPGpvc2VwaC5zYWxpc2J1cnlAY2Fub25pY2FsLmNvbT4gd3JvdGU6Cj4+ Pj4gSGkgU29uaWthLAo+Pj4+Cj4+Pj4gQSBrZXJuZWwgYnVnIHJlcG9ydCB3YXMgb3BlbmVkIGFn YWluc3QgVWJ1bnR1IFswXS4gIEFmdGVyIGEga2VybmVsCj4+Pj4gYmlzZWN0LCBpdCB3YXMgZm91 bmQgdGhhdCByZXZlcnRpbmcgdGhlIGZvbGxvd2luZyBjb21taXQgcmVzb2x2ZWQgdGhpcyBidWc6 Cj4+Pj4KPj4+PiBjb21taXQgMjM3ZWQ4NmM2OTNkOGE4ZTRkYjQ3Njk3NmFlYjMwZGY0ZGVhYzc0 Ygo+Pj4+IEF1dGhvcjogU29uaWthIEppbmRhbCA8c29uaWthLmppbmRhbEBpbnRlbC5jb20+Cj4+ Pj4gRGF0ZTogICBUdWUgU2VwIDE1IDA5OjQ0OjIwIDIwMTUgKzA1MzAKPj4+Pgo+Pj4+ICAgICBk cm0vaTkxNTogQ2hlY2sgbGl2ZSBzdGF0dXMgYmVmb3JlIHJlYWRpbmcgZWRpZAo+Pj4+Cj4+Pj4K Pj4+Pgo+Pj4+IFRoZSByZWdyZXNzaW9uIHdhcyBpbnRyb2R1Y2VkIGFzIG9mIHY0LjQtcmMxLgo+ Pj4+Cj4+Pj4gSSB3YXMgaG9waW5nIHRvIGdldCB5b3VyIGZlZWRiYWNrLCBzaW5jZSB5b3UgYXJl IHRoZSBwYXRjaCBhdXRob3IuICBEbwo+Pj4+IHRoaW5rIGluY3JlYXNpbmcgdGhlIG51bWJlciBv ZiB0cmllcyBpbiBpbnRlbF9oZG1pX2RldGVjdCgpIGlzIHdvcnRoCj4+Pj4gdHJ5aW5nPyAgRG8g eW91IHRoaW5rIGdhdGhlcmluZyBhbnkgYWRkaXRpb25hbCBkYXRhIHdpbGwgaGVscCBkaWFnbm9z ZQo+Pj4+IHRoaXMgaXNzdWUsIG9yIHdvdWxkIGl0IGJlIGJlc3QgdG8gc3VibWl0IGEgcmV2ZXJ0 IHJlcXVlc3Q/Cj4+IFRoYW5rcyBmb3IgdGhlIGluZm8uICBJIHdpbGwgaGF2ZSBhbGwgb2YgdGhl c2UgY29tbWl0cyB0ZXN0ZWQuCj4+Cj4+Cj4+PiBUaGVyZSBhcmUgYXQgbGVhc3QgdGhlIGZvbGxv d2luZyBjb21taXRzIGNsYWltaW5nIHRvIGZpeCBpc3N1ZXMgaW4gdGhlCj4+PiBhYm92ZSBjb21t aXQuIFBsZWFzZSBtYWtlIHN1cmUgeW91IGhhdmUgdGhlbS4KPj4+Cj4+PiBCUiwKPj4+IEphbmku Cj4+Pgo+Pj4KPj4+IGNvbW1pdCA4ZDQwOWNiM2U4YTI0MTk2YmU3MjcxZGVmYWZkNDYzOGYzZTBi NTE0Cj4+PiBBdXRob3I6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4+PiBEYXRlOiAgIFdlZCBGZWIgMTAgMTk6NTk6MDUgMjAxNiArMDIwMAo+Pj4KPj4+ ICAgICBkcm0vaTkxNTogRml4IGhwZCBsaXZlIHN0YXR1cyBiaXRzIGZvciBnNHgKPj4+Cj4+PiBj b21taXQgM2Q4YWNkMWY2NjdiNDVjNTMxNDAxYzhmMGMyMDMzMDcyZTMyYTA1ZAo+Pj4gQXV0aG9y OiBHYXJ5IFdhbmcgPGdhcnkuYy53YW5nQGludGVsLmNvbT4KPj4+IERhdGU6ICAgV2VkIERlYyAy MyAxNjoxMTozNSAyMDE1ICswODAwCj4+Pgo+Pj4gICAgIGRybS9pOTE1OiBpbmNyZWFzZSB0aGUg dHJpZXMgZm9yIEhETUkgaG90cGx1ZyBsaXZlIHN0YXR1cyBjaGVja2luZwo+Pj4KPj4+IGNvbW1p dCA5N2Y5MDEwYWYwNWMxNWUwYjdlNmI0ZWY2ZmY4Y2IwZWJiN2U3NzE1Cj4+PiBBdXRob3I6IERh bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4+PiBEYXRlOiAgIEZyaSBEZWMg MTEgMTk6NDQ6MTUgMjAxNSArMDEwMAo+Pj4KPj4+ICAgICBkcm0vaTkxNTogbWRlbGF5KDEwKSBj b25zaWRlcmVkIGhhcm1mdWwKPj4+Cj4+PiBjb21taXQgMGY1YTliZTE1Nzk3Zjc4YzlhMzRlNDMy ZjI2Yzc5NjE2NWI2ZTQ5YQo+Pj4gQXV0aG9yOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5j b20+Cj4+PiBEYXRlOiAgIEZyaSBOb3YgMjcgMTg6NTU6MjkgMjAxNSArMDIwMAo+Pj4KPj4+ICAg ICBkcm0vaTkxNTogdGFrZSBhIHBvd2VyIGRvbWFpbiByZWZlcmVuY2Ugd2hpbGUgY2hlY2tpbmcg dGhlIEhETUkgbGl2ZSBzdGF0dXMKPj4+Cj4+Pgo+Pj4KPj4+Cj4gSGkgSmFuaSwKPgo+IEFwcGx5 aW5nIHRoZSBmb2xsb3dpbmcgY29tbWl0IGRpZCBpbmRlZWQgZml4IHRoZSBvcmlnaW5hbCBidWdb MF06Cj4KPiBjb21taXQgOGQ0MDljYjNlOGEyNDE5NmJlNzI3MWRlZmFmZDQ2MzhmM2UwYjUxNAo+ IEF1dGhvcjogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiBEYXRlOiAgIFdlZCBGZWIgMTAgMTk6NTk6MDUgMjAxNiArMDIwMAo+Cj4gICAgIGRybS9pOTE1 OiBGaXggaHBkIGxpdmUgc3RhdHVzIGJpdHMgZm9yIGc0eAo+Cj4KPgo+IEhvd2V2ZXIsIGl0IGFs c28gaW50cm9kdWNlZCBhIG5ldyBidWcsIHdoaWNoIGlzIGNvdmVyZWQgaW4gdGhhdCBidWcKPiBy ZXBvcnQuICBUaGUgbmV3IGJ1ZyBpcyB0aGF0IGFmdGVyIGxvY2tpbmcvdW5sb2NraW5nIHRoZSBz Y3JlZW4sIGFsbCB0aGUKPiB3aW5kb3dzIGdldCBzaHVmZmxlZCBhcm91bmQgaW4gYSBtYW5uZXIg dGhhdCBpcyBjb25zaXN0ZW50IHdpdGggWAo+IGRlY2lkaW5nIHRoYXQgaXQncyBzaW5nbGUtaGVh ZGVkIGFnYWluLCBhbmQgdGhlbiBiYWNrIHRvIGRvdWJsZSBoZWFkZWQuIAo+IFRoaXMgb25seSBo YXBwZW5zIHdoZW4gSSBidWlsZCBhIGtlcm5lbCB3aXRoIGJvdGggY29tbWl0IDIzN2VkODZjIEFO RAo+IGNvbW1pdCA4ZDQwOWNiM2UuICBJZiBJIHJldmVydCAyMzdlZDg2YyBhbmQga2VlcCBvbmx5 IDhkNDA5Y2IzZSBib3RoIHRoZQo+IG9yaWdpbmFsIGJ1ZyBhbmQgdGhlIG5ldyBidWcgZ28gYXdh eS4gIERvIHlvdSB0aGluayBjb21taXQgMjM3ZWQ4NmMgaXMKPiBzdGlsbCBldmVuIG5lZWRlZCBu b3cgdGhhdCA4ZDQwOWNiM2UgaGFzIGxhbmRlZD8gIE1heWJlIHRoZSBuZXcgYnVnIGlzCj4gZHVl IHRvIHRoZSBpbnRlcmFjdGlvbiBiZXR3ZWVuIDIzN2VkODZjIGFuZCA4ZDQwOWNiM2UuCj4KPiBU aGFua3MsCj4KPiBKb2UKPgo+IFswXSBodHRwOi8vcGFkLmx2LzE1NDM2ODMKPgo+Cj4KPgo+Ckhl bGxvLAoKSXMgdGhlcmUgYW55IGFkZGl0aW9uIGRlYnVnIGRhdGEgd2UgY2FuIGNvbGxlY3QgdG8g ZGVidWcgdGhlIG5ldyBidWcKdGhhdCBjb21taXQgOGQ0MDljYjNlIGludHJvZHVjZWQ/CgpUaGFu a3MsCgpKb2UKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbcDRTrH (ORCPT ); Mon, 18 Apr 2016 15:47:07 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40897 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbcDRTrE (ORCPT ); Mon, 18 Apr 2016 15:47:04 -0400 Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid To: Jani Nikula , sonika.jindal@intel.com References: <56CE22DB.6050108@canonical.com> <87lh63uago.fsf@intel.com> <56D76208.7020702@canonical.com> <56F97A65.3010608@canonical.com> Cc: shashank.sharma@intel.com, rodrigo.vivi@intel.com, Daniel Vetter , David Airlie , intel-gfx , dri-devel , LKML , LaMont Jones From: Joseph Salisbury Message-ID: <571539B3.6060307@canonical.com> Date: Mon, 18 Apr 2016 15:46:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56F97A65.3010608@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2016 02:39 PM, Joseph Salisbury wrote: > On 03/02/2016 04:58 PM, Joseph Salisbury wrote: >> On 02/29/2016 04:33 AM, Jani Nikula wrote: >>> On Wed, 24 Feb 2016, Joseph Salisbury wrote: >>>> Hi Sonika, >>>> >>>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>>> bisect, it was found that reverting the following commit resolved this bug: >>>> >>>> commit 237ed86c693d8a8e4db476976aeb30df4deac74b >>>> Author: Sonika Jindal >>>> Date: Tue Sep 15 09:44:20 2015 +0530 >>>> >>>> drm/i915: Check live status before reading edid >>>> >>>> >>>> >>>> The regression was introduced as of v4.4-rc1. >>>> >>>> I was hoping to get your feedback, since you are the patch author. Do >>>> think increasing the number of tries in intel_hdmi_detect() is worth >>>> trying? Do you think gathering any additional data will help diagnose >>>> this issue, or would it be best to submit a revert request? >> Thanks for the info. I will have all of these commits tested. >> >> >>> There are at least the following commits claiming to fix issues in the >>> above commit. Please make sure you have them. >>> >>> BR, >>> Jani. >>> >>> >>> commit 8d409cb3e8a24196be7271defafd4638f3e0b514 >>> Author: Ville Syrjälä >>> Date: Wed Feb 10 19:59:05 2016 +0200 >>> >>> drm/i915: Fix hpd live status bits for g4x >>> >>> commit 3d8acd1f667b45c531401c8f0c2033072e32a05d >>> Author: Gary Wang >>> Date: Wed Dec 23 16:11:35 2015 +0800 >>> >>> drm/i915: increase the tries for HDMI hotplug live status checking >>> >>> commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715 >>> Author: Daniel Vetter >>> Date: Fri Dec 11 19:44:15 2015 +0100 >>> >>> drm/i915: mdelay(10) considered harmful >>> >>> commit 0f5a9be15797f78c9a34e432f26c796165b6e49a >>> Author: Imre Deak >>> Date: Fri Nov 27 18:55:29 2015 +0200 >>> >>> drm/i915: take a power domain reference while checking the HDMI live status >>> >>> >>> >>> > Hi Jani, > > Applying the following commit did indeed fix the original bug[0]: > > commit 8d409cb3e8a24196be7271defafd4638f3e0b514 > Author: Ville Syrjälä > Date: Wed Feb 10 19:59:05 2016 +0200 > > drm/i915: Fix hpd live status bits for g4x > > > > However, it also introduced a new bug, which is covered in that bug > report. The new bug is that after locking/unlocking the screen, all the > windows get shuffled around in a manner that is consistent with X > deciding that it's single-headed again, and then back to double headed. > This only happens when I build a kernel with both commit 237ed86c AND > commit 8d409cb3e. If I revert 237ed86c and keep only 8d409cb3e both the > original bug and the new bug go away. Do you think commit 237ed86c is > still even needed now that 8d409cb3e has landed? Maybe the new bug is > due to the interaction between 237ed86c and 8d409cb3e. > > Thanks, > > Joe > > [0] http://pad.lv/1543683 > > > > > Hello, Is there any addition debug data we can collect to debug the new bug that commit 8d409cb3e introduced? Thanks, Joe