From: "Kumar, Shobhit" <shobhit.kumar@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Shobhit Kumar <shobhit.kumar@intel.com>
Subject: Re: [PATCH] drm/i915: Wait for power cycle delay after turning off DSI panel power
Date: Tue, 19 Apr 2016 08:00:10 +0530 [thread overview]
Message-ID: <57159832.50907@linux.intel.com> (raw)
In-Reply-To: <1460996271-29795-1-git-send-email-ville.syrjala@linux.intel.com>
On Monday 18 April 2016 09:47 PM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The power cycle delay starts _after_ turning off the panel power. Do the
> msleep after frobbing the pmic panel power gpio.
>
> Also toss in a FIXME about optimizing away needless waits.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Fixes: fc45e8219907 ("drm/i915: Use the CRC gpio for panel enable/disable")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Shobhit Kumar <shobhit.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 34328ddaaab5..2b22bb9bb86f 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -688,11 +688,16 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)
> drm_panel_unprepare(intel_dsi->panel);
>
> msleep(intel_dsi->panel_off_delay);
> - msleep(intel_dsi->panel_pwr_cycle_delay);
>
> /* Panel Disable over CRC PMIC */
> if (intel_dsi->gpio_panel)
> gpiod_set_value_cansleep(intel_dsi->gpio_panel, 0);
> +
> + /*
> + * FIXME As we do with eDP, just make a note of the time here
> + * and perform the wait before the next panel power on.
> + */
> + msleep(intel_dsi->panel_pwr_cycle_delay);
> }
>
> static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-19 2:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 16:17 [PATCH] drm/i915: Wait for power cycle delay after turning off DSI panel power ville.syrjala
2016-04-18 17:19 ` Jani Nikula
2016-04-18 17:24 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-04-19 11:56 ` Ville Syrjälä
2016-04-19 2:30 ` Kumar, Shobhit [this message]
2016-04-19 11:59 ` [PATCH] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57159832.50907@linux.intel.com \
--to=shobhit.kumar@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shobhit.kumar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.