From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes Date: Tue, 19 Apr 2016 08:36:01 +0300 Message-ID: <5715C3C1.5000006@ti.com> References: <1460994134-12587-1-git-send-email-tomi.valkeinen@ti.com> <1523377.BVFxig5LNh@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1072417687==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id C69486E123 for ; Tue, 19 Apr 2016 05:36:07 +0000 (UTC) In-Reply-To: <1523377.BVFxig5LNh@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1072417687== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hxgPNSCOHArKDK5L8OTV6KJSdX7BKJrL3" --hxgPNSCOHArKDK5L8OTV6KJSdX7BKJrL3 Content-Type: multipart/mixed; boundary="uqCCFOsijnsJfreSDxLhmgV5GwWsP42XC" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Message-ID: <5715C3C1.5000006@ti.com> Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes References: <1460994134-12587-1-git-send-email-tomi.valkeinen@ti.com> <1523377.BVFxig5LNh@avalon> In-Reply-To: <1523377.BVFxig5LNh@avalon> --uqCCFOsijnsJfreSDxLhmgV5GwWsP42XC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19/04/16 05:17, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Monday 18 Apr 2016 18:42:11 Tomi Valkeinen wrote: >> With certain kernel config options many omapdrm files fail to compile >> due to missing include of linux/gpio/consumer.h and linux/of.h. >> >> This patch adds those includes. >> >> Signed-off-by: Tomi Valkeinen >> Reported-by: Dan Murphy >> --- >> drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 1 + >> drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 + >> drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 1 + >> drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c | 1 + >> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 + >> drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 + >> 6 files changed, 6 insertions(+) >> >> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c >> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index >> 8c246c213e06..9f06a87e80c4 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c >> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c >> @@ -15,6 +15,7 @@ >> */ >> >> #include >=20 > This driver uses the gpiod API only, you can remove gpio.h and of_gpio.= h. True. I don't want to mix fixes and cleanups, so I made a new patch for that: commit cdde6dcbf9fa0c5eadb42aac956a8ec3676aafb0 (HEAD -> 4.7/omapdrm) Author: Tomi Valkeinen Date: Tue Apr 19 08:33:25 2016 +0300 drm/omap: remove unneeded gpio includes encoder-opa362.c and panel-sharp-ls037v7dw01.c do not use the legacy GPIO API, so we can remove the including of gpio.h and of_gpio.h. Signed-off-by: Tomi Valkeinen diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index 9f06a87e80c4..e9b62a1bb5c5 100644 --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c @@ -14,12 +14,10 @@ * the Free Software Foundation. */ -#include #include #include #include #include -#include #include