From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes Date: Tue, 19 Apr 2016 11:48:00 +0300 Message-ID: <5715F0C0.4090104@ti.com> References: <1460994134-12587-1-git-send-email-tomi.valkeinen@ti.com> <1523377.BVFxig5LNh@avalon> <5715C3C1.5000006@ti.com> <1942777.PjVu1ImbyT@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0341725588==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CD736E135 for ; Tue, 19 Apr 2016 08:48:06 +0000 (UTC) In-Reply-To: <1942777.PjVu1ImbyT@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0341725588== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nJL9S6gOlWMBkQ2DLL1pQeR2cQtaBeQwI" --nJL9S6gOlWMBkQ2DLL1pQeR2cQtaBeQwI Content-Type: multipart/mixed; boundary="6B99qIoAAmowq2Bb658S7hqeBFV01jW0T" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Message-ID: <5715F0C0.4090104@ti.com> Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes References: <1460994134-12587-1-git-send-email-tomi.valkeinen@ti.com> <1523377.BVFxig5LNh@avalon> <5715C3C1.5000006@ti.com> <1942777.PjVu1ImbyT@avalon> In-Reply-To: <1942777.PjVu1ImbyT@avalon> --6B99qIoAAmowq2Bb658S7hqeBFV01jW0T Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19/04/16 11:32, Laurent Pinchart wrote: >>> This driver uses the gpiod API only, you can remove gpio.h and of_gpi= o.h. >> >> True. I don't want to mix fixes and cleanups, so I made a new patch fo= r >> that: >=20 > Given that you touch the two files in your "Fix missing includes" patch= that=20 > seems a bit overkill to me, I would have squashed the two together, but= it=20 > doesn't matter too much. If the only thing the "Fix missing includes" patch would do is to touch those two files and add the gpio/consumer.h, then... maybe. But it's touching other files, and adding of.h too. Maybe I'm being too pedantic, but I don't want to mix separate things into the same patch. If in the description I write "This patch also does xyz", I know I should split it up =3D). I could have squashed the patch and just talked about "cleaning up the includes". But that's not true, as the first patch is fixing compilation issues. Tomi --6B99qIoAAmowq2Bb658S7hqeBFV01jW0T-- --nJL9S6gOlWMBkQ2DLL1pQeR2cQtaBeQwI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXFfDAAAoJEPo9qoy8lh71OZIP/jNcdAbiLcO0ip6MMHGaQXjc QWH4CZjXXWRbJgWHP+THGDG9gb09lRU3+Rz8q19U2rqCWVAOeRxqpdNjCHuae2tg K+jamzDfbZFEGMLuhkhgLFEvN0OboR9KGYZuJysAKZkDP6k0zx+gGeSZf4Fdh1cy ijGH0PSaTCUtG09FGDcexeASbZqaYoXtuFAsNlb5OoHoAXz5G/Lb/zAvqLnYQ29l EKEFZwIngFgA+y+u3FajQg3vsplYWAsiTu0awPF9sI3K24LOeluYqpL3eZGzBSiv RXexC1lekVjcV0huDzt7cK2dQ6uIDcdLyptam3lMIJQ2jif5RZi1YPA+cdt/Wvx3 AfUd1w3U2iHZCkY4/F8coKtg6HQCqfpdbe3p3LwynrlEJNK49Zm49d5m4I4ywTuf /2jmzbVWshdDmHDjZF3auLqgC+fkDiIgzdZmxHjF1HD3RHdSqbHGrCkcMxTRMCug i3kVP5fhgsAxfVEUO+Uo24T6bD3xShtntOA7Qy27W0bkKZtmEjIWqH940HOJTXt/ nmtLkWsSzlhyLIDbLJZoXorzsRd1W3Uj6BN4dbr89e/lUYm54YOBc3SkfyR3WnPq HpZFSPYCpW/L/WpaXbQkmob72PeX/9YoIIty/5At37Sd/k1ZQMsltoyakmnU4JsF hG9H13XDlWnmG4eYILGE =zMt0 -----END PGP SIGNATURE----- --nJL9S6gOlWMBkQ2DLL1pQeR2cQtaBeQwI-- --===============0341725588== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0341725588==--