From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gmazyland@gmail.com>
Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com
 [IPv6:2a00:1450:400c:c09::241])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.server123.net (Postfix) with ESMTPS
 for <dm-crypt@saout.de>; Tue, 19 Apr 2016 11:06:54 +0200 (CEST)
Received: by mail-wm0-x241.google.com with SMTP id l6so3202195wml.3
 for <dm-crypt@saout.de>; Tue, 19 Apr 2016 02:06:54 -0700 (PDT)
References: <1461046565-16999-1-git-send-email-vapier@gentoo.org>
 <5715D177.5000701@gmail.com> <20160419065344.GE5369@vapier.lan>
From: Milan Broz <gmazyland@gmail.com>
Message-ID: <5715F52C.7050200@gmail.com>
Date: Tue, 19 Apr 2016 11:06:52 +0200
MIME-Version: 1.0
In-Reply-To: <20160419065344.GE5369@vapier.lan>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] [PATCH] include sys/sysmacros.h for
	major/minor/makedev
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt/>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=subscribe>
To: Mike Frysinger <vapier@gentoo.org>
Cc: dm-crypt@saout.de

On 04/19/2016 08:53 AM, Mike Frysinger wrote:
> On 19 Apr 2016 08:34, Milan Broz wrote:
>> On 04/19/2016 08:16 AM, Mike Frysinger wrote:
...
>>> +#include <sys/sysmacros.h>
>>
>> Shouldn't we also check for existence of this header in autoconf?
>> I do not think it is present on all systems (FreeBSD?).
> 
> i couldn't tell how portable this code base was trying to be or if it
> was assuming Linux.  if you want to be portable w/autoconf, should be
> easy to do:
> (1) call AC_HEADER_MAJOR in configure.ac
> (2) use the idiom:
> #ifdef MAJOR_IN_MKDEV
> # include <sys/mkdev.h>
> #elif defined(MAJOR_IN_SYSMACROS)
> # include <sys/sysmacros.h>
> #endif

I fixed it with this commit
https://gitlab.com/cryptsetup/cryptsetup/commit/54c4b1656f93997ae5624051c91ea10249e5a823

Thanks,
Milan