All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/19] drm/i915: Allow mmio updates on all platforms, v2.
Date: Tue, 19 Apr 2016 15:37:51 +0200	[thread overview]
Message-ID: <571634AF.5010306@linux.intel.com> (raw)
In-Reply-To: <20160419124822.GR4329@intel.com>

Op 19-04-16 om 14:48 schreef Ville Syrjälä:
> On Tue, Apr 19, 2016 at 09:52:27AM +0200, Maarten Lankhorst wrote:
>> With intel_pipe_update begin/end we ensure that the mmio updates
>> don't run during vblank interrupt, using the hw counter we can
>> be sure that when current vblank count != vblank count at the time
>> of pipe_update_end the mmio update is complete.
> Still seems too racy for my taste.
>
> What should be done is:
>  1. evade vblank
>  2. write regs
>  3. sample vblank counter and allow the irq handler to complete the flip
>     when passing the target vblank count
>  4. check if we just missed the vblank irq, and if so complete the flip immediately
>
> Also I would have started by ridding us of the flip done interrupt
> first, because that means every platform would then follow the same code
> path leading to better testing coverage (and hopefully less bugs). And
> it would allow us to remove the extra vblank wait hacks on BDW.
>
I do set the current vblank counter, only after it advanced to next vblank it would signal vblank done.

I do agree we should get rid of flip handling, but that should be done after removing cs flip support, and can be a cleanup patch after this series.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-04-19 13:37 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19  7:52 [PATCH 00/19] Rework page flip, remove cs flips, async unpin and unified pageflip Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v4 Maarten Lankhorst
2016-04-25  4:35   ` Mario Kleiner
2016-04-25  6:32     ` [PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v5 Maarten Lankhorst
2016-04-25  7:49       ` Mario Kleiner
2016-04-27 23:02       ` Mario Kleiner
2016-04-25 12:26     ` [PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v4 Ville Syrjälä
2016-04-19  7:52 ` [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2 Maarten Lankhorst
2016-04-27 13:24   ` Patrik Jakobsson
2016-04-28  8:48     ` Maarten Lankhorst
2016-04-28  9:54       ` Patrik Jakobsson
2016-04-28 10:20         ` Maarten Lankhorst
2016-05-03 13:48           ` Patrik Jakobsson
2016-05-03 14:15             ` Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 03/19] drm/i915: Remove intel_prepare_page_flip, v2 Maarten Lankhorst
2016-04-25 23:14   ` Patrik Jakobsson
2016-04-28  9:24     ` Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 04/19] drm/i915: Add support for detecting vblanks when hw frame counter is unavailable Maarten Lankhorst
2016-04-27 14:06   ` Patrik Jakobsson
2016-04-27 14:23     ` Ville Syrjälä
2016-05-10 12:30       ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 05/19] drm/i915: Unify unpin_work and mmio_work into flip_work Maarten Lankhorst
2016-04-29 12:47   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 06/19] Revert "drm/i915: Avoid stalling on pending flips for legacy cursor updates" Maarten Lankhorst
2016-05-10 12:31   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 07/19] drm/i915: Allow mmio updates on all platforms, v2 Maarten Lankhorst
2016-04-19 12:48   ` Ville Syrjälä
2016-04-19 13:37     ` Maarten Lankhorst [this message]
2016-05-12 11:49     ` [RFC PATCH " Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 08/19] drm/i915: Convert flip_work to a list Maarten Lankhorst
2016-05-02  9:22   ` Patrik Jakobsson
2016-05-02 11:07     ` Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 09/19] drm/i915: Add the exclusive fence to plane_state Maarten Lankhorst
2016-05-03 12:47   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 10/19] drm/i915: Rework intel_crtc_page_flip to be almost atomic, v3 Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 11/19] drm/i915: Remove cs based page flip support Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 12/19] drm/i915: Remove use_mmio_flip kernel parameter Maarten Lankhorst
2016-05-11  8:48   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 13/19] drm/i915: Remove queue_flip pointer Maarten Lankhorst
2016-05-11  8:49   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 14/19] drm/i915: Pass atomic states to fbc update functions Maarten Lankhorst
2016-05-11  9:13   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 15/19] drm/i915: Prepare MST connector removal for async unpin Maarten Lankhorst
2016-05-11  9:26   ` Patrik Jakobsson
2016-04-19  7:52 ` [PATCH 16/19] drm/i915: Make unpin async Maarten Lankhorst
2016-04-25 16:26   ` Lionel Landwerlin
2016-04-25 16:26   ` Lionel Landwerlin
2016-04-26  7:14     ` Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 17/19] Reapply "drm/i915: Avoid stalling on pending flips for legacy cursor updates" Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 18/19] drm/i915: Check for unpin correctness Maarten Lankhorst
2016-04-19  7:52 ` [PATCH 19/19] drm/i915: Allow async update of pageflips Maarten Lankhorst
2016-04-19  8:19   ` Chris Wilson
2016-04-19 12:26     ` Maarten Lankhorst
2016-04-20 13:24     ` Daniel Vetter
2016-04-20 13:45       ` Chris Wilson
2016-04-20  7:39   ` Maarten Lankhorst
2016-04-19  8:27 ` ✗ Fi.CI.BAT: failure for Rework page flip, remove cs flips, async unpin and unified pageflip Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571634AF.5010306@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.