From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DC08AE00F8D; Tue, 19 Apr 2016 09:33:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 38145E00AE4 for ; Tue, 19 Apr 2016 09:33:43 -0700 (PDT) Received: by mail-wm0-f52.google.com with SMTP id n3so39462785wmn.0 for ; Tue, 19 Apr 2016 09:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=S2hLf23Ii6hNojWLZHjmm2zLJpmP7jdvgIwBW+u+zYs=; b=M4d6XWWDiAJauz7g+H8hZz9okj3edw77KTsAEKITP6VenE9mQD90axT9w1cdNtjfEL uks9DrZx+AapGGflx3uNBr7Tgx79IGFSgv+xjwwDmDitphFNX7N1a9kgmQHmUbmOHiNV PJNUk4YP/7E13cUTdueIcVsNcnoPisD1f2/g7fpve3hSABBMo45sdoWxoghajZA8k/zT VN2mHCrY5wx9uRJCXpZO5Ju7F0r8L3zrjPDDfS7+7DZ1FnVvu/3wWX8gaGZCMcL7zLSC whi7f3NE91483nG1+mVPWJ1St8eGy6EfYEM3V4RMcMoOnFbrdfVUhF5CV4FlbNb2cE+t Np7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=S2hLf23Ii6hNojWLZHjmm2zLJpmP7jdvgIwBW+u+zYs=; b=I1EfSU3/4CNWSyvqgZtV6OxfQ1OVlGoW6RXEudtfknHLa/3vpCCB8Ur/kJZad+f23I hlKCE844XEf3TDM/7SIQ4nZkk0NsqPfyo1q9aviqxBunenH/f+qcpuUPRzsPDzZNh06u VMtRXxEpaFLrQRQs4QsUWv0Z1XCqYboXPS7/Uzi7zfbTQWxszeGE96ioUJyRgru48D36 kqsdMg/YRWB2T3il89JQa1H0zoop6A4Wi3/PWzP0Rw21Ngfmzqn6Ss7p6WqPcablXpY8 qLlrMvXH+Mn1FmjwA39iIhDiCIh1a4kaG/e8Nu9MfKeRQe6sLf5MjlMN0D7L4Vea/lRZ /p5w== X-Gm-Message-State: AOPr4FVHujkX7p4DUKHhHsSIFNtag0PHiQzVg4kDQkBmO1oUEzl/gZOAbyEWwtg9XD8yLfDe X-Received: by 10.28.157.142 with SMTP id g136mr4588663wme.29.1461083622582; Tue, 19 Apr 2016 09:33:42 -0700 (PDT) Received: from [192.168.0.83] (host109-150-176-203.range109-150.btcentralplus.com. [109.150.176.203]) by smtp.googlemail.com with ESMTPSA id w202sm5129881wmw.18.2016.04.19.09.33.41 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2016 09:33:41 -0700 (PDT) To: toaster@yoctoproject.org References: <011977994B5AE74ABA2BD08E983BAAABDBEF7518@ALA-MBA.corp.ad.wrs.com> From: Michael Wood Message-ID: <57165DE5.1080907@intel.com> Date: Tue, 19 Apr 2016 17:33:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 0/4] Validate custom image names correctly X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 16:33:45 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sent to bitbake-devel and added to toaster-next Thanks, Michael On 14/04/16 08:13, Smith, Elliot wrote: > Thanks for the review, Dave. I'll have another look at this once the > Bootstrap 3 work is done. > > Elliot > > On 13 April 2016 at 21:57, Lerner, Dave M (Wind River) > > wrote: > > Hi Elliot, > > I cannot reproduce the original symptom in your steps, outlined at > https://lists.yoctoproject.org/pipermail/toaster/2016-April/004425.html. > Specifically step 6 passes without your patches. Or using Belen's > steps in the defect: > ====== > 1. Create a Toaster project. > 2. Create a custom image > 3. Create a second Toaster project > 4. Create a custom image and try to give it the same name you > used for the custom > image you created in step 2 > Toaster will complain that a custom image with that name already > exists. > ====== > The complaint is gone, this symptom no longer occurs without your > patch 1/4. > > Neither her steps nor yours in the 0/4 RR email state that the > custom image must be built, just created, so my baseline steps > don't build the custom image. > > Patch 2/4 addresses a different issue, but I don't know how to > test the baseline fault nor test the fix. > > Since patch 1/4 isn't necessary with respect to the defect, > shouldn't it be dropped?You could provide a defect with or without > a test for the fix in patch 2/4. > > Dave > > -----Original Message----- > > From: toaster-bounces@yoctoproject.org > > [mailto:toaster-bounces@yoctoproject.org > ] On > > Behalf Of Elliot Smith > > Sent: Monday, April 11, 2016 6:27 AM > > To: toaster@yoctoproject.org > > Subject: [Toaster] [PATCH 0/4] Validate custom image names correctly > > > > We currently validate the name of a new custom image across all > projects. > > This means you can't use the same custom image name in multiple > projects. > > > > Modify the code to do validation correctly, and add UI tests to > verify. > > > > To test: > > > > 1. Create a project. > > 2. Create a custom image with name 'goo' in this project; it > should work. > > 3. Try to create another custom image called 'goo' in this > project; it should fail. > > 4. Try to create a custom image called 'core-image-minimal' in > this project; it should > > fail. > > 5. Create another project. > > 6. Create a custom image called 'goo' in the second project; it > should work. > > > > The following changes since commit > 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2: > > > > toaster: fixes for customimage package not found (2016-04-08 > 09:38:50 +0100) > > > > are available in the git repository at: > > > > git://git.yoctoproject.org/poky-contrib > > elliot/toaster/recipe_name_validation-9209 > > http://git.yoctoproject.org/cgit.cgi/poky- > > contrib/log/?h=elliot/toaster/recipe_name_validation-9209 > > > > Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209 > > > > Elliot Smith (4): > > toaster: only prevent duplicate custom image names within a > project > > toaster: prevent exception when Project.release is null > > toaster-tests: add tests for new custom image page > > toaster-tests: make helper click on input before entering text > > > > bitbake/lib/toaster/orm/models.py | 16 ++- > > .../lib/toaster/tests/browser/selenium_helpers.py | 6 +- > > .../tests/browser/test_new_custom_image_page.py | 160 > +++++++++++++++++++++ > > .../toastergui/static/js/newcustomimage_modal.js | 8 +- > > bitbake/lib/toaster/toastergui/views.py | 33 +++-- > > 5 files changed, 200 insertions(+), 23 deletions(-) > > create mode 100644 > bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py > > > > -- > > 1.9.3 > > > > > --------------------------------------------------------------------- > > Intel Corporation (UK) Limited > > Registered No. 1134945 (England) > > Registered Office: Pipers Way, Swindon SN3 1RJ > > VAT No: 860 2173 47 > > > > This e-mail and any attachments may contain confidential > material for > > the sole use of the intended recipient(s). Any review or > distribution > > by others is strictly prohibited. If you are not the intended > > recipient, please contact the sender and delete all copies. > > > > -- > > _______________________________________________ > > toaster mailing list > > toaster@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > >