From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915/guc: local optimisations
 and updating comments
Date: Tue, 19 Apr 2016 17:38:49 +0100
Message-ID: <57165F19.1040205@intel.com>
References: <1461066350-32642-1-git-send-email-david.s.gordon@intel.com>
 <1461066350-32642-3-git-send-email-david.s.gordon@intel.com>
 <571649F5.2030504@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTP id 658B36E7EB
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Apr 2016 16:38:51 +0000 (UTC)
In-Reply-To: <571649F5.2030504@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMTkvMDQvMTYgMTY6MDgsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTkvMDQvMTYg
MTI6NDUsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBUaWR5aW5nIHVwIGd1Y19pbml0X3Byb2NfZGVz
YygpIGFuZCBhZGRpbmcgY29tbWVudGFyeSB0byB0aGUgY2xpZW50Cj4+IHN0cnVjdHVyZSBhZnRl
ciB0aGUgcmVjZW50IGNoYW5nZSBpbiBHdUMgcGFnZSBtYXBwaW5nIHN0cmF0ZWd5Lgo+Pgo+PiBT
aWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiAt
LS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCAzOAo+
PiArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysKPj4gICAyIGZp
bGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGluZGV4IDEzNWYw
OTQuLjViYmIxM2IgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj
X3N1Ym1pc3Npb24uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt
aXNzaW9uLmMKPj4gQEAgLTM1OCwxMiArMzU4LDE0IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X3By
b2NfZGVzYyhzdHJ1Y3QgaW50ZWxfZ3VjCj4+ICpndWMsCj4+ICAgc3RhdGljIHZvaWQgZ3VjX2lu
aXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+PiAgICAgICAgICAgICAgICAgICAg
IHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPj4gICB7Cj4+ICsgICAgc3RydWN0IGRy
bV9pOTE1X2dlbV9vYmplY3QgKmNsaWVudF9vYmogPSBjbGllbnQtPmNsaWVudF9vYmo7Cj4+ICAg
ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7
Cj4+ICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPj4gICAgICAgc3RydWN0
IGludGVsX2NvbnRleHQgKmN0eCA9IGNsaWVudC0+b3duZXI7Cj4+ICAgICAgIHN0cnVjdCBndWNf
Y29udGV4dF9kZXNjIGRlc2M7Cj4+ICAgICAgIHN0cnVjdCBzZ190YWJsZSAqc2c7Cj4+ICAgICAg
IGVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+PiArICAgIHUzMiBnZnhfYWRkcjsKPj4KPj4gICAg
ICAgbWVtc2V0KCZkZXNjLCAwLCBzaXplb2YoZGVzYykpOwo+Pgo+PiBAQCAtMzkyLDE2ICszOTQs
MTcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1Ywo+PiAq
Z3VjLAo+PiAgICAgICAgICAgbHJjLT5jb250ZXh0X2Rlc2MgPSAodTMyKWN0eF9kZXNjOwo+Pgo+
PiAgICAgICAgICAgLyogVGhlIHN0YXRlIHBhZ2UgaXMgYWZ0ZXIgUFBIV1NQICovCj4+IC0gICAg
ICAgIGxyYy0+cmluZ19sY3JhID0gaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KG9iaikgKwo+PiAt
ICAgICAgICAgICAgICAgIExSQ19TVEFURV9QTiAqIFBBR0VfU0laRTsKPj4gKyAgICAgICAgZ2Z4
X2FkZHIgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKPj4gKyAgICAgICAgbHJjLT5y
aW5nX2xjcmEgPSBnZnhfYWRkciArIExSQ19TVEFURV9QTiAqIFBBR0VfU0laRTsKPj4gICAgICAg
ICAgIGxyYy0+Y29udGV4dF9pZCA9IChjbGllbnQtPmN0eF9pbmRleCA8PCBHVUNfRUxDX0NUWElE
X09GRlNFVCkgfAo+PiAgICAgICAgICAgICAgICAgICAoZW5naW5lLT5ndWNfaWQgPDwgR1VDX0VM
Q19FTkdJTkVfT0ZGU0VUKTsKPj4KPj4gICAgICAgICAgIG9iaiA9IGN0eC0+ZW5naW5lW2lkXS5y
aW5nYnVmLT5vYmo7Cj4+ICsgICAgICAgIGdmeF9hZGRyID0gaTkxNV9nZW1fb2JqX2dndHRfb2Zm
c2V0KG9iaik7Cj4+Cj4+IC0gICAgICAgIGxyYy0+cmluZ19iZWdpbiA9IGk5MTVfZ2VtX29ial9n
Z3R0X29mZnNldChvYmopOwo+PiAtICAgICAgICBscmMtPnJpbmdfZW5kID0gbHJjLT5yaW5nX2Jl
Z2luICsgb2JqLT5iYXNlLnNpemUgLSAxOwo+PiAtICAgICAgICBscmMtPnJpbmdfbmV4dF9mcmVl
X2xvY2F0aW9uID0gbHJjLT5yaW5nX2JlZ2luOwo+PiArICAgICAgICBscmMtPnJpbmdfYmVnaW4g
PSBnZnhfYWRkcjsKPj4gKyAgICAgICAgbHJjLT5yaW5nX2VuZCA9IGdmeF9hZGRyICsgb2JqLT5i
YXNlLnNpemUgLSAxOwo+PiArICAgICAgICBscmMtPnJpbmdfbmV4dF9mcmVlX2xvY2F0aW9uID0g
Z2Z4X2FkZHI7Cj4+ICAgICAgICAgICBscmMtPnJpbmdfY3VycmVudF90YWlsX3BvaW50ZXJfdmFs
dWUgPSAwOwo+Pgo+PiAgICAgICAgICAgZGVzYy5lbmdpbmVzX3VzZWQgfD0gKDEgPDwgZW5naW5l
LT5ndWNfaWQpOwo+PiBAQCAtNDEwLDIyICs0MTMsMTcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRf
Y3R4X2Rlc2Moc3RydWN0IGludGVsX2d1Ywo+PiAqZ3VjLAo+PiAgICAgICBXQVJOX09OKGRlc2Mu
ZW5naW5lc191c2VkID09IDApOwo+Pgo+PiAgICAgICAvKgo+PiAtICAgICAqIFRoZSBDUFUgYWRk
cmVzcyBpcyBvbmx5IG5lZWRlZCBhdCBjZXJ0YWluIHBvaW50cywgc28KPj4ga21hcF9hdG9taWMg
b24KPj4gLSAgICAgKiBkZW1hbmQgaW5zdGVhZCBvZiBzdG9yaW5nIGl0IGluIHRoZSBjdHggZGVz
Y3JpcHRvci4KPj4gLSAgICAgKiBYWFg6IE1heSBtYWtlIGRlYnVnIGVhc2llciB0byBoYXZlIGl0
IG1hcHBlZAo+PiArICAgICAqIFRoZSBkb29yYmVsbCwgcHJvY2VzcyBkZXNjcmlwdG9yLCBhbmQg
d29ya3F1ZXVlIGFyZSBhbGwgcGFydHMKPj4gKyAgICAgKiBvZiB0aGUgY2xpZW50IG9iamVjdCwg
d2hpY2ggdGhlIEd1QyB3aWxsIHJlZmVyZW5jZSB2aWEgdGhlIEdHVFQKPj4gICAgICAgICovCj4+
IC0gICAgZGVzYy5kYl90cmlnZ2VyX2NwdSA9IDA7Cj4+IC0gICAgZGVzYy5kYl90cmlnZ2VyX3Vr
ID0gY2xpZW50LT5kb29yYmVsbF9vZmZzZXQgKwo+PiAtICAgICAgICBpOTE1X2dlbV9vYmpfZ2d0
dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKPj4gLSAgICBkZXNjLmRiX3RyaWdnZXJfcGh5
ID0gY2xpZW50LT5kb29yYmVsbF9vZmZzZXQgKwo+PiAtICAgICAgICBzZ19kbWFfYWRkcmVzcyhj
bGllbnQtPmNsaWVudF9vYmotPnBhZ2VzLT5zZ2wpOwo+PiAtCj4+IC0gICAgZGVzYy5wcm9jZXNz
X2Rlc2MgPSBjbGllbnQtPnByb2NfZGVzY19vZmZzZXQgKwo+PiAtICAgICAgICBpOTE1X2dlbV9v
YmpfZ2d0dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKPj4gLQo+PiAtICAgIGRlc2Mud3Ff
YWRkciA9IGNsaWVudC0+d3Ffb2Zmc2V0ICsKPj4gLSAgICAgICAgaTkxNV9nZW1fb2JqX2dndHRf
b2Zmc2V0KGNsaWVudC0+Y2xpZW50X29iaik7Cj4+IC0KPj4gKyAgICBnZnhfYWRkciA9IGk5MTVf
Z2VtX29ial9nZ3R0X29mZnNldChjbGllbnRfb2JqKTsKPj4gKyAgICBkZXNjLmRiX3RyaWdnZXJf
cGh5ID0gc2dfZG1hX2FkZHJlc3MoY2xpZW50X29iai0+cGFnZXMtPnNnbCkgKwo+PiArICAgICAg
ICAgICAgICAgIGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0Owo+PiArICAgIGRlc2MuZGJfdHJpZ2dl
cl9jcHUgPSAodWludHB0cl90KWNsaWVudC0+Y2xpZW50X2Jhc2UgKwo+PiArICAgICAgICAgICAg
ICAgIGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0Owo+Cj4gVGhpcyBjaGFuZ2VkIGZyb20gemVybyB0
byB0aGUgYWRkcmVzcy4gV2FzIGl0IGJ1Z2d5IGJlZm9yZT8KCkl0J3Mgbm90IGFjdHVhbGx5IHVz
ZWQsIEFGQUlDVCwgYnV0IHdlIG1pZ2h0IGFzIHdlbGwgc2V0IGl0IHRvIHRoZSAKY29ycmVjdCB2
YWx1ZSBhbnl3YXkgLSB0aGlzIGRhdGEgaXMgc2hhcmVkIHdpdGggdGhlIEd1Qywgc28gSSdkIGxp
a2UgdGhlIAp2YWx1ZXMgdG8gYmUgYXMgY29tcGxldGUgYW5kIGNvcnJlY3QgYXMgcG9zc2libGUs
IGluIGNhc2UgdGhlIEd1QyAKZmlybXdhcmUgZXZlciBzdGFydHMgbWFraW5nIHVzZSBvZiB0aGVt
LiBBbmQgbWF5YmUgd2UgY291bGQgdXNlIHRoaXMgZm9yIApjb25zaXN0ZW5jeSBjaGVja2luZyBp
ZiB3ZSBldmVyIGZvdW5kIG15c3RlcmlvdXMgcGFnZSBmYXVsdHMgaW4gdGhlIApkb29yYmVsbCBj
b2RlLiBCdXQgcmVhbGx5IGl0J3MganVzdCB0byBzaG93IHRoYXQgdGhlc2UgdGhyZWUgZmllbGRz
IGFsbCAKZGVzY3JpYmUgdGhlIHNhbWUgdGhpbmcsIG5hbWVseSB3aGVyZSB0byByaW5nIHRoZSBk
b29yYmVsbCwgaW4gcGh5c2ljYWwgCihETUEpLCBrZXJuZWwsIGFuZCBHR1RUIGFkZHJlc3Mgc3Bh
Y2VzLgoKLkRhdmUuCgo+PiArICAgIGRlc2MuZGJfdHJpZ2dlcl91ayA9IGdmeF9hZGRyICsgY2xp
ZW50LT5kb29yYmVsbF9vZmZzZXQ7Cj4+ICsgICAgZGVzYy5wcm9jZXNzX2Rlc2MgPSBnZnhfYWRk
ciArIGNsaWVudC0+cHJvY19kZXNjX29mZnNldDsKPj4gKyAgICBkZXNjLndxX2FkZHIgPSBnZnhf
YWRkciArIGNsaWVudC0+d3Ffb2Zmc2V0Owo+PiAgICAgICBkZXNjLndxX3NpemUgPSBjbGllbnQt
PndxX3NpemU7Cj4+Cj4+ICAgICAgIC8qCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9ndWMuaAo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+
IGluZGV4IDE5Y2E1OTMuLmM1MDNjY2QgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2d1Yy5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5o
Cj4+IEBAIC0yOSw2ICsyOSwyOSBAQAo+Pgo+PiAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVz
dDsKPj4KPj4gKy8qCj4+ICsgKiBUaGlzIHN0cnVjdHVyZSBwcmltYXJpbHkgZGVzY3JpYmVzIHRo
ZSBHRU0gb2JqZWN0IHNoYXJlZCB3aXRoIHRoZQo+PiBHdUMuCj4+ICsgKiBUaGUgR0VNIG9iamVj
dCBpcyBoZWxkIGZvciB0aGUgZW50aXJlIGxpZmV0aW1lIG9mIG91ciBpbnRlcmFjdGlvbgo+PiB3
aXRoCj4+ICsgKiB0aGUgR3VDLCBiZWluZyBhbGxvY2F0ZWQgYmVmb3JlIHRoZSBHdUMgaXMgbG9h
ZGVkIHdpdGggaXRzIGZpcm13YXJlLgo+PiArICogQmVjYXVzZSB0aGVyZSdzIG5vIHdheSB0byB1
cGRhdGUgdGhlIGFkZHJlc3MgdXNlZCBieSB0aGUgR3VDIGFmdGVyCj4+ICsgKiBpbml0aWFsaXNh
dGlvbiwgdGhlIHNoYXJlZCBvYmplY3QgbXVzdCBzdGF5IHBpbm5lZCBpbnRvIHRoZSBHR1RUIGFz
Cj4+ICsgKiBsb25nIGFzIHRoZSBHdUMgaXMgaW4gdXNlLiBXZSBhbHNvIGtlZXAgdGhlIGZpcnN0
IHBhZ2UgKG9ubHkpIG1hcHBlZAo+PiArICogaW50byBrZXJuZWwgYWRkcmVzcyBzcGFjZSwgYXMg
aXQgaW5jbHVkZXMgc2hhcmVkIGRhdGEgdGhhdCBtdXN0IGJlCj4+ICsgKiB1cGRhdGVkIG9uIGV2
ZXJ5IHJlcXVlc3Qgc3VibWlzc2lvbi4KPj4gKyAqCj4+ICsgKiBUaGUgc2luZ2xlIEdFTSBvYmpl
Y3QgZGVzY3JpYmVkIGhlcmUgaXMgYWN0dWFsbHkgbWFkZSB1cCBvZiBzZXZlcmFsCj4+ICsgKiBz
ZXBhcmF0ZSBhcmVhcywgYXMgZmFyIGFzIHRoZSBHdUMgaXMgY29uY2VybmVkLiBUaGUgZmlyc3Qg
cGFnZSAoa2VwdAo+PiArICoga21hcCdkKSBpbmNsdWRlcyB0aGUgInByb2Nlc3MgZGVjcmlwdG9y
IiB3aGljaCBob2xkcyBzZXF1ZW5jZSBkYXRhCj4+IGZvcgo+Cj4gVHlwbyAtIGRlc2NyaXB0b3Iu
IDopIChzcG90dGVkIGJ5IFRodW5kZXJiaXJkKQo+Cj4+ICsgKiB0aGUgZG9vcmJlbGwsIGFuZCBv
bmUgY2FjaGVsaW5lIHdoaWNoIGFjdHVhbGx5ICppcyogdGhlIGRvb3JiZWxsOyBhCj4+ICsgKiB3
cml0ZSB0byB0aGlzIHdpbGwgInJpbmciIHRoZSBkb29yYmVsbCAoaS5lLiBzZW5kIGFuIGludGVy
cnVwdCB0byB0aGUKPj4gKyAqIEd1QykuIFRoZSBzdWJzZXF1ZW50ICBwYWdlcyBvZiB0aGUgY2xp
ZW50IG9iamVjdCBjb25zdGl0dXRlIHRoZSB3b3JrCj4+ICsgKiBxdWV1ZSAoYSBjaXJjdWxhciBh
cnJheSBvZiB3b3JrIGl0ZW1zKSwgYWdhaW4gZGVzY3JpYmVkIGluIHRoZQo+PiBwcm9jZXNzCj4+
ICsgKiBkZXNjcmlwdG9yLiBXb3JrIHF1ZXVlIHBhZ2VzIGFyZSBtYXBwZWQgbW9tZW50YXJpbHkg
YXMgcmVxdWlyZWQuCj4+ICsgKgo+PiArICogRmluYWxseSwgd2UgYWxzbyBrZWVwIGEgZmV3IHN0
YXRpc3RpY3MgaGVyZSwgaW5jbHVkaW5nIHRoZSBudW1iZXIgb2YKPj4gKyAqIHN1Ym1pc3Npb25z
IHRvIGVhY2ggZW5naW5lLCBhbmQgYSByZWNvcmQgb2YgdGhlIGxhc3Qgc3VibWlzc2lvbgo+PiBm
YWlsdXJlCj4+ICsgKiAoaWYgYW55KS4KPj4gKyAqLwo+PiAgIHN0cnVjdCBpOTE1X2d1Y19jbGll
bnQgewo+PiAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqY2xpZW50X29iajsKPj4g
ICAgICAgdm9pZCAqY2xpZW50X2Jhc2U7ICAgICAgICAvKiBmaXJzdCBwYWdlIChvbmx5KSBvZiBh
Ym92ZSAgICAqLwo+Pgo+Cj4gTG9va3MgZmluZSwgb25seSBxdWVzdGlvbiBtYXJrIG92ZXIgZGVz
Yy5kYl90cmlnZ2VyX2NwdSBpcyBwcmV2ZW50aW5nIHItYi4KPgo+IFJlZ2FyZHMsCj4KPiBUdnJ0
a28KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl
bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK