From: Eric Blake <eblake@redhat.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs
Date: Tue, 19 Apr 2016 13:23:50 -0600 [thread overview]
Message-ID: <571685C6.3060103@redhat.com> (raw)
In-Reply-To: <87wpnt5shx.fsf@oc4731375738.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On 04/19/2016 01:05 PM, Sascha Silbe wrote:
> Dear Kevin,
>
> Kevin Wolf <kwolf@redhat.com> writes:
>
> [...]
>> Isn't the JSON schema (qapi/block-core.json) considered the
>> authoritative source for interface specifications these days? I think if
>> we want to document the shortcomings for the time being, we should
>> document it in both places.
>
> Interesting. What exactly is the relationship between qmp-commands.hx
> and qapi/block-core.json?
Ultimately, we want to make qmp-commands.hx go away, and have everything
generated from qapi/*.json. Marc-Andre has proposed some patches along
those lines (back in the 2.5 timeframe, but dependent on other qapi
patches that are still pending review).
>
> At any rate, you're right that we should update both. See v2.
Until we've automated the docs from a single source file, that is the
correct approach.
>
> (And I've forgot the for-2.6 prefix for the patch itself again. Bah.)
>
> Sascha
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-04-19 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 20:59 [Qemu-devel] [PATCH] qmp-commands.hx: document minimum speed for block jobs Sascha Silbe
2016-04-14 11:08 ` [Qemu-devel] [for-2.6] " Sascha Silbe
2016-04-15 15:35 ` Kevin Wolf
2016-04-19 19:05 ` Sascha Silbe
2016-04-19 19:23 ` Eric Blake [this message]
2016-04-19 19:37 ` Sascha Silbe
2016-04-19 19:03 ` [Qemu-devel] [PATCH v2] QMP: " Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571685C6.3060103@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.