diff for duplicates of <5716DFF3.6080905@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 488a039..5219b98 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,95 +1,128 @@ + On 04/19/2016 07:38 AM, Thor Thayer wrote: -> -> -> On 04/19/2016 02:23 AM, Lee Jones wrote: ->> On Mon, 18 Apr 2016, Thor Thayer wrote: ->> ->>> Hi Lee, ->>> ->>> On 04/18/2016 02:45 AM, Lee Jones wrote: ->>>> On Fri, 15 Apr 2016, Thor Thayer wrote: ->>>>> On 03/30/2016 06:35 AM, Lee Jones wrote: ->>>>>> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote: ->>>>>> ->>>>>>> From: Thor Thayer <tthayer@opensource.altera.com> ->>>>>>> ->>>>>>> The Altera Arria10 Devkit System Resource chip is a Multi-Function ->>>>>>> Device, it has two subdevices: ->>>>>>> - GPIO ->>>>>>> - HWMON ->>>>>>> ->>>>>>> This patch adds documentation for the Altera A10-SR DT bindings. ->>>>>>> ->>>>>>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> ->>>>>>> --- ->>>>>>> .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++ ->>>>>>> 1 file changed, 35 insertions(+) ->>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>>>>> ->>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>>>>> new file mode 100644 ->>>>>>> index 0000000..564c761 ->>>>>>> --- /dev/null ->>>>>>> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt ->>>>>>> @@ -0,0 +1,35 @@ ->>>>>>> +* Altera Arria10 Development Kit System Resource Chip ->>>>>>> + ->>>>>>> +Required parent device properties: ->>>>>>> +- compatible : "altr,altr_a10sr" ->>>>>>> +- spi-max-frequency : Maximum SPI frequency. ->>>>>>> +- reg : the SPI Chip Select address for the Arria10 System Resource chip ->>>> ->>>> [...] ->>>> ->>>>>>> + a10sr_hwmon: a10sr_hwmon { ->>>>>> ->>>>>> Device type only please. ->>>>>> ->>>>> I need to revisit where this will live (hwmon does not seem to be ->>>>> the correct place) so it will change but I can follow the format ->>>>> above if it is correct. ->>>> ->>>> BTW, "hwmon" is a subsystem in Linux, therefore is a Linuxism and is ->>>> not allowed in DT. What does the device *actually* do? ->>>> ->>> ->>> OK. I'll be careful not to introduce the Linux subsystem name. ->>> ->>> This module indicates whether the power supplies are at the correct ->>> voltage. It uses a boolean instead of giving an actual voltage value ->>> as required by HWMON. In other words it is a comparator instead of ->>> an Analog-to-Digital Converter. ->>> ->>> I could call it a power supply supervisor or voltage status monitor ->>> but it only acts in a passive role. There is no output to trigger an ->>> error - only polling, so supervisor doesn't seem like a good name. ->>> ->>> Maybe something like this? ->>> ->>> power_supply_status { ->>> compatible = "altr,a10sr-hwmon"; ->>> } ->>> ->>> Thanks for reviewing and helping me figure out the device tree naming. ->> ->> Does it have its own address space? How complex is the device? Not ->> very, by the sounds of it. In which case, does it really need its own ->> driver? ->> -> Yes, you are correct that the voltage status is not very complex but I'd need a driver to expose these signals. -> + + + +On 04/19/2016 02:23 AM, Lee Jones wrote: + +On Mon, 18 Apr 2016, Thor Thayer wrote: + + +Hi Lee, + +On 04/18/2016 02:45 AM, Lee Jones wrote: + +On Fri, 15 Apr 2016, Thor Thayer wrote: + +On 03/30/2016 06:35 AM, Lee Jones wrote: + +On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: + + +From: Thor Thayer <ttha...@opensource.altera.com> +To: linux-hwmon@vger.kernel.org + +The Altera Arria10 Devkit System Resource chip is a Multi-Function +Device, it has two subdevices: + - GPIO + - HWMON + +This patch adds documentation for the Altera A10-SR DT bindings. + +Signed-off-by: Thor Thayer <ttha...@opensource.altera.com> +--- + .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++ + 1 file changed, 35 insertions(+) + create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt + +diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +new file mode 100644 +index 0000000..564c761 +--- /dev/null ++++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +@@ -0,0 +1,35 @@ ++* Altera Arria10 Development Kit System Resource Chip ++ ++Required parent device properties: ++- compatible : "altr,altr_a10sr" ++- spi-max-frequency : Maximum SPI frequency. ++- reg : the SPI Chip Select address for the Arria10 System Resource chip + + +[...] + + ++ a10sr_hwmon: a10sr_hwmon { + + +Device type only please. + + +I need to revisit where this will live (hwmon does not seem to be +the correct place) so it will change but I can follow the format +above if it is correct. + + +BTW, "hwmon" is a subsystem in Linux, therefore is a Linuxism and is +not allowed in DT. What does the device *actually* do? + + + +OK. I'll be careful not to introduce the Linux subsystem name. + +This module indicates whether the power supplies are at the correct +voltage. It uses a boolean instead of giving an actual voltage value +as required by HWMON. In other words it is a comparator instead of +an Analog-to-Digital Converter. + +I could call it a power supply supervisor or voltage status monitor +but it only acts in a passive role. There is no output to trigger an +error - only polling, so supervisor doesn't seem like a good name. + +Maybe something like this? + + power_supply_status { + compatible = "altr,a10sr-hwmon"; + } + +Thanks for reviewing and helping me figure out the device tree naming. + + +Does it have its own address space? How complex is the device? Not +very, by the sounds of it. In which case, does it really need its own +driver? + + +Yes, you are correct that the voltage status is not very complex but I'd need a +driver to expose these signals. + + A completely different option might be to expose the signals as gpio pins. Guenter -> I initially started with an MFD because it was similar to the other MFD drivers. The device has GPI, GPO, voltage status, device enables, device present indications, and device resets. -> -> There is a discussion now on where the voltage status driver should live (iio/ , hwmon/, misc/). It isn't clear to me where the device enables, device present indications and voltage status would go. I'm leaning toward a driver in the misc/ directory that would cover all of these. In that case, this wouldn't be a MFD driver. -> -> Any thoughts or suggestions? -> -> Thanks, -> -> Thor -> + +I initially started with an MFD because it was similar to the other MFD +drivers. The device has GPI, GPO, voltage status, device enables, device +present indications, and device resets. + +There is a discussion now on where the voltage status driver should live (iio/ +, hwmon/, misc/). It isn't clear to me where the device enables, device present +indications and voltage status would go. I'm leaning toward a driver in the +misc/ directory that would cover all of these. In that case, this wouldn't be a +MFD driver. + +Any thoughts or suggestions? + +Thanks, + +Thor + + + +-- +To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in +the body of a message to majord...@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 9df0637..d9f67ca 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,123 +1,137 @@ "ref\01459278791-3646-1-git-send-email-tthayer@opensource.altera.com\0" - "ref\01459278791-3646-2-git-send-email-tthayer@opensource.altera.com\0" - "ref\020160330113532.GI3323@x1\0" - "ref\057111E8B.1040503@opensource.altera.com\0" - "ref\020160418074540.GB3346@x1\0" - "ref\05714F942.5040309@opensource.altera.com\0" - "ref\020160419072358.GB3222@x1\0" - "ref\0571642DA.2060903@opensource.altera.com\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" "Subject\0Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings\0" - "Date\0Tue, 19 Apr 2016 18:48:35 -0700\0" - "To\0tthayer@opensource.altera.com" - " Lee Jones <lee.jones@linaro.org>\0" - "Cc\0linus.walleij@linaro.org" - gnurou@gmail.com - jdelvare@suse.com - robh+dt@kernel.org - pawel.moll@arm.com - mark.rutland@arm.com - ijc+devicetree@hellion.org.uk - dinguyen@opensource.altera.com - linux-gpio@vger.kernel.org - linux-hwmon@vger.kernel.org - " devicetree@vger.kernel.org\0" + "Date\0Tue, 19 Apr 2016 18:48:54 -0700\0" + "To\0linux-hwmon@vger.kernel.org\0" "\00:1\0" "b\0" + "\n" "On 04/19/2016 07:38 AM, Thor Thayer wrote:\n" - ">\n" - ">\n" - "> On 04/19/2016 02:23 AM, Lee Jones wrote:\n" - ">> On Mon, 18 Apr 2016, Thor Thayer wrote:\n" - ">>\n" - ">>> Hi Lee,\n" - ">>>\n" - ">>> On 04/18/2016 02:45 AM, Lee Jones wrote:\n" - ">>>> On Fri, 15 Apr 2016, Thor Thayer wrote:\n" - ">>>>> On 03/30/2016 06:35 AM, Lee Jones wrote:\n" - ">>>>>> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote:\n" - ">>>>>>\n" - ">>>>>>> From: Thor Thayer <tthayer@opensource.altera.com>\n" - ">>>>>>>\n" - ">>>>>>> The Altera Arria10 Devkit System Resource chip is a Multi-Function\n" - ">>>>>>> Device, it has two subdevices:\n" - ">>>>>>> - GPIO\n" - ">>>>>>> - HWMON\n" - ">>>>>>>\n" - ">>>>>>> This patch adds documentation for the Altera A10-SR DT bindings.\n" - ">>>>>>>\n" - ">>>>>>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>\n" - ">>>>>>> ---\n" - ">>>>>>> .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++\n" - ">>>>>>> 1 file changed, 35 insertions(+)\n" - ">>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>>>>>\n" - ">>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>>>>> new file mode 100644\n" - ">>>>>>> index 0000000..564c761\n" - ">>>>>>> --- /dev/null\n" - ">>>>>>> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" - ">>>>>>> @@ -0,0 +1,35 @@\n" - ">>>>>>> +* Altera Arria10 Development Kit System Resource Chip\n" - ">>>>>>> +\n" - ">>>>>>> +Required parent device properties:\n" - ">>>>>>> +- compatible : \"altr,altr_a10sr\"\n" - ">>>>>>> +- spi-max-frequency : Maximum SPI frequency.\n" - ">>>>>>> +- reg : the SPI Chip Select address for the Arria10 System Resource chip\n" - ">>>>\n" - ">>>> [...]\n" - ">>>>\n" - ">>>>>>> + a10sr_hwmon: a10sr_hwmon {\n" - ">>>>>>\n" - ">>>>>> Device type only please.\n" - ">>>>>>\n" - ">>>>> I need to revisit where this will live (hwmon does not seem to be\n" - ">>>>> the correct place) so it will change but I can follow the format\n" - ">>>>> above if it is correct.\n" - ">>>>\n" - ">>>> BTW, \"hwmon\" is a subsystem in Linux, therefore is a Linuxism and is\n" - ">>>> not allowed in DT. What does the device *actually* do?\n" - ">>>>\n" - ">>>\n" - ">>> OK. I'll be careful not to introduce the Linux subsystem name.\n" - ">>>\n" - ">>> This module indicates whether the power supplies are at the correct\n" - ">>> voltage. It uses a boolean instead of giving an actual voltage value\n" - ">>> as required by HWMON. In other words it is a comparator instead of\n" - ">>> an Analog-to-Digital Converter.\n" - ">>>\n" - ">>> I could call it a power supply supervisor or voltage status monitor\n" - ">>> but it only acts in a passive role. There is no output to trigger an\n" - ">>> error - only polling, so supervisor doesn't seem like a good name.\n" - ">>>\n" - ">>> Maybe something like this?\n" - ">>>\n" - ">>> power_supply_status {\n" - ">>> compatible = \"altr,a10sr-hwmon\";\n" - ">>> }\n" - ">>>\n" - ">>> Thanks for reviewing and helping me figure out the device tree naming.\n" - ">>\n" - ">> Does it have its own address space? How complex is the device? Not\n" - ">> very, by the sounds of it. In which case, does it really need its own\n" - ">> driver?\n" - ">>\n" - "> Yes, you are correct that the voltage status is not very complex but I'd need a driver to expose these signals.\n" - ">\n" + "\n" + "\n" + "\n" + "On 04/19/2016 02:23 AM, Lee Jones wrote:\n" + "\n" + "On Mon, 18 Apr 2016, Thor Thayer wrote:\n" + "\n" + "\n" + "Hi Lee,\n" + "\n" + "On 04/18/2016 02:45 AM, Lee Jones wrote:\n" + "\n" + "On Fri, 15 Apr 2016, Thor Thayer wrote:\n" + "\n" + "On 03/30/2016 06:35 AM, Lee Jones wrote:\n" + "\n" + "On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote:\n" + "\n" + "\n" + "From: Thor Thayer <ttha...@opensource.altera.com>\n" + "To: linux-hwmon@vger.kernel.org\n" + "\n" + "The Altera Arria10 Devkit System Resource chip is a Multi-Function\n" + "Device, it has two subdevices:\n" + " - GPIO\n" + " - HWMON\n" + "\n" + "This patch adds documentation for the Altera A10-SR DT bindings.\n" + "\n" + "Signed-off-by: Thor Thayer <ttha...@opensource.altera.com>\n" + "---\n" + " .../devicetree/bindings/mfd/altera-a10sr.txt | 35 ++++++++++++++++++++\n" + " 1 file changed, 35 insertions(+)\n" + " create mode 100644 Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "\n" + "diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt \n" + "b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "new file mode 100644\n" + "index 0000000..564c761\n" + "--- /dev/null\n" + "+++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt\n" + "@@ -0,0 +1,35 @@\n" + "+* Altera Arria10 Development Kit System Resource Chip\n" + "+\n" + "+Required parent device properties:\n" + "+- compatible : \"altr,altr_a10sr\"\n" + "+- spi-max-frequency : Maximum SPI frequency.\n" + "+- reg : the SPI Chip Select address for the Arria10 System Resource chip\n" + "\n" + "\n" + "[...]\n" + "\n" + "\n" + "+ a10sr_hwmon: a10sr_hwmon {\n" + "\n" + "\n" + "Device type only please.\n" + "\n" + "\n" + "I need to revisit where this will live (hwmon does not seem to be\n" + "the correct place) so it will change but I can follow the format\n" + "above if it is correct.\n" + "\n" + "\n" + "BTW, \"hwmon\" is a subsystem in Linux, therefore is a Linuxism and is\n" + "not allowed in DT. What does the device *actually* do?\n" + "\n" + "\n" + "\n" + "OK. I'll be careful not to introduce the Linux subsystem name.\n" + "\n" + "This module indicates whether the power supplies are at the correct\n" + "voltage. It uses a boolean instead of giving an actual voltage value\n" + "as required by HWMON. In other words it is a comparator instead of\n" + "an Analog-to-Digital Converter.\n" + "\n" + "I could call it a power supply supervisor or voltage status monitor\n" + "but it only acts in a passive role. There is no output to trigger an\n" + "error - only polling, so supervisor doesn't seem like a good name.\n" + "\n" + "Maybe something like this?\n" + "\n" + " power_supply_status {\n" + " compatible = \"altr,a10sr-hwmon\";\n" + " }\n" + "\n" + "Thanks for reviewing and helping me figure out the device tree naming.\n" + "\n" + "\n" + "Does it have its own address space? How complex is the device? Not\n" + "very, by the sounds of it. In which case, does it really need its own\n" + "driver?\n" + "\n" + "\n" + "Yes, you are correct that the voltage status is not very complex but I'd need a \n" + "driver to expose these signals.\n" + "\n" + "\n" "\n" "A completely different option might be to expose the signals as gpio pins.\n" "\n" "Guenter\n" "\n" - "> I initially started with an MFD because it was similar to the other MFD drivers. The device has GPI, GPO, voltage status, device enables, device present indications, and device resets.\n" - ">\n" - "> There is a discussion now on where the voltage status driver should live (iio/ , hwmon/, misc/). It isn't clear to me where the device enables, device present indications and voltage status would go. I'm leaning toward a driver in the misc/ directory that would cover all of these. In that case, this wouldn't be a MFD driver.\n" - ">\n" - "> Any thoughts or suggestions?\n" - ">\n" - "> Thanks,\n" - ">\n" - "> Thor\n" - > + "\n" + "I initially started with an MFD because it was similar to the other MFD \n" + "drivers. The device has GPI, GPO, voltage status, device enables, device \n" + "present indications, and device resets.\n" + "\n" + "There is a discussion now on where the voltage status driver should live (iio/ \n" + ", hwmon/, misc/). It isn't clear to me where the device enables, device present \n" + "indications and voltage status would go. I'm leaning toward a driver in the \n" + "misc/ directory that would cover all of these. In that case, this wouldn't be a \n" + "MFD driver.\n" + "\n" + "Any thoughts or suggestions?\n" + "\n" + "Thanks,\n" + "\n" + "Thor\n" + "\n" + "\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-hwmon\" in\n" + "the body of a message to majord...@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -82a0d5ab3e8125a721b2ef2a292c31aac46bda2e40d693b04486974a4e94e59e +99d3e536477b3a52e0ee515b7a55b21966e45fbd88130e7afa6d3dd4af75b76e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.