From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
Bob Paauwe <bob.j.paauwe@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2)
Date: Wed, 20 Apr 2016 09:00:09 +0200 [thread overview]
Message-ID: <571728F9.9050206@linux.intel.com> (raw)
In-Reply-To: <e3ab85fd-7e2f-734a-3f4e-dece61b6781e@intel.com>
Op 19-04-16 om 12:13 schreef Lionel Landwerlin:
> On 19/04/16 07:02, Maarten Lankhorst wrote:
>> Op 18-04-16 om 18:47 schreef Bob Paauwe:
>>> The i915 driver is now using atomic properties and atomic commit
>>> to handle the legacy set gamma IOCTL. However, if the driver is
>>> configured without atomic (nuclear_pageflip = false), it won't
>>> update the legacy properties for degamma_lut, gamma_lut and ctm
>>> leaving them out of sync with the atomic version of the properties.
>>>
>>> Until the driver is full atomic, make sure we update the non-atomic
>>> version of the properties.
>>>
>>> v2: Update the comment with a FIXME. (Daniel)
>>>
>> Seems to me that this is fixed by [PATCH] drm: atomic: fix legacy gamma set helper?
>> Not sure why this patch is required on top.
>>
> Daniel would prefer to have this fix only in the i915 driver as this is the last driver still transitioning to atomic.
>
Oh indeed, lack of DRIVER_ATOMIC cap again. :(
Still feels like something that doesn't belong in the driver, but ok..
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-20 7:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 16:26 [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL Bob Paauwe
2016-04-08 17:10 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-08 17:21 ` [PATCH] " Lionel Landwerlin
2016-04-08 17:58 ` Bob Paauwe
2016-04-08 17:21 ` Lionel Landwerlin
2016-04-18 16:47 ` [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2) Bob Paauwe
2016-04-19 6:02 ` Maarten Lankhorst
2016-04-19 10:13 ` Lionel Landwerlin
2016-04-20 7:00 ` Maarten Lankhorst [this message]
2016-04-20 12:38 ` Daniel Vetter
2016-05-04 13:49 ` Lionel Landwerlin
2016-05-09 6:52 ` Daniel Vetter
2016-04-19 6:05 ` Maarten Lankhorst
2016-04-19 16:20 ` Bob Paauwe
2016-04-20 6:57 ` Maarten Lankhorst
2016-04-27 15:03 ` ✗ Fi.CI.BAT: failure for drm/i915: Set legacy properties when using legacy gamma set IOCTL. (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-07-15 10:59 [PATCH] Nightly color management fixes Lionel Landwerlin
2016-07-15 13:59 ` [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2) Lionel Landwerlin
2016-07-15 16:13 ` Bob Paauwe
2016-07-18 14:27 ` Maarten Lankhorst
2016-07-18 7:50 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571728F9.9050206@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.