From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 3/3] drm/i915/guc: local optimisations and updating comments Date: Wed, 20 Apr 2016 09:39:57 +0100 Message-ID: <5717405D.7030309@linux.intel.com> References: <1461066350-32642-1-git-send-email-david.s.gordon@intel.com> <1461066350-32642-3-git-send-email-david.s.gordon@intel.com> <571649F5.2030504@linux.intel.com> <57165F19.1040205@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 035336E527 for ; Wed, 20 Apr 2016 08:39:58 +0000 (UTC) In-Reply-To: <57165F19.1040205@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA0LzE2IDE3OjM4LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAxOS8wNC8xNiAxNjow OCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uIDE5LzA0LzE2IDEyOjQ1LCBEYXZlIEdv cmRvbiB3cm90ZToKPj4+IFRpZHlpbmcgdXAgZ3VjX2luaXRfcHJvY19kZXNjKCkgYW5kIGFkZGlu ZyBjb21tZW50YXJ5IHRvIHRoZSBjbGllbnQKPj4+IHN0cnVjdHVyZSBhZnRlciB0aGUgcmVjZW50 IGNoYW5nZSBpbiBHdUMgcGFnZSBtYXBwaW5nIHN0cmF0ZWd5Lgo+Pj4KPj4+IFNpZ25lZC1vZmYt Ynk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgMzgKPj4+ICsrKysr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ndWMuaCAgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysKPj4+ICAgMiBmaWxlcyBj aGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+PiBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+Pj4gaW5kZXggMTM1ZjA5 NC4uNWJiYjEzYiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj X3N1Ym1pc3Npb24uYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3Vi bWlzc2lvbi5jCj4+PiBAQCAtMzU4LDEyICszNTgsMTQgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRf cHJvY19kZXNjKHN0cnVjdCBpbnRlbF9ndWMKPj4+ICpndWMsCj4+PiAgIHN0YXRpYyB2b2lkIGd1 Y19pbml0X2N0eF9kZXNjKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPj4+ICAgICAgICAgICAgICAg ICAgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50KQo+Pj4gICB7Cj4+PiArICAgIHN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjbGllbnRfb2JqID0gY2xpZW50LT5jbGllbnRfb2Jq Owo+Pj4gICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5 MTUoZ3VjKTsKPj4+ICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPj4+ICAg ICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHggPSBjbGllbnQtPm93bmVyOwo+Pj4gICAgICAg c3RydWN0IGd1Y19jb250ZXh0X2Rlc2MgZGVzYzsKPj4+ICAgICAgIHN0cnVjdCBzZ190YWJsZSAq c2c7Cj4+PiAgICAgICBlbnVtIGludGVsX2VuZ2luZV9pZCBpZDsKPj4+ICsgICAgdTMyIGdmeF9h ZGRyOwo+Pj4KPj4+ICAgICAgIG1lbXNldCgmZGVzYywgMCwgc2l6ZW9mKGRlc2MpKTsKPj4+Cj4+ PiBAQCAtMzkyLDE2ICszOTQsMTcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3Ry dWN0IGludGVsX2d1Ywo+Pj4gKmd1YywKPj4+ICAgICAgICAgICBscmMtPmNvbnRleHRfZGVzYyA9 ICh1MzIpY3R4X2Rlc2M7Cj4+Pgo+Pj4gICAgICAgICAgIC8qIFRoZSBzdGF0ZSBwYWdlIGlzIGFm dGVyIFBQSFdTUCAqLwo+Pj4gLSAgICAgICAgbHJjLT5yaW5nX2xjcmEgPSBpOTE1X2dlbV9vYmpf Z2d0dF9vZmZzZXQob2JqKSArCj4+PiAtICAgICAgICAgICAgICAgIExSQ19TVEFURV9QTiAqIFBB R0VfU0laRTsKPj4+ICsgICAgICAgIGdmeF9hZGRyID0gaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0 KG9iaik7Cj4+PiArICAgICAgICBscmMtPnJpbmdfbGNyYSA9IGdmeF9hZGRyICsgTFJDX1NUQVRF X1BOICogUEFHRV9TSVpFOwo+Pj4gICAgICAgICAgIGxyYy0+Y29udGV4dF9pZCA9IChjbGllbnQt PmN0eF9pbmRleCA8PAo+Pj4gR1VDX0VMQ19DVFhJRF9PRkZTRVQpIHwKPj4+ICAgICAgICAgICAg ICAgICAgIChlbmdpbmUtPmd1Y19pZCA8PCBHVUNfRUxDX0VOR0lORV9PRkZTRVQpOwo+Pj4KPj4+ ICAgICAgICAgICBvYmogPSBjdHgtPmVuZ2luZVtpZF0ucmluZ2J1Zi0+b2JqOwo+Pj4gKyAgICAg ICAgZ2Z4X2FkZHIgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKPj4+Cj4+PiAtICAg ICAgICBscmMtPnJpbmdfYmVnaW4gPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKPj4+ IC0gICAgICAgIGxyYy0+cmluZ19lbmQgPSBscmMtPnJpbmdfYmVnaW4gKyBvYmotPmJhc2Uuc2l6 ZSAtIDE7Cj4+PiAtICAgICAgICBscmMtPnJpbmdfbmV4dF9mcmVlX2xvY2F0aW9uID0gbHJjLT5y aW5nX2JlZ2luOwo+Pj4gKyAgICAgICAgbHJjLT5yaW5nX2JlZ2luID0gZ2Z4X2FkZHI7Cj4+PiAr ICAgICAgICBscmMtPnJpbmdfZW5kID0gZ2Z4X2FkZHIgKyBvYmotPmJhc2Uuc2l6ZSAtIDE7Cj4+ PiArICAgICAgICBscmMtPnJpbmdfbmV4dF9mcmVlX2xvY2F0aW9uID0gZ2Z4X2FkZHI7Cj4+PiAg ICAgICAgICAgbHJjLT5yaW5nX2N1cnJlbnRfdGFpbF9wb2ludGVyX3ZhbHVlID0gMDsKPj4+Cj4+ PiAgICAgICAgICAgZGVzYy5lbmdpbmVzX3VzZWQgfD0gKDEgPDwgZW5naW5lLT5ndWNfaWQpOwo+ Pj4gQEAgLTQxMCwyMiArNDEzLDE3IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X2N0eF9kZXNjKHN0 cnVjdCBpbnRlbF9ndWMKPj4+ICpndWMsCj4+PiAgICAgICBXQVJOX09OKGRlc2MuZW5naW5lc191 c2VkID09IDApOwo+Pj4KPj4+ICAgICAgIC8qCj4+PiAtICAgICAqIFRoZSBDUFUgYWRkcmVzcyBp cyBvbmx5IG5lZWRlZCBhdCBjZXJ0YWluIHBvaW50cywgc28KPj4+IGttYXBfYXRvbWljIG9uCj4+ PiAtICAgICAqIGRlbWFuZCBpbnN0ZWFkIG9mIHN0b3JpbmcgaXQgaW4gdGhlIGN0eCBkZXNjcmlw dG9yLgo+Pj4gLSAgICAgKiBYWFg6IE1heSBtYWtlIGRlYnVnIGVhc2llciB0byBoYXZlIGl0IG1h cHBlZAo+Pj4gKyAgICAgKiBUaGUgZG9vcmJlbGwsIHByb2Nlc3MgZGVzY3JpcHRvciwgYW5kIHdv cmtxdWV1ZSBhcmUgYWxsIHBhcnRzCj4+PiArICAgICAqIG9mIHRoZSBjbGllbnQgb2JqZWN0LCB3 aGljaCB0aGUgR3VDIHdpbGwgcmVmZXJlbmNlIHZpYSB0aGUgR0dUVAo+Pj4gICAgICAgICovCj4+ PiAtICAgIGRlc2MuZGJfdHJpZ2dlcl9jcHUgPSAwOwo+Pj4gLSAgICBkZXNjLmRiX3RyaWdnZXJf dWsgPSBjbGllbnQtPmRvb3JiZWxsX29mZnNldCArCj4+PiAtICAgICAgICBpOTE1X2dlbV9vYmpf Z2d0dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKPj4+IC0gICAgZGVzYy5kYl90cmlnZ2Vy X3BoeSA9IGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0ICsKPj4+IC0gICAgICAgIHNnX2RtYV9hZGRy ZXNzKGNsaWVudC0+Y2xpZW50X29iai0+cGFnZXMtPnNnbCk7Cj4+PiAtCj4+PiAtICAgIGRlc2Mu cHJvY2Vzc19kZXNjID0gY2xpZW50LT5wcm9jX2Rlc2Nfb2Zmc2V0ICsKPj4+IC0gICAgICAgIGk5 MTVfZ2VtX29ial9nZ3R0X29mZnNldChjbGllbnQtPmNsaWVudF9vYmopOwo+Pj4gLQo+Pj4gLSAg ICBkZXNjLndxX2FkZHIgPSBjbGllbnQtPndxX29mZnNldCArCj4+PiAtICAgICAgICBpOTE1X2dl bV9vYmpfZ2d0dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKPj4+IC0KPj4+ICsgICAgZ2Z4 X2FkZHIgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQoY2xpZW50X29iaik7Cj4+PiArICAgIGRl c2MuZGJfdHJpZ2dlcl9waHkgPSBzZ19kbWFfYWRkcmVzcyhjbGllbnRfb2JqLT5wYWdlcy0+c2ds KSArCj4+PiArICAgICAgICAgICAgICAgIGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0Owo+Pj4gKyAg ICBkZXNjLmRiX3RyaWdnZXJfY3B1ID0gKHVpbnRwdHJfdCljbGllbnQtPmNsaWVudF9iYXNlICsK Pj4+ICsgICAgICAgICAgICAgICAgY2xpZW50LT5kb29yYmVsbF9vZmZzZXQ7Cj4+Cj4+IFRoaXMg Y2hhbmdlZCBmcm9tIHplcm8gdG8gdGhlIGFkZHJlc3MuIFdhcyBpdCBidWdneSBiZWZvcmU/Cj4K PiBJdCdzIG5vdCBhY3R1YWxseSB1c2VkLCBBRkFJQ1QsIGJ1dCB3ZSBtaWdodCBhcyB3ZWxsIHNl dCBpdCB0byB0aGUKPiBjb3JyZWN0IHZhbHVlIGFueXdheSAtIHRoaXMgZGF0YSBpcyBzaGFyZWQg d2l0aCB0aGUgR3VDLCBzbyBJJ2QgbGlrZSB0aGUKPiB2YWx1ZXMgdG8gYmUgYXMgY29tcGxldGUg YW5kIGNvcnJlY3QgYXMgcG9zc2libGUsIGluIGNhc2UgdGhlIEd1Qwo+IGZpcm13YXJlIGV2ZXIg c3RhcnRzIG1ha2luZyB1c2Ugb2YgdGhlbS4gQW5kIG1heWJlIHdlIGNvdWxkIHVzZSB0aGlzIGZv cgo+IGNvbnNpc3RlbmN5IGNoZWNraW5nIGlmIHdlIGV2ZXIgZm91bmQgbXlzdGVyaW91cyBwYWdl IGZhdWx0cyBpbiB0aGUKPiBkb29yYmVsbCBjb2RlLiBCdXQgcmVhbGx5IGl0J3MganVzdCB0byBz aG93IHRoYXQgdGhlc2UgdGhyZWUgZmllbGRzIGFsbAo+IGRlc2NyaWJlIHRoZSBzYW1lIHRoaW5n LCBuYW1lbHkgd2hlcmUgdG8gcmluZyB0aGUgZG9vcmJlbGwsIGluIHBoeXNpY2FsCj4gKERNQSks IGtlcm5lbCwgYW5kIEdHVFQgYWRkcmVzcyBzcGFjZXMuCgpHb3QgaXQsIGluIHRoYXQgY2FzZToK ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK