From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-clk-owner@vger.kernel.org>
Received: from mail-wm0-f46.google.com ([74.125.82.46]:38823 "EHLO
	mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932445AbcDTIoF (ORCPT
	<rfc822;linux-clk@vger.kernel.org>); Wed, 20 Apr 2016 04:44:05 -0400
Received: by mail-wm0-f46.google.com with SMTP id u206so69006582wme.1
        for <linux-clk@vger.kernel.org>; Wed, 20 Apr 2016 01:44:04 -0700 (PDT)
Subject: Re: [PATCH v2 1/2] clk: Add Oxford Semiconductor OXNAS Standard
 Clocks
To: Stephen Boyd <sboyd@codeaurora.org>
References: <1460973696-5977-1-git-send-email-narmstrong@baylibre.com>
 <1460973696-5977-2-git-send-email-narmstrong@baylibre.com>
 <20160419212944.GF15324@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org
From: Neil Armstrong <narmstrong@baylibre.com>
Message-ID: <57174151.8040806@baylibre.com>
Date: Wed, 20 Apr 2016 10:44:01 +0200
MIME-Version: 1.0
In-Reply-To: <20160419212944.GF15324@codeaurora.org>
Content-Type: text/plain; charset=windows-1252
Sender: linux-clk-owner@vger.kernel.org
List-ID: <linux-clk.vger.kernel.org>

Hi Stephen,

On 04/19/2016 11:29 PM, Stephen Boyd wrote:
> On 04/18, Neil Armstrong wrote:
>> +
>> +static int oxnas_stdclk_probe(struct platform_device *pdev)
>> +{
>> +	struct device_node *np = pdev->dev.of_node;
>> +	struct clk_oxnas_data *clk_oxnas;
>> +	struct regmap *regmap;
>> +	int i;
>> +
>> +	clk_oxnas = devm_kzalloc(&pdev->dev, sizeof(*clk_oxnas), GFP_KERNEL);
>> +	if (!clk_oxnas)
>> +		return -ENOMEM;
>> +
>> +	regmap = syscon_node_to_regmap(of_get_parent(np));
>> +	if (!regmap) {
>> +		dev_err(&pdev->dev, "failed to have parent regmap\n");
>> +		return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
>> +		struct clk_oxnas *_clk;
>> +
>> +		if (!clk_oxnas_init[i].clk_init)
>> +			continue;
> 
> New design is fine, really it's up to you, but then this check
> isn't needed anymore, right?
> 

it's not needed for sure, but do I need to send a v3 to remove this ?

Neil

From mboxrd@z Thu Jan  1 00:00:00 1970
From: narmstrong@baylibre.com (Neil Armstrong)
Date: Wed, 20 Apr 2016 10:44:01 +0200
Subject: [PATCH v2 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks
In-Reply-To: <20160419212944.GF15324@codeaurora.org>
References: <1460973696-5977-1-git-send-email-narmstrong@baylibre.com>
 <1460973696-5977-2-git-send-email-narmstrong@baylibre.com>
 <20160419212944.GF15324@codeaurora.org>
Message-ID: <57174151.8040806@baylibre.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Stephen,

On 04/19/2016 11:29 PM, Stephen Boyd wrote:
> On 04/18, Neil Armstrong wrote:
>> +
>> +static int oxnas_stdclk_probe(struct platform_device *pdev)
>> +{
>> +	struct device_node *np = pdev->dev.of_node;
>> +	struct clk_oxnas_data *clk_oxnas;
>> +	struct regmap *regmap;
>> +	int i;
>> +
>> +	clk_oxnas = devm_kzalloc(&pdev->dev, sizeof(*clk_oxnas), GFP_KERNEL);
>> +	if (!clk_oxnas)
>> +		return -ENOMEM;
>> +
>> +	regmap = syscon_node_to_regmap(of_get_parent(np));
>> +	if (!regmap) {
>> +		dev_err(&pdev->dev, "failed to have parent regmap\n");
>> +		return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < ARRAY_SIZE(clk_oxnas_init); i++) {
>> +		struct clk_oxnas *_clk;
>> +
>> +		if (!clk_oxnas_init[i].clk_init)
>> +			continue;
> 
> New design is fine, really it's up to you, but then this check
> isn't needed anymore, right?
> 

it's not needed for sure, but do I need to send a v3 to remove this ?

Neil