From: Olliver Schinagl <oliver@schinagl.nl>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Richard Purdie <rpurdie@rpsys.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups
Date: Wed, 20 Apr 2016 11:06:42 +0200 [thread overview]
Message-ID: <571746A2.8040609@schinagl.nl> (raw)
In-Reply-To: <CAPybu_3=VdXR_X_00EiYMyhRPLsR40GW1kHS5rzdOkSzrCMVWg@mail.gmail.com>
On 20-04-16 10:56, Ricardo Ribalda Delgado wrote:
> Hi
>
> On Wed, Apr 20, 2016 at 10:51 AM, Olliver Schinagl <oliver@schinagl.nl> wrote:
>
>>> As I said before, the reason for this proposal is that the code NEVER
>>> clears PCA963X_MODE2_DMBLNK, only sets it.
>>> Unfortunately I do not have the HW to test this change.
>> The code never clears it, but the hardware does. So we have to set it
>> everytime we enable blink.
> Ok, that was the part I was missing. I was not aware that the hw was
> clearing it.
The devil is in the details :)
> Saving mode2 sounds like a good compromise then.
>
> But I still believe that we should limit the lock to ledout. No matter
> what we do, we cannot have two leds blinking at different frequencies
> on the same chip.
So to save a mutex a little bit, we take the risk that nobody else
enables the blink or if they do, enable it in the same way?
If it saves so much, then I guess its worth the risk I suppose?
>
>
> Regards
>
next prev parent reply other threads:[~2016-04-20 9:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 7:40 [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Olliver Schinagl
2016-04-19 7:40 ` [PATCH 1/6] leds: pca963x: Alphabetize headers Olliver Schinagl
2016-04-19 7:40 ` [PATCH 2/6] leds: pca963x: Lock i2c r/w access Olliver Schinagl
2016-04-19 7:40 ` [PATCH 3/6] leds: pca963x: Add defines and remove some magic values Olliver Schinagl
2016-04-19 8:16 ` kbuild test robot
2016-04-19 8:16 ` kbuild test robot
2016-04-19 7:40 ` [PATCH 4/6] leds: pca963x: Reduce " Olliver Schinagl
2016-04-19 7:40 ` [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl
2016-04-21 15:07 ` Rob Herring
2016-04-22 12:38 ` Olliver Schinagl
2016-04-22 13:09 ` Rob Herring
2016-04-22 15:44 ` Olliver Schinagl
2016-04-19 7:40 ` [PATCH 6/6] leds: pca963x: Remove whitespace and checkpatch problems Olliver Schinagl
2016-04-19 9:23 ` [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Jacek Anaszewski
2016-04-19 9:39 ` Olliver Schinagl
[not found] ` <5715FCE8.7080106-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2016-04-19 11:18 ` Ricardo Ribalda Delgado
2016-04-19 11:18 ` Ricardo Ribalda Delgado
2016-04-19 13:27 ` Olliver Schinagl
[not found] ` <57163252.5090000-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2016-04-19 13:42 ` Ricardo Ribalda Delgado
2016-04-19 13:42 ` Ricardo Ribalda Delgado
2016-04-20 7:21 ` Olliver Schinagl
2016-04-20 8:01 ` Ricardo Ribalda Delgado
2016-04-20 8:51 ` Olliver Schinagl
[not found] ` <5717430D.30702-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2016-04-20 8:56 ` Ricardo Ribalda Delgado
2016-04-20 8:56 ` Ricardo Ribalda Delgado
2016-04-20 9:06 ` Olliver Schinagl [this message]
2016-04-20 9:17 ` Ricardo Ribalda Delgado
2016-04-20 10:12 ` Olliver Schinagl
2016-04-22 7:21 ` Olliver Schinagl
2016-05-12 9:04 ` Olliver Schinagl
2016-05-12 9:07 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571746A2.8040609@schinagl.nl \
--to=oliver@schinagl.nl \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=ricardo.ribalda@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.