From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
roopa@cumulusnetworks.com, tgraf@suug.ch, jhs@mojatatu.com
Subject: Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()
Date: Wed, 20 Apr 2016 12:14:56 +0200 [thread overview]
Message-ID: <571756A0.3030200@6wind.com> (raw)
In-Reply-To: <1461146278.10638.253.camel@edumazet-glaptop3.roam.corp.google.com>
Le 20/04/2016 11:57, Eric Dumazet a écrit :
> On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote:
>> Le 20/04/2016 11:33, Eric Dumazet a écrit :
>> [snip]
>>> How have you tested your patch exactly ?
>> As stated in the cover letter, I didn't test it.
>
>
> You certainly can test this, by tweaking HAVE_EFFICIENT_UNALIGNED_ACCESS
> and adding another assertion in the code.
>
> By testing it you would have caught a real bug, since David incorrectly
> used HAVE_EFFICIENT_UNALIGNED_ACCESS instead of
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>
> ;)
Héhé, good catch :)
next prev parent reply other threads:[~2016-04-20 10:14 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 21:10 [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-18 21:35 ` Eric Dumazet
2016-04-19 0:57 ` David Miller
2016-04-19 1:48 ` David Miller
2016-04-19 2:22 ` Eric Dumazet
2016-04-19 2:40 ` Roopa Prabhu
2016-04-19 3:49 ` David Miller
2016-04-19 3:52 ` David Miller
2016-04-19 10:09 ` Johannes Berg
2016-04-19 10:48 ` Emmanuel Grumbach
2016-04-19 18:23 ` David Miller
2016-04-19 19:41 ` Johannes Berg
2016-04-20 1:53 ` David Ahern
2016-04-20 7:32 ` Johannes Berg
2016-04-20 12:48 ` Jiri Benc
2016-04-20 13:17 ` Johannes Berg
2016-04-20 13:34 ` Jiri Benc
2016-04-20 20:13 ` Johannes Berg
2016-04-19 2:30 ` roopa
2016-04-19 3:41 ` David Miller
2016-04-19 4:17 ` Eric Dumazet
2016-04-19 4:32 ` Eric Dumazet
2016-04-19 5:03 ` David Miller
2016-04-19 18:31 ` David Miller
2016-04-19 18:45 ` Eric Dumazet
2016-04-19 18:47 ` Eric Dumazet
2016-04-19 19:08 ` Nicolas Dichtel
2016-04-19 23:50 ` David Miller
2016-04-20 3:54 ` Roopa Prabhu
2016-04-20 8:57 ` [PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit() Nicolas Dichtel
2016-04-20 9:33 ` Eric Dumazet
2016-04-20 9:44 ` Nicolas Dichtel
2016-04-20 9:57 ` Eric Dumazet
2016-04-20 10:14 ` Nicolas Dichtel [this message]
2016-04-20 14:31 ` [PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos Eric Dumazet
2016-04-20 15:03 ` David Miller
2016-04-20 8:57 ` [PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 3/4] ipmr: align RTA_MFC_STATS " Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 1/4] libnl: add more helpers to align attributes on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 2/4] rtnl: use the new API to align IFLA_STATS* Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 3/4] ipmr: align RTA_MFC_STATS on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 18:28 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute David Miller
2016-04-21 22:00 ` Nicolas Dichtel
2016-04-22 5:31 ` David Miller
2016-04-19 19:05 ` [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-19 22:49 ` David Miller
2016-04-20 3:53 ` Roopa Prabhu
2016-04-19 4:43 ` Roopa Prabhu
2016-04-19 7:45 ` Nicolas Dichtel
2016-04-19 16:00 ` David Miller
2016-04-19 8:26 ` Nicolas Dichtel
2016-04-19 19:55 ` Paul Moore
2016-04-19 20:40 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571756A0.3030200@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.