From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <jbeulich@suse.com>, tamas@tklengyel.com
Cc: andrew.cooper3@citrix.com, keir@xen.org,
stefano.stabellini@citrix.com, rcojocaru@bitdefender.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] monitor: Rename vm_event_monitor_get_capabilities to arch_monitor_get_capabilities
Date: Wed, 20 Apr 2016 12:31:22 +0100 [thread overview]
Message-ID: <5717688A.2060707@arm.com> (raw)
In-Reply-To: <5717758C02000078000E6F00@prv-mh.provo.novell.com>
Hi Jan,
On 20/04/16 12:26, Jan Beulich wrote:
>>>> Tamas K Lengyel <tamas@tklengyel.com> 04/14/16 6:34 PM >>>
>> +static inline uint32_t arch_monitor_get_capabilities(struct domain *d)
>> +{
>> + uint32_t capabilities = 0;
>
> Pointless initializer.
>
>> + capabilities = (1U << XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST);
>> +
>> + return capabilities;
>> +}
>
> Even more - the entire function body could be just a single return statement.
Your comments are valid, however this patch is only code movements. If
you want the code to be fixed, then it should be a separate patch.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-20 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 16:33 [PATCH] monitor: Rename vm_event_monitor_get_capabilities to arch_monitor_get_capabilities Tamas K Lengyel
2016-04-14 16:36 ` Andrew Cooper
2016-04-14 17:01 ` Tamas K Lengyel
2016-04-14 16:44 ` Razvan Cojocaru
2016-04-20 10:34 ` Julien Grall
2016-04-20 11:26 ` Jan Beulich
2016-04-20 11:31 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717688A.2060707@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.