Re: [PATCH mesa v2 1/2] nouveau: codegen: Use FILE_MEMORY_BUFFER for buffers

[Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi,

On 15-04-16 00:29, Samuel Pitoiset wrote:
>
>
> On 04/12/2016 12:04 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 08-04-16 18:14, Samuel Pitoiset wrote:
>>>
>>>
>>> On 04/08/2016 12:17 PM, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>> On 23-03-16 23:10, Samuel Pitoiset wrote:
>>>>> Are you sure this won't break compute shaders on fermi?
>>>>> Could you please double-check that?
>>>>
>>>> I just checked:
>>>>
>>>> lspci:
>>>> 01:00.0 VGA compatible controller: NVIDIA Corporation GF119 [GeForce GT
>>>> 610] (rev a1)
>>>>
>>>> Before this patch-set:
>>>>
>>>> [hans@plank piglit]$ ./piglit run -o shader -t
>>>> '.*arb_shader_storage_buffer_object.*' results/shader
>>>> [9/9] pass: 9 /
>>>>
>>>> After this patch-set:
>>>>
>>>> [hans@plank piglit]$ ./piglit run -o shader -t
>>>> '.*arb_shader_storage_buffer_object.*' results/shader
>>>> [9/9] pass: 9 /
>>>
>>> And what about compute shaders? (ie. -t arb_compute_shader)
>>> Sorry to ask you again but I just want to be sure it's fine. :-)
>>
>> Those tests don't run yet on mesa master on the GF119 card
>> I've:
>>
>> [hans@plank piglit]$ ./piglit run -o shader -t '.*arb_compute_shader.*'
>> results/shader
>> [20/20] skip: 20 |
>>
>> My patches don't change anything about this, and they only touch
>> the buffer handling paths and the buffer tests (still) pass...
>>
>> I've also tried on a:
>> 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GT
>> 740] (rev a1)
>>
>> Same result.
>
> Sorry for the delay, I was dealing with images.
>
> Well, you needed to override ARB_compute_shader because the extension is not currently exposed.
>
> For example:
> MESA_EXTENSION_OVERRIDE=GL_ARB_compute_shader MESA_GL_VERSION_OVERRIDE=4.2 ./piglit-run.py blabla
>
> I tried myself to test your series but it no longer applies on top of master. Well, if you make a quick test with:
>
> MESA_EXTENSION_OVERRIDE=GL_ARB_compute_shader MESA_GL_VERSION_OVERRIDE=4.2 ./piglit-run.py -1 --dmesg -t arb_compute_shader
>
> that might be nice

Done on both a gf119 and gk107, result on both:

[hans@plank piglit]$ DISPLAY=:0 MESA_EXTENSION_OVERRIDE=GL_ARB_compute_shader MESA_GL_VERSION_OVERRIDE=4.2  ./piglit run -o shader -t '.*arb_compute_shader.*' results/shader
[20/20] skip: 4, pass: 16 |
Thank you for running Piglit!

 > but whatever, series is:
>
> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

Thanks, I've updated the commit msg with the results of the extra tests
I've done and pushed these 2 patches to master.

Regards,

Hans
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau