All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Steve Kemp via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Steve Kemp <steve@steve.org.uk>
Subject: Re: [PATCH] comment: fix spelling mistakes inside comments
Date: Wed, 29 Jul 2020 09:45:21 -0400	[thread overview]
Message-ID: <571792b3-e65b-e6e8-34b9-56a87a47de8d@gmail.com> (raw)
In-Reply-To: <pull.685.git.1595993608886.gitgitgadget@gmail.com>

On 7/28/20 11:33 PM, Steve Kemp via GitGitGadget wrote:
> From: Steve Kemp <steve@steve.org.uk>
> 
> This commit fixes a couple of minor spelling mistakes inside
> comments.
> 
> Signed-off-by: Steve Kemp <steve@steve.fi>
> Signed-off-by: Steve Kemp <steve@steve.org.uk>

Double sign-off? Perhaps keep the org.uk version, since that
is the email you use for authorship.

> -			/* abandonded */
> +			/* abandoned */

> -/* Print a cell to stdout with all necessary leading/traling space */
> +/* Print a cell to stdout with all necessary leading/trailing space */

> -		 * currenty thread-safe and might be racy with object reading,
> +		 * currently thread-safe and might be racy with object reading,

> - * 1. Only a single level of inderection is obtained, we might want to
> + * 1. Only a single level of indirection is obtained, we might want to

These edits are all positive ones.

I'll leave it to more experienced contributors to comment on how a
comment-only patch fits with this section Documentation/CodingGuidelines:

 - Fixing style violations while working on a real change as a
   preparatory clean-up step is good, but otherwise avoid useless code
   churn for the sake of conforming to the style.

In my opinion, this change is not harmful, but also isn't super
necessary. I could go either way.

Thanks,
-Stolee

  reply	other threads:[~2020-07-29 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  3:33 [PATCH] comment: fix spelling mistakes inside comments Steve Kemp via GitGitGadget
2020-07-29 13:45 ` Derrick Stolee [this message]
2020-07-29 18:12   ` Steve Kemp
2020-07-29 18:16   ` Junio C Hamano
2020-07-29 19:19     ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571792b3-e65b-e6e8-34b9-56a87a47de8d@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=steve@steve.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.