From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: santiago@nyu.edu
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] tag.c: remove extern keyword from function definition
Date: Wed, 20 Apr 2016 16:34:25 +0100 [thread overview]
Message-ID: <5717A181.1000603@ramsayjones.plus.com> (raw)
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Santiago,
If you need to re-roll your 'st/verify-tag' branch, could you
please squash this into the relevant patch (commit c5213b40,
"verify-tag: move tag verification code to tag.c", 19-04-2016).
Although not actually an error, it is very unusual for an extern
keyword to be used on a function definition (it seems to be getting
quite unusual on a function declaration these days!), which causes
sparse to issue a warning.
Thanks!
ATB,
Ramsay Jones
tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tag.c b/tag.c
index ace619a..93c6ae6 100644
--- a/tag.c
+++ b/tag.c
@@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
return ret;
}
-extern int gpg_verify_tag(const unsigned char *sha1,
+int gpg_verify_tag(const unsigned char *sha1,
const char *name_to_report, unsigned flags)
{
enum object_type type;
--
2.8.0
next reply other threads:[~2016-04-20 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 15:34 Ramsay Jones [this message]
2016-04-20 15:39 ` [PATCH] tag.c: remove extern keyword from function definition Santiago Torres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717A181.1000603@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.