From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6A4BBE00F0D; Wed, 20 Apr 2016 12:00:43 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.94.94.41 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E1076E007D2 for ; Wed, 20 Apr 2016 12:00:12 -0700 (PDT) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id u3KJ0BnQ031284 for ; Wed, 20 Apr 2016 14:00:11 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3KJ0Bqu029955 for ; Wed, 20 Apr 2016 14:00:11 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Wed, 20 Apr 2016 14:00:09 -0500 Received: from [10.218.109.201] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3KJ07Jl026815; Wed, 20 Apr 2016 14:00:08 -0500 Message-ID: <5717D1B8.9050709@ti.com> Date: Wed, 20 Apr 2016 15:00:08 -0400 From: Jacob Stiffler User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Justin Sobota , References: <1461177987-495-1-git-send-email-jsobota@ti.com> In-Reply-To: <1461177987-495-1-git-send-email-jsobota@ti.com> Subject: Re: [master/fido][PATCH 1/2] ipc-transport: Clean up recipe X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 19:00:43 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 4/20/2016 2:46 PM, Justin Sobota wrote: > Signed-off-by: Justin Sobota > --- > recipes-ti/ipc/ipc-transport-qmss.inc | 4 +++- > recipes-ti/ipc/ipc-transport-srio.inc | 4 +++- > recipes-ti/ipc/ipc-transport.inc | 14 ++++++++------ > 3 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/recipes-ti/ipc/ipc-transport-qmss.inc b/recipes-ti/ipc/ipc-transport-qmss.inc > index a5c8dc4..7539ef5 100644 > --- a/recipes-ti/ipc/ipc-transport-qmss.inc > +++ b/recipes-ti/ipc/ipc-transport-qmss.inc > @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause" > > require ipc-transport.inc > > -INC_PR_append = ".0" > +PR = "${INC_PR}.1" PR should be specified in the recipe file. > + > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02" > > COMPATIBLE_MACHINE = "keystone" > > diff --git a/recipes-ti/ipc/ipc-transport-srio.inc b/recipes-ti/ipc/ipc-transport-srio.inc > index 4b5c305..18b94d1 100644 > --- a/recipes-ti/ipc/ipc-transport-srio.inc > +++ b/recipes-ti/ipc/ipc-transport-srio.inc > @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause" > > require ipc-transport.inc > > -INC_PR_append = ".0" > +PR = "${INC_PR}.1" > + > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02" Why not keep this in the original location? This appears to be duplicated in these intermediate .inc files. > > COMPATIBLE_MACHINE = "k2hk-evm" > > diff --git a/recipes-ti/ipc/ipc-transport.inc b/recipes-ti/ipc/ipc-transport.inc > index 4ba3670..705dfb4 100644 > --- a/recipes-ti/ipc/ipc-transport.inc > +++ b/recipes-ti/ipc/ipc-transport.inc > @@ -1,15 +1,17 @@ > -LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02" > +LICENSE = "BSD-3-Clause" > + > +PACKAGE_ARCH = "${MACHINE_ARCH}" What makes these .inc file machine-specific? > > IPC_TRANSPORT_GIT_URI = "git://git.ti.com/keystone-linux/ipc-transport.git" > -IPC_TRANSPORT_GIT_BRANCH = "master" > IPC_TRANSPORT_GIT_PROTOCOL = "git" > +IPC_TRANSPORT_GIT_BRANCH = "master" > > -# Below commit ID corresponds to DEV.IPC-TRANSPORT.02.00.00.01 > +# Below commit ID corresponds to "DEV.IPC-TRANSPORT.02.00.00.01" > IPC_TRANSPORT_SRCREV = "88ea336c584ccec4b2c281cd7f75df9dff6d4edf" > > -BRANCH="${IPC_TRANSPORT_GIT_BRANCH}" > +BRANCH = "${IPC_TRANSPORT_GIT_BRANCH}" > SRC_URI = "${IPC_TRANSPORT_GIT_URI};protocol=${IPC_TRANSPORT_GIT_PROTOCOL};branch=${BRANCH}" > + > SRCREV = "${IPC_TRANSPORT_SRCREV}" > PV = "02.00.00.01" > - > -INC_PR = "r1" > +INC_PR = "r2"