From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at6x9-0005Ef-Vf for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at6x5-0003P3-Vh for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:14:59 -0400 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:35803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at6x5-0003Ox-Ku for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:14:55 -0400 Received: by mail-pa0-x234.google.com with SMTP id fs9so25316424pac.2 for ; Wed, 20 Apr 2016 22:14:55 -0700 (PDT) References: <1461119601-4936-1-git-send-email-david@gibson.dropbear.id.au> <1461119601-4936-8-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <571861C8.3060702@ozlabs.ru> Date: Thu, 21 Apr 2016 15:14:48 +1000 MIME-Version: 1.0 In-Reply-To: <1461119601-4936-8-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC for-2.7 07/11] pseries: Move adding of fdt reserve map entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, crosthwaite.peter@gmail.com Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 04/20/2016 12:33 PM, David Gibson wrote: > The flattened device tree passed to pseries guests contains a list of > reserved memory areas. Currently we construct this list early in > spapr_build_fdt() as we sequentially write out the fdt. > > This will be inconvenient for upcoming cleanups, so this patch moves > the reserve map changes to the end of fdt construction. This changes > fdt_add_reservemap_entry() calls - which work when writing the fdt > sequentially to fdt_add_mem_rsv() calls used when altering the fdt in > random access mode. Looks to me like the real reason for this move is that new qdt_setprop_xxx API does not support memory reserve map yet. Will it, when? In general, when do you plan to get rid of _FDT()? Anyway, Reviewed-by: Alexey Kardashevskiy > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 5356f4d..aef44a2 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -733,14 +733,6 @@ static void *spapr_build_fdt(sPAPRMachineState *spapr, > fdt = g_malloc0(FDT_MAX_SIZE); > _FDT((fdt_create(fdt, FDT_MAX_SIZE))); > > - if (spapr->kernel_size) { > - _FDT((fdt_add_reservemap_entry(fdt, KERNEL_LOAD_ADDR, > - spapr->kernel_size))); > - } > - if (spapr->initrd_size) { > - _FDT((fdt_add_reservemap_entry(fdt, spapr->initrd_base, > - spapr->initrd_size))); > - } > _FDT((fdt_finish_reservemap(fdt))); > > /* Root node */ > @@ -976,6 +968,15 @@ static void *spapr_build_fdt(sPAPRMachineState *spapr, > } > > g_free(bootlist); > + > + /* Build memory reserve map */ > + if (spapr->kernel_size) { > + _FDT((fdt_add_mem_rsv(fdt, KERNEL_LOAD_ADDR, spapr->kernel_size))); > + } > + if (spapr->initrd_size) { > + _FDT((fdt_add_mem_rsv(fdt, spapr->initrd_base, spapr->initrd_size))); > + } > + > return fdt; > } > > -- Alexey