From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86emul: special case far branch validation outside of long mode
Date: Thu, 21 Apr 2016 09:36:06 +0100 [thread overview]
Message-ID: <571890F6.6040109@citrix.com> (raw)
In-Reply-To: <56E2F9E102000078000DBAD6@prv-mh.provo.novell.com>
On 11/03/16 16:01, Jan Beulich wrote:
> In that case (with the new value being held in, or now in one case cast
> to, a 32-bit variable) there's no need to go through the long mode part
> of the checks.
>
> Primarily this was meant to hopefully address Coverity ID 1355278, but
> since the change produces smaller code as well I think we should use it
> even if it doesn't help that (benign) warning.
>
> Also it's more in line with jmp_rel() for commit_far_branch() to do the
> _regs.eip update, so adjust that at once.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-21 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 16:01 [PATCH] x86emul: special case far branch validation outside of long mode Jan Beulich
2016-04-21 8:36 ` Andrew Cooper [this message]
2016-04-21 8:55 ` Jan Beulich
2016-04-22 10:07 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571890F6.6040109@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.