From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: Re: [PATCH] md-cluster: fix ifnullfree.cocci warnings Date: Thu, 21 Apr 2016 17:10:01 +0800 Message-ID: <571898E9.1020505@suse.com> References: <201604211452.TEhZl8El%fengguang.wu@intel.com> <20160421070035.GA210949@ivytown2> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160421070035.GA210949@ivytown2> Sender: linux-raid-owner@vger.kernel.org To: kbuild test robot Cc: kbuild-all@01.org, shli@kernel.org, neilb@suse.de, linux-raid@vger.kernel.org List-Id: linux-raid.ids On 04/21/2016 03:00 PM, kbuild test robot wrote: > drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. Oops, I missed it. Acked-by: Guoqing Jiang Thanks, Guoqing > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Guoqing Jiang > Signed-off-by: Fengguang Wu > --- > > bitmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/md/bitmap.c > +++ b/drivers/md/bitmap.c > @@ -2045,8 +2045,7 @@ int bitmap_resize(struct bitmap *bitmap, > > /* deallocate the page memory */ > for (k = 0; k < page; k++) { > - if (new_bp[k].map) > - kfree(new_bp[k].map); > + kfree(new_bp[k].map); > } > > /* restore some fields from old_counts */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >