From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 07/16] drm/i915/gen9: Allow skl_allocate_pipe_ddb() to operate on in-flight state (v2) Date: Thu, 21 Apr 2016 14:09:07 +0200 Message-ID: <5718C2E3.9090302@linux.intel.com> References: <1461119183-14267-1-git-send-email-matthew.d.roper@intel.com> <1461119183-14267-8-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id AC7006EC77 for ; Thu, 21 Apr 2016 12:09:08 +0000 (UTC) In-Reply-To: <1461119183-14267-8-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGV5LAoKT3AgMjAtMDQtMTYgb20gMDQ6MjYgc2NocmVlZiBNYXR0IFJvcGVyOgo+IFdlIGV2ZW50 dWFsbHkgd2FudCB0byBjYWxjdWxhdGUgd2F0ZXJtYXJrIHZhbHVlcyBhdCBhdG9taWMgJ2NoZWNr JyB0aW1lCj4gaW5zdGVhZCBvZiBhdG9taWMgJ2NvbW1pdCcgdGltZSBzbyB0aGF0IGFueSByZXF1 ZXN0ZWQgY29uZmlndXJhdGlvbnMKPiB0aGF0IHJlc3VsdCBpbiBpbXBvc3NpYmxlIHdhdGVybWFy ayByZXF1aXJlbWVudHMgYXJlIHByb3Blcmx5IHJlamVjdGVkLgo+IFRoZSBmaXJzdCBzdGVwIGFs b25nIHRoaXMgcGF0aCBpcyB0byBhbGxvY2F0ZSB0aGUgRERCIGF0IGF0b21pYyAnY2hlY2snCj4g dGltZS4gIEFzIHdlIHBlcmZvcm0gdGhpcyB0cmFuc2l0aW9uLCBhbGxvdyB0aGUgbWFpbiBhbGxv Y2F0aW9uIGZ1bmN0aW9uCj4gdG8gb3BlcmF0ZSBzdWNjZXNzZnVsbHkgb24gZWl0aGVyIGFuIGlu LWZsaWdodCBzdGF0ZSBvciBhbgo+IGFscmVhZHktY29tbWl0ZWQgc3RhdGUuICBPbmNlIHdlIGNv bXBsZXRlIHRoZSB0cmFuc2l0aW9uIGluIGEgZnV0dXJlCj4gcGF0Y2gsIHdlJ2xsIGNvbWUgYmFj ayBhbmQgcmVtb3ZlIHRoZSB1bm5lY2Vzc2FyeSBsb2dpYyBmb3IgdGhlCj4gYWxyZWFkeS1jb21t aXR0ZWQgY2FzZS4KPgo+IHYyOiBSZWJhc2UvcmVmYWN0b3I7IHdlIHNob3VsZCBubyBsb25nZXIg bmVlZCB0byBncmFiIGV4dHJhIHBsYW5lIHN0YXRlcwo+ICAgICB3aGlsZSBhbGxvY2F0aW5nIHRo ZSBEREIgc2luY2Ugd2UgY2FuIHB1bGwgY2FjaGVkIGRhdGEgcmF0ZXMgYW5kCj4gICAgIG1pbmlt dW0gYmxvY2sgY291bnRzIGZyb20gdGhlIENSVEMgc3RhdGUgZm9yIGFueSBwbGFuZXMgdGhhdCBh cmVuJ3QKPiAgICAgYmVpbmcgbW9kaWZpZWQgYnkgdGhpcyB0cmFuc2FjdGlvbi4KPgo+IFNpZ25l ZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgIDYgKysKPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDE3OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTM5IGluc2VydGlvbnMoKyksIDQ2IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggODUxMDJhZC4uZTkxZDM5 ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zMjQsNiArMzI0LDEyIEBAIHN0 cnVjdCBpOTE1X2hvdHBsdWcgewo+ICAJCQkgICAgJmRldi0+bW9kZV9jb25maWcucGxhbmVfbGlz dCwJXAo+ICAJCQkgICAgYmFzZS5oZWFkKQo+ICAKPiArI2RlZmluZSBmb3JfZWFjaF9pbnRlbF9w bGFuZV9tYXNrKGRldiwgaW50ZWxfcGxhbmUsIHBsYW5lX21hc2spCQlcCj4gKwlsaXN0X2Zvcl9l YWNoX2VudHJ5KGludGVsX3BsYW5lLCAmZGV2LT5tb2RlX2NvbmZpZy5wbGFuZV9saXN0LAlcCj4g KwkJCSAgICBiYXNlLmhlYWQpCQkJCQlcCj4gKwkJZm9yX2VhY2hfaWYgKChwbGFuZV9tYXNrKSAm CQkJCVwKPiArCQkJICAgICAoMSA8PCBkcm1fcGxhbmVfaW5kZXgoJmludGVsX3BsYW5lLT5iYXNl KSkpCj4gKwo+ICAjZGVmaW5lIGZvcl9lYWNoX2ludGVsX3BsYW5lX29uX2NydGMoZGV2LCBpbnRl bF9jcnRjLCBpbnRlbF9wbGFuZSkJXAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShpbnRlbF9wbGFu ZSwJCQkJXAo+ICAJCQkgICAgJihkZXYpLT5tb2RlX2NvbmZpZy5wbGFuZV9saXN0LAkJXAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYwo+IGluZGV4IDQ3OWE4OTAuLjY0MDMwNWEgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtMjg0OSwxMyArMjg0OSwxOCBAQCBza2xfd21fcGxhbmVf aWQoY29uc3Qgc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSkKPiAgc3RhdGljIHZvaWQKPiAgc2ts X2RkYl9nZXRfcGlwZV9hbGxvY2F0aW9uX2xpbWl0cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICAJCQkJICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPiAtCQkJCSAg IGNvbnN0IHN0cnVjdCBpbnRlbF93bV9jb25maWcgKmNvbmZpZywKPiAtCQkJCSAgIHN0cnVjdCBz a2xfZGRiX2VudHJ5ICphbGxvYyAvKiBvdXQgKi8pCj4gKwkJCQkgICBzdHJ1Y3QgaW50ZWxfd21f Y29uZmlnICpjb25maWcsCj4gKwkJCQkgICBzdHJ1Y3Qgc2tsX2RkYl9lbnRyeSAqYWxsb2MsIC8q IG91dCAqLwo+ICsJCQkJICAgaW50ICpudW1fYWN0aXZlIC8qIG91dCAqLykKPiAgewo+ICsJc3Ry dWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gY3N0YXRlLT5iYXNlLnN0YXRlOwo+ICsJc3Ry dWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPSB0b19pbnRlbF9hdG9taWNfc3Rh dGUoc3RhdGUpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShkZXYpOwo+ICAJc3RydWN0IGRybV9jcnRjICpmb3JfY3J0YyA9IGNzdGF0ZS0+YmFzZS5jcnRj Owo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICAJdW5zaWduZWQgaW50IHBpcGVfc2l6ZSwg ZGRiX3NpemU7Cj4gIAlpbnQgbnRoX2FjdGl2ZV9waXBlOwo+ICsJaW50IHBpcGUgPSB0b19pbnRl bF9jcnRjKGZvcl9jcnRjKS0+cGlwZTsKPiAgCj4gIAlpZiAoIWNzdGF0ZS0+YmFzZS5hY3RpdmUp IHsKPiAgCQlhbGxvYy0+c3RhcnQgPSAwOwo+IEBAIC0yODcwLDI1ICsyODc1LDU5IEBAIHNrbF9k ZGJfZ2V0X3BpcGVfYWxsb2NhdGlvbl9saW1pdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAg Cj4gIAlkZGJfc2l6ZSAtPSA0OyAvKiA0IGJsb2NrcyBmb3IgYnlwYXNzIHBhdGggYWxsb2NhdGlv biAqLwo+ICAKPiAtCW50aF9hY3RpdmVfcGlwZSA9IDA7Cj4gLQlmb3JfZWFjaF9jcnRjKGRldiwg Y3J0Yykgewo+IC0JCWlmICghdG9faW50ZWxfY3J0YyhjcnRjKS0+YWN0aXZlKQo+IC0JCQljb250 aW51ZTsKPiArCS8qCj4gKwkgKiBGSVhNRTogQXQgdGhlIG1vbWVudCB3ZSBtYXkgYmUgY2FsbGVk IG9uIGVpdGhlciBpbi1mbGlnaHQgb3IgZnVsbHkKPiArCSAqIGNvbW1pdHRlZCBjc3RhdGUncy4g IE9uY2Ugd2UgZnVsbHkgbW92ZSBEREIgYWxsb2NhdGlvbiBpbiB0aGUgY2hlY2sKPiArCSAqIHBo YXNlLCB3ZSdsbCBvbmx5IGJlIGNhbGxlZCBvbiBpbi1mbGlnaHQgc3RhdGVzIGFuZCB0aGUgJ2Vs c2UnCj4gKwkgKiBicmFuY2ggaGVyZSB3aWxsIGdvIGF3YXkuCj4gKwkgKgo+ICsJICogVGhlICdl bHNlJyBicmFuY2ggaXMgc2xpZ2h0bHkgcmFjeSBoZXJlLCBidXQgaXQgd2FzIHJhY3kgdG8gYmVn aW4KPiArCSAqIHdpdGg7IHNpbmNlIGl0J3MgZ29pbmcgYXdheSBzb29uLCBubyBlZmZvcnQgaXMg bWFkZSB0byBhZGRyZXNzIHRoYXQuCj4gKwkgKi8KPiArCWlmIChzdGF0ZSkgewo+ICsJCS8qCj4g KwkJICogSWYgdGhlIHN0YXRlIGRvZXNuJ3QgY2hhbmdlIHRoZSBhY3RpdmUgQ1JUQydzLCB0aGVu IHRoZXJlJ3MKPiArCQkgKiBubyBuZWVkIHRvIHJlY2FsY3VsYXRlOyB0aGUgZXhpc3RpbmcgcGlw ZSBhbGxvY2F0aW9uIGxpbWl0cwo+ICsJCSAqIHNob3VsZCByZW1haW4gdW5jaGFuZ2VkLiAgTm90 ZSB0aGF0IHdlJ3JlIHNhZmUgZnJvbSByYWNpbmcKPiArCQkgKiBjb21taXRzIHNpbmNlIGFueSBy YWNpbmcgY29tbWl0IHRoYXQgY2hhbmdlcyB0aGUgYWN0aXZlIENSVEMKPiArCQkgKiBsaXN0IHdv dWxkIG5lZWQgdG8gZ3JhYiBfYWxsXyBjcnRjIGxvY2tzLCBpbmNsdWRpbmcgdGhlIG9uZQo+ICsJ CSAqIHdlIGN1cnJlbnRseSBob2xkLgo+ICsJCSAqLwo+ICsJCWlmICghaW50ZWxfc3RhdGUtPmFj dGl2ZV9waXBlX2NoYW5nZXMpIHsKPiArCQkJKmFsbG9jID0gZGV2X3ByaXYtPndtLnNrbF9ody5k ZGIucGlwZVtwaXBlXTsKPiArCQkJKm51bV9hY3RpdmUgPSBod2VpZ2h0MzIoZGV2X3ByaXYtPmFj dGl2ZV9jcnRjcyk7Cj4gKwkJCXJldHVybjsKPiArCQl9Cj4gIAo+IC0JCWlmIChjcnRjID09IGZv cl9jcnRjKQo+IC0JCQlicmVhazsKPiArCQkqbnVtX2FjdGl2ZSA9IGh3ZWlnaHQzMihpbnRlbF9z dGF0ZS0+YWN0aXZlX2NydGNzKTsKPiArCQludGhfYWN0aXZlX3BpcGUgPSBod2VpZ2h0MzIoaW50 ZWxfc3RhdGUtPmFjdGl2ZV9jcnRjcyAmCj4gKwkJCQkJICAgIChkcm1fY3J0Y19tYXNrKGZvcl9j cnRjKSAtIDEpKTsKPiArCQlwaXBlX3NpemUgPSBkZGJfc2l6ZSAvIGh3ZWlnaHQzMihpbnRlbF9z dGF0ZS0+YWN0aXZlX2NydGNzKTsKPiArCQlhbGxvYy0+c3RhcnQgPSBudGhfYWN0aXZlX3BpcGUg KiBkZGJfc2l6ZSAvICpudW1fYWN0aXZlOwo+ICsJCWFsbG9jLT5lbmQgPSBhbGxvYy0+c3RhcnQg KyBwaXBlX3NpemU7Cj4gKwl9IGVsc2Ugewo+ICsJCW50aF9hY3RpdmVfcGlwZSA9IDA7Cj4gKwkJ Zm9yX2VhY2hfY3J0YyhkZXYsIGNydGMpIHsKPiArCQkJaWYgKCF0b19pbnRlbF9jcnRjKGNydGMp LT5hY3RpdmUpCj4gKwkJCQljb250aW51ZTsKPiAgCj4gLQkJbnRoX2FjdGl2ZV9waXBlKys7Cj4g LQl9Cj4gKwkJCWlmIChjcnRjID09IGZvcl9jcnRjKQo+ICsJCQkJYnJlYWs7Cj4gIAo+IC0JcGlw ZV9zaXplID0gZGRiX3NpemUgLyBjb25maWctPm51bV9waXBlc19hY3RpdmU7Cj4gLQlhbGxvYy0+ c3RhcnQgPSBudGhfYWN0aXZlX3BpcGUgKiBkZGJfc2l6ZSAvIGNvbmZpZy0+bnVtX3BpcGVzX2Fj dGl2ZTsKPiAtCWFsbG9jLT5lbmQgPSBhbGxvYy0+c3RhcnQgKyBwaXBlX3NpemU7Cj4gKwkJCW50 aF9hY3RpdmVfcGlwZSsrOwo+ICsJCX0KPiArCj4gKwkJcGlwZV9zaXplID0gZGRiX3NpemUgLyBj b25maWctPm51bV9waXBlc19hY3RpdmU7Cj4gKwkJYWxsb2MtPnN0YXJ0ID0gbnRoX2FjdGl2ZV9w aXBlICogZGRiX3NpemUgLwo+ICsJCQljb25maWctPm51bV9waXBlc19hY3RpdmU7Cj4gKwkJYWxs b2MtPmVuZCA9IGFsbG9jLT5zdGFydCArIHBpcGVfc2l6ZTsKPiArCQkqbnVtX2FjdGl2ZSA9IGNv bmZpZy0+bnVtX3BpcGVzX2FjdGl2ZTsKPiArCX0KPiAgfQo+ICAKPiAtc3RhdGljIHVuc2lnbmVk IGludCBza2xfY3Vyc29yX2FsbG9jYXRpb24oY29uc3Qgc3RydWN0IGludGVsX3dtX2NvbmZpZyAq Y29uZmlnKQo+ICtzdGF0aWMgdW5zaWduZWQgaW50IHNrbF9jdXJzb3JfYWxsb2NhdGlvbihpbnQg bnVtX2FjdGl2ZSkKPiAgewo+IC0JaWYgKGNvbmZpZy0+bnVtX3BpcGVzX2FjdGl2ZSA9PSAxKQo+ ICsJaWYgKG51bV9hY3RpdmUgPT0gMSkKPiAgCQlyZXR1cm4gMzI7Cj4gIAo+ICAJcmV0dXJuIDg7 Cj4gQEAgLTMwNTQsMzMgKzMwOTMsNDggQEAgc2tsX2dldF90b3RhbF9yZWxhdGl2ZV9kYXRhX3Jh dGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX2NzdGF0ZSkKPiAgCXJldHVybiB0b3Rh bF9kYXRhX3JhdGU7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkCj4gK3N0YXRpYyBpbnQKPiAgc2ts X2FsbG9jYXRlX3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJ ICAgICAgc3RydWN0IHNrbF9kZGJfYWxsb2NhdGlvbiAqZGRiIC8qIG91dCAqLykKPiAgewo+ICsJ c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gY3N0YXRlLT5iYXNlLnN0YXRlOwo+ICAJ c3RydWN0IGRybV9jcnRjICpjcnRjID0gY3N0YXRlLT5iYXNlLmNydGM7Cj4gIAlzdHJ1Y3QgZHJt X2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAJc3RydWN0IGludGVsX3dtX2NvbmZpZyAqY29uZmln ID0gJmRldl9wcml2LT53bS5jb25maWc7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0 YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmludGVsX3Bs YW5lOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lX3N0 YXRlICpwc3RhdGU7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gIAlz dHJ1Y3Qgc2tsX2RkYl9lbnRyeSAqYWxsb2MgPSAmZGRiLT5waXBlW3BpcGVdOwo+ICAJdWludDE2 X3QgYWxsb2Nfc2l6ZSwgc3RhcnQsIGN1cnNvcl9ibG9ja3M7Cj4gIAl1aW50MTZfdCAqbWluaW11 bSA9IGNzdGF0ZS0+d20uc2tsLm1pbmltdW1fYmxvY2tzOwo+ICAJdWludDE2X3QgKnlfbWluaW11 bSA9IGNzdGF0ZS0+d20uc2tsLm1pbmltdW1feV9ibG9ja3M7Cj4gIAl1bnNpZ25lZCBpbnQgdG90 YWxfZGF0YV9yYXRlOwo+ICsJaW50IG51bV9hY3RpdmU7Cj4gKwlpbnQgaWQsIGk7Cj4gKwo+ICsJ aWYgKCFjc3RhdGUtPmJhc2UuYWN0aXZlKSB7Cj4gKwkJZGRiLT5waXBlW3BpcGVdLnN0YXJ0ID0g ZGRiLT5waXBlW3BpcGVdLmVuZCA9IDA7Cj4gKwkJbWVtc2V0KGRkYi0+cGxhbmVbcGlwZV0sIDAs Cj4gKwkJICAgICAgIEk5MTVfTUFYX1BMQU5FUyAqIHNpemVvZihzdHJ1Y3Qgc2tsX2RkYl9lbnRy eSkpOwo+ICsJCW1lbXNldChkZGItPnlfcGxhbmVbcGlwZV0sIDAsCj4gKwkJICAgICAgIEk5MTVf TUFYX1BMQU5FUyAqIHNpemVvZihzdHJ1Y3Qgc2tsX2RkYl9lbnRyeSkpOwo+ICsJCXJldHVybiAw Owo+Cl5TaW5jZSB0aGVzZSBhcmUgcG9pbnRlcnMgdG8gYXJyYXlzLCBtZW1zZXQoeCwgMCwgc2l6 ZW9mKHgpKTsgPwoKQWxzbyB0aGVyZSBzdGlsbCBzZWVtcyB0byBiZSBhIGJvZ3VzIG1lbXNldCBm b3IgcGxhbmVbcGlwZV1bUExBTkVfQ1VSU09SXSwgYWZ0ZXIgcGxhbmVbcGlwZV0gd2FzIGp1c3Qg emVybydkLiBTaG91bGQgcHJvYmFibHkgYmUgZml4ZWQgd2hpbGUgeW91J3JlIHRvdWNoaW5nIHRo aXMgZnVuY3Rpb24uIDotKQoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==