From: Lars Persson <lars.persson@axis.com>
To: Arnd Bergmann <arnd@arndb.de>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
g.liakhovetski@gmx.de, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org
Subject: Re: [PATCH v3 2/3] mmc: usdhi6rol0: add support for UHS modes
Date: Thu, 21 Apr 2016 15:47:33 +0200 [thread overview]
Message-ID: <5718D9F5.5040808@axis.com> (raw)
In-Reply-To: <14935418.cYIzx5HmZZ@wuerfel>
On 04/21/2016 11:52 AM, Arnd Bergmann wrote:
> On Thursday 21 April 2016 10:26:55 Lars Persson wrote:
>>
>> It is a common pattern in all upstream mmc drivers to not make the call
>> to mmc_regulator_set_vqmmc() when a regulator is missing. We basically
>> want to log errors except for the EINVAL returned in case of a missing
>> regulator.
>>
>>
>
> I see what you mean here: two out of four drivers calling
> mmc_regulator_set_vqmmc() log errors to the console.
>
> If we want all drivers to behave consistently here, how about
> moving that error output into the mmc_regulator_set_vqmmc() function
> itself?
>
I will make a v4 that skips the error output and if Ulf agrees with your
proposal I will make another patch series to move the dev_dbg() into
mmc_regulator_set_vqmmc().
- Lars
next prev parent reply other threads:[~2016-04-21 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 14:53 [PATCH v3 0/3] mmc: usdhi6rol0: UHS support Lars Persson
2016-04-20 14:53 ` [PATCH v3 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding Lars Persson
2016-04-20 14:53 ` [PATCH v3 2/3] mmc: usdhi6rol0: add support for UHS modes Lars Persson
2016-04-21 7:12 ` Lars Persson
2016-04-21 7:53 ` Arnd Bergmann
2016-04-21 8:26 ` Lars Persson
2016-04-21 9:52 ` Arnd Bergmann
2016-04-21 13:47 ` Lars Persson [this message]
2016-04-20 14:53 ` [PATCH v3 3/3] mmc: usdhi6rol0: add pinctrl to set pin drive strength Lars Persson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5718D9F5.5040808@axis.com \
--to=lars.persson@axis.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.