Re: [Qemu-devel] [PATCH] migration: Promote improved autoconverge commands out of experimental state

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 4387 bytes --]

On 04/21/2016 09:39 AM, Jason J. Herne wrote:
> The new autoconverge throttling commands have been tested for a release now. It
> is time to move them out of the experimental state.
> 
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ---

> +++ b/qapi-schema.json
> @@ -480,9 +480,9 @@
>  #        may be expensive, but do not actually occur during the iterative
>  #        migration rounds themselves. (since 1.6)
>  #
> -# @x-cpu-throttle-percentage: #optional percentage of time guest cpus are being
> -#       throttled during auto-converge. This is only present when auto-converge
> -#       has started throttling guest cpus. (Since 2.5)
> +# @cpu-throttle-percentage: #optional percentage of time guest cpus are being
> +#        throttled during auto-converge. This is only present when auto-converge
> +#        has started throttling guest cpus. (Since 2.5)

s/2.5/2.7/ - while the grunt work has been around since 2.5, the actual
'cpu-throttle-percentage' option is new to 2.7.  Listing the time of
promotion matches what we have done elsewhere when promoting things to
stable.

> @@ -605,18 +605,18 @@
>  #          compression, so set the decompress-threads to the number about 1/4
>  #          of compress-threads is adequate.
>  #
> -# @x-cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> -#                          when migration auto-converge is activated. The
> -#                          default value is 20. (Since 2.5)
> +# @cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> +#                        when migration auto-converge is activated. The
> +#                        default value is 20. (Since 2.5)
>  #
> -# @x-cpu-throttle-increment: throttle percentage increase each time
> -#                            auto-converge detects that migration is not making
> -#                            progress. The default value is 10. (Since 2.5)
> +# @cpu-throttle-increment: throttle percentage increase each time
> +#                          auto-converge detects that migration is not making
> +#                          progress. The default value is 10. (Since 2.5)


Two more instances.

> @@ -629,21 +629,21 @@
>  #
>  # @decompress-threads: decompression thread count
>  #
> -# @x-cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> -#                          when migration auto-converge is activated. The
> -#                          default value is 20. (Since 2.5)
> +# @cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> +#                        when migration auto-converge is activated. The
> +#                        default value is 20. (Since 2.5)
>  #
> -# @x-cpu-throttle-increment: throttle percentage increase each time
> -#                            auto-converge detects that migration is not making
> -#                            progress. The default value is 10. (Since 2.5)
> +# @cpu-throttle-increment: throttle percentage increase each time
> +#                          auto-converge detects that migration is not making
> +#                          progress. The default value is 10. (Since 2.5)

And again.

> @@ -654,13 +654,13 @@
>  #
>  # @decompress-threads: decompression thread count
>  #
> -# @x-cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> -#                          when migration auto-converge is activated. The
> -#                          default value is 20. (Since 2.5)
> +# @cpu-throttle-initial: Initial percentage of time guest cpus are throttled
> +#                        when migration auto-converge is activated. The
> +#                        default value is 20. (Since 2.5)
>  #
> -# @x-cpu-throttle-increment: throttle percentage increase each time
> -#                            auto-converge detects that migration is not making
> -#                            progress. The default value is 10. (Since 2.5)
> +# @cpu-throttle-increment: throttle percentage increase each time
> +#                          auto-converge detects that migration is not making
> +#                          progress. The default value is 10. (Since 2.5)

and again

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]