All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 0/3] networking/stress/icmp: add ip xfrm ipsec support
Date: Fri, 22 Apr 2016 15:04:49 +0300	[thread overview]
Message-ID: <571A1361.4060909@oracle.com> (raw)
In-Reply-To: <1460517625-25960-1-git-send-email-haliu@redhat.com>

Hi Hangbin,
On 13.04.2016 6:20, Hangbin Liu wrote:
> As we know, most of the network stress tests have IPsec testing, and we use
> setkey for configuration. But setkey[1] hasn't updated for a long time. And
> some distros, RHEL7 for example, even don't have ipset-tools package. On
> other hand, iproute2 is recommend for network configuration. And ip xfrm is
> more powerful than setkey. So let's use ip xfrm for ipsec testing.
>
> [1] http://ipsec-tools.sourceforge.net/

When running the tests with this patch-set on OL6 I've encountered with 
failed tests
due to not supported ip options:

icmp-uni-basic 1 TINFO : - IPcomp [ transport ]
Error: argument "transport" is wrong: unknown

icmp-uni-basic 1 TINFO : - IPcomp [ tunnel ]
Error: argument "tunnel" is wrong: unknown

Have you tried running them on RHEL6?

It seems that iproute there requires some value passed after "... comp 
deflate ??? mode ..."

> Change from V4:
> 1. minimise icmp-uni-basic, remove some useless comment.
> 2. use tst_exit instead of exit 0
> 3. Fix max message size and add comment in network_stress.icmp to describe how
>     we calculate them.
> 4. fix some typo
> TODO: For icmp-uni-basic test, we test each message size to make sure the
> connectivity. In icmp-multi-diffip/nic test, we will do ping flood test with
> multi ip/nic for stress testing since we have already make sure the connectivity.
>
>
> Change from V3:
> 1. use message size array in tst_ping
> 2. add tst_ipsec_cleanup in ipsec_lib
> 3. use lhost/rhost naming in ipsec_lib
> 4. add icmp-uni-basic in the upper icmp directory
> 5. some other small fixs.
>
> Change from V2:
> 1. remove c2x and use hexdump directly.
> 2. remove indent after "case".
> 3. remove useless export and old scripts like check_env.
> 4. remove tst_init_iface.
> 5. remove return value check after setup ipsec env.
> 6. remove addr config as Alexey said, we assume the address already added.
>
> Change from V1:
> 1. update tst_ping() to use default iface and addr. make ping from local side.
> 2. remove unused variables. add -s option when use tst_rhost_run. Use ROD
>     before normal commands.
> 3. change all "tst_resm TBROK && exit" to "tst_brkm TBROK"
> 3. still keep tst_init_iface in test icmp4-uni-basic01 because we will
>     set_ipv4/6addr each time.
>
> Hangbin Liu (3):
>    lib/test_net.sh: add tst_ping() to check icmp connectivity
>    network/stress: add ipsec lib
>    network/stress/icmp: add icmp-uni-basic to implement all icmp basic
>      stress test
>
>   runtest/network_stress.icmp                  |  46 +++++++----
>   testcases/lib/test_net.sh                    |  30 ++++++++
>   testcases/network/stress/icmp/Makefile       |   3 +
>   testcases/network/stress/icmp/icmp-uni-basic | 105 +++++++++++++++++++++++++
>   testcases/network/stress/ipsec/Makefile      |  28 +++++++
>   testcases/network/stress/ipsec/ipsec_lib.sh  | 110 +++++++++++++++++++++++++++
>   6 files changed, 308 insertions(+), 14 deletions(-)
>   create mode 100755 testcases/network/stress/icmp/icmp-uni-basic
>   create mode 100644 testcases/network/stress/ipsec/Makefile
>   create mode 100644 testcases/network/stress/ipsec/ipsec_lib.sh
>


  parent reply	other threads:[~2016-04-22 12:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  3:20 [LTP] [PATCH v5 0/3] networking/stress/icmp: add ip xfrm ipsec support Hangbin Liu
2016-04-13  3:20 ` [LTP] [PATCH v5 1/3] lib/test_net.sh: add tst_ping() to check icmp connectivity Hangbin Liu
2016-04-13  3:20 ` [LTP] [PATCH v5 2/3] network/stress: add ipsec lib Hangbin Liu
2016-04-13  3:20 ` [LTP] [PATCH v5 3/3] network/stress/icmp: add icmp-uni-basic to implement all icmp basic stress test Hangbin Liu
2016-04-22 13:01   ` Alexey Kodanev
2016-04-25  1:57     ` Hangbin Liu
2016-04-22 12:04 ` Alexey Kodanev [this message]
2016-04-25  1:51   ` [LTP] [PATCH v5 0/3] networking/stress/icmp: add ip xfrm ipsec support Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571A1361.4060909@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.