All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] drivers/gpio/pm8916_gpio.c: Make pid be uint32_t
Date: Fri, 22 Apr 2016 16:12:15 +0200	[thread overview]
Message-ID: <571A313F.40303@gmail.com> (raw)
In-Reply-To: <20160420212541.GB3732@bill-the-cat>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

On 20.04.2016 23:25, Tom Rini wrote:
> On Mon, Apr 18, 2016 at 10:23:24PM +0200, Mateusz Kulikowski wrote:
[..]

>>
>> I think (now, when the coverity pointed out mistake) that we should add
>> in that case check if pid fits in 16-bits, as this is maximum pid value on spmi bus.
>>
>> This checks should be done in pm8916_gpio_probe() and pm8916_probe().
>>
>> Would you like to do it in your series or want me to post another patch on top of them?
> 
> Please do a follow up, thanks!
> 
Will do that, but it will take a few days as I have a lot of non-coding related assignments now :)

btw. SPMI core checks pid and sid internally during reads/writes so we're pretty safe anyway.

Regards,
Mateusz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXGjE2AAoJELvtohmVtQzBMj4H/3+zypiWH9BZdDheztNA6yZt
vN2fIz9kWQB8GFoBktU7kRAAWXaTDB0CWsKQmcqnJtZJeqyUV0Dj1CEJoS4fcptD
Lq0uljuufLkfkSb/XhRe5sLxWbvygHVrGBz/OemFCQivBlu8MEe4pwNyEUFwTHrc
otF9Uk1y92HjsyaQhjMX6WWR5Ei8hrVSryppt1eRFoGBAw9uL7TcKnc96IKrbFZ+
ns/40n/K8O2k8J2JMxMXB1QbJj/lEj/y4yY2Il2B2Z3WHb4ZhErtoko55uh0bGf4
PoGH1wPTZxNrcKn0CCwnHxmIxGJMpJ8XyZYhsEI4J+ZBs7izzb4dSn8ekOsr1nI=
=Y2ca
-----END PGP SIGNATURE-----

  reply	other threads:[~2016-04-22 14:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 19:11 [U-Boot] [PATCH 1/3] drivers/tpm/tpm_tis_sandbox.c: Fix uninitialized variable use Tom Rini
2016-04-12 19:11 ` [U-Boot] [PATCH 2/3] drivers/gpio/pm8916_gpio.c: Make pid be uint32_t Tom Rini
2016-04-18 20:23   ` Mateusz Kulikowski
2016-04-18 20:24     ` Mateusz Kulikowski
2016-04-20 21:26       ` Tom Rini
2016-04-20 21:25     ` Tom Rini
2016-04-22 14:12       ` Mateusz Kulikowski [this message]
2016-04-21 11:23   ` [U-Boot] [U-Boot, " Tom Rini
2016-04-12 19:11 ` [U-Boot] [PATCH 3/3] drivers/power/pmic/pm8916.c: Make usid " Tom Rini
2016-04-21 11:23   ` [U-Boot] [U-Boot, " Tom Rini
2016-04-15 14:12 ` [U-Boot] [PATCH 1/3] drivers/tpm/tpm_tis_sandbox.c: Fix uninitialized variable use Simon Glass
2016-04-15 15:44   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571A313F.40303@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.